From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 3/5] xen/domain: Audit config->max_vcpus during {, arch_}check_domain_config() Date: Tue, 9 Oct 2018 12:23:28 +0100 Message-ID: References: <1538751289-1109-1-git-send-email-andrew.cooper3@citrix.com> <1538751289-1109-4-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1538751289-1109-4-git-send-email-andrew.cooper3@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper , Xen-devel Cc: Stefano Stabellini , Wei Liu , Jan Beulich List-Id: xen-devel@lists.xenproject.org SGkgQW5kcmV3LAoKT24gMDUvMTAvMjAxOCAxNTo1NCwgQW5kcmV3IENvb3BlciB3cm90ZToKPiBU aGUgcHVycG9zZSBvZiB0aGlzIGlzIHRvIG1vdmUgdGhlIGF1ZHV0aW5nIHRvIGJlIGVhcmxpZXIg dGhhbgo+IGFyY2hfZG9tYWluX2NyZWF0ZSgpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBD b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4gLS0tCj4gQ0M6IEphbiBCZXVsaWNo IDxKQmV1bGljaEBzdXNlLmNvbT4KPiBDQzogV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT4K PiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgo+IENDOiBK dWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgo+IAo+IFRoZSBtYXhfdmNwdXMgc2V0 dGluZyBmb3IgR0lDX1YzIGlzIHNvbWV3aGF0IGNvbmZ1c2luZy4gIFRoZSBjdXJyZW50IEdJQ19W Mwo+IGRyaXZlciBjbGFpbXMgdG8gc3VwcG9ydCA0MDk2IGNwdXMsIHdoaWxlIHRoZSBuZXdlciBH SUNfVjMgZHJpdmVyIHVzZXMgMjU1LgoKVGhlIG1heGltdW0gbnVtYmVyIG9mIHZDUFVzIHN1cHBv cnRlZCBmb3IgR0lDdjMgZGVwZW5kcyBvbiB0aGUgbnVtYmVyIG9mIAphZmZpbml0eSBsZXZlbHMg c3VwcG9ydGVkIGJ5IHRoZSB2R0lDIGVtdWxhdGlvbi4KCj4gLS0tCj4gICB4ZW4vYXJjaC9hcm0v ZG9tYWluLmMgfCAxOCArKysrKysrKysrKysrKysrKysKPiAgIHhlbi9hcmNoL3g4Ni9kb21haW4u YyB8ICA2ICsrKysrKwo+ICAgeGVuL2NvbW1vbi9kb21haW4uYyAgIHwgIDMgKysrCj4gICAzIGZp bGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv YXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jCj4gaW5kZXggNDM1OTNhNC4uOTY3 Njg5MyAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMKPiArKysgYi94ZW4vYXJj aC9hcm0vZG9tYWluLmMKPiBAQCAtNjAxLDYgKzYwMSw4IEBAIHZvaWQgdmNwdV9zd2l0Y2hfdG9f YWFyY2g2NF9tb2RlKHN0cnVjdCB2Y3B1ICp2KQo+ICAgCj4gICBpbnQgYXJjaF9jaGVja19kb21h aW5fY29uZmlnKHN0cnVjdCB4ZW5fZG9tY3RsX2NyZWF0ZWRvbWFpbiAqY29uZmlnKQo+ICAgewo+ ICsgICAgdW5zaWduZWQgaW50IG1heF92Y3B1cyA9IDA7Cj4gKwo+ICAgICAgIC8qIEZpbGwgaW4g dGhlIG5hdGl2ZSBHSUMgdmVyc2lvbiwgcGFzc2VkIGJhY2sgdG8gdGhlIHRvb2xzdGFjay4gKi8K PiAgICAgICBpZiAoIGNvbmZpZy0+YXJjaC5naWNfdmVyc2lvbiA9PSBYRU5fRE9NQ1RMX0NPTkZJ R19HSUNfTkFUSVZFICkKPiAgICAgICB7Cj4gQEAgLTYxOSw2ICs2MjEsMjIgQEAgaW50IGFyY2hf Y2hlY2tfZG9tYWluX2NvbmZpZyhzdHJ1Y3QgeGVuX2RvbWN0bF9jcmVhdGVkb21haW4gKmNvbmZp ZykKPiAgICAgICAgICAgfQo+ICAgICAgIH0KPiAgIAo+ICsgICAgLyogQ2FsY3VsYXRlIHRoZSBt YXhpbXVtIG51bWJlciBvZiB2Y3B1cyBmcm9tIHRoZSBzZWxlY3RlZCBHSUMgdmVyc2lvbi4uLiAq Lwo+ICsgICAgc3dpdGNoICggY29uZmlnLT5hcmNoLmdpY192ZXJzaW9uICkKPiArICAgIHsKPiAr ICAgIGNhc2UgR0lDX1YyOiBtYXhfdmNwdXMgPSA4OyAgIGJyZWFrOwo+ICsgICAgY2FzZSBHSUNf VjM6IG1heF92Y3B1cyA9IDI1NTsgYnJlYWs7Cj4gKwo+ICsgICAgZGVmYXVsdDoKPiArICAgICAg ICByZXR1cm4gLUVPUE5PVFNVUFA7Cj4gKyAgICB9CgpJIHdvdWxkIHByZWZlciB0byBrZWVwIHRo b3NlIHZhbHVlcyBpbiBhIHNlcGFyYXRlIGhlbHBlciBpbXBsZW1lbnRlZCBieSAKZWFjaCB2R0lD LgoKPiArCj4gKyAgICAvKiAuLi4gY2xpcHBlZCBhdCB0aGUgbWF4aW11bSB2YWx1ZSBYZW4gaGFz IGJlZW4gY29uZmlndXJlZCBmb3IuICovCj4gKyAgICBtYXhfdmNwdXMgPSBtaW4obWF4X3ZjcHVz LCBNQVhfVklSVF9DUFVTICsgMHUpOwoKKyAwVSBmZWVscyBhIGJpdCBvZGQgdG8gcmVhZC4gSXQg d291bGQgYmUgYmV0dGVyIHRvIGFwcGVuZCB1IGluIApNQVhfVklSVF9DUFVTLgoKPiArCj4gKyAg ICBpZiAoIGNvbmZpZy0+bWF4X3ZjcHVzID4gbWF4X3ZjcHVzICkKPiArICAgICAgICByZXR1cm4g LUVJTlZBTDsKPiArCj4gICAgICAgcmV0dXJuIDA7Cj4gICB9Cj4gICAKPiBkaWZmIC0tZ2l0IGEv eGVuL2FyY2gveDg2L2RvbWFpbi5jIGIveGVuL2FyY2gveDg2L2RvbWFpbi5jCj4gaW5kZXggMjZj YWI3Yy4uMTkwMjNkNCAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYvZG9tYWluLmMKPiArKysg Yi94ZW4vYXJjaC94ODYvZG9tYWluLmMKPiBAQCAtNDAzLDYgKzQwMywxMiBAQCB2b2lkIGFyY2hf dmNwdV9kZXN0cm95KHN0cnVjdCB2Y3B1ICp2KQo+ICAgCj4gICBpbnQgYXJjaF9jaGVja19kb21h aW5fY29uZmlnKHN0cnVjdCB4ZW5fZG9tY3RsX2NyZWF0ZWRvbWFpbiAqY29uZmlnKQo+ICAgewo+ ICsgICAgdW5zaWduZWQgaW50IG1heF92Y3B1cyA9ICgoY29uZmlnLT5mbGFncyAmIFhFTl9ET01D VExfQ0RGX2h2bV9ndWVzdCkKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPyBIVk1f TUFYX1ZDUFVTIDogTUFYX1ZJUlRfQ1BVUyk7Cj4gKwo+ICsgICAgaWYgKCBjb25maWctPm1heF92 Y3B1cyA+IG1heF92Y3B1cyApCj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICAgICAg IHJldHVybiAwOwo+ICAgfQo+ICAgCj4gZGlmZiAtLWdpdCBhL3hlbi9jb21tb24vZG9tYWluLmMg Yi94ZW4vY29tbW9uL2RvbWFpbi5jCj4gaW5kZXggMjM2YzJhZC4uOTg4MjU1MCAxMDA2NDQKPiAt LS0gYS94ZW4vY29tbW9uL2RvbWFpbi5jCj4gKysrIGIveGVuL2NvbW1vbi9kb21haW4uYwo+IEBA IC0yOTcsNiArMjk3LDkgQEAgc3RhdGljIGludCBjaGVja19kb21haW5fY29uZmlnKHN0cnVjdCB4 ZW5fZG9tY3RsX2NyZWF0ZWRvbWFpbiAqY29uZmlnKQo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgWEVOX0RPTUNUTF9DREZfeHNfZG9tYWluKSApCj4gICAgICAgICAgIHJldHVybiAtRUlO VkFMOwo+ICAgCj4gKyAgICBpZiAoIGNvbmZpZy0+bWF4X3ZjcHVzIDwgMSApCj4gKyAgICAgICAg cmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICAgICAgIHJldHVybiBhcmNoX2NoZWNrX2RvbWFpbl9jb25m aWcoY29uZmlnKTsKPiAgIH0KPiAgIAo+IAoKQ2hlZXJzLAoKLS0gCkp1bGllbiBHcmFsbAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1h aWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==