From: Juergen Gross <jgross@suse.com>
To: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>,
Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH 4/5] xen, x86/headers: Add <linux/device.h> dependency to <asm/xen/page.h>
Date: Wed, 1 Feb 2017 11:00:35 +0100 [thread overview]
Message-ID: <b2a86ff2-c604-e68f-ece8-8f852e533d4d@suse.com> (raw)
In-Reply-To: <1485942677-19973-5-git-send-email-mingo@kernel.org>
On 01/02/17 10:51, Ingo Molnar wrote:
> The following patch (not upstream yet):
>
> "x86/boot/e820: Remove spurious asm/e820/api.h inclusions"
>
> Removed the (spurious) <asm/e820.h> include line from <asm/pgtable.h> to
> reduce header file dependencies - but a Xen header has (unintentionally)
> learned to rely on the indirect inclusion of <linux/device.h>.
>
> This resulted in the following (harmless) build warning:
>
> arch/x86/include/asm/xen/page.h:302:7: warning: 'struct device' declared inside parameter list
>
> Include <linux/device.h> explicitly.
>
> No change in functionality.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: <stefano.stabellini@eu.citrix.com>
> Cc: Juergen Gross <jgross@suse.com>
Hmm, how did you send this? In spite of the Cc: list in the patch only
few of those listed here are included in the Cc: header of the mail.
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Juergen Gross <jgross@suse.com>
Juergen
next prev parent reply other threads:[~2017-02-01 10:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 9:51 [PATCH 0/5] x86: Clean up and reorganize the E820 table handling code, #updates Ingo Molnar
2017-02-01 9:51 ` [PATCH 1/5] x86/boot/e820: Fix and clean up e820_type switch() statements Ingo Molnar
2017-02-01 9:51 ` [PATCH 2/5] x86/boot/e820: Separate the E820 ABI structures from the in-kernel structures Ingo Molnar
2017-02-01 9:51 ` [PATCH 3/5] x86/boot/e820: Simplify e820__update_table() Ingo Molnar
2017-02-01 9:51 ` [PATCH 4/5] xen, x86/headers: Add <linux/device.h> dependency to <asm/xen/page.h> Ingo Molnar
2017-02-01 10:00 ` Juergen Gross [this message]
2017-02-01 10:08 ` Ingo Molnar
2017-02-01 9:51 ` [PATCH 5/5] x86/boot: Fix pr_debug() API braindamage Ingo Molnar
2017-02-01 11:57 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2a86ff2-c604-e68f-ece8-8f852e533d4d@suse.com \
--to=jgross@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.