Re: [PATCH mptcp-next] Squash to "mptcp: add subflow_v(4,6)_send_synack()"

[Matthieu Baerts <matthieu.baerts@tessares.net>]

Hello,

On 25/11/2022 22:20, Matthieu Baerts wrote:
> This is a small cleanup, just to avoid duplicating the whole function
> for v4 and v6 while the only difference between the two is one call to a
> different send_synack() function.
> 
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> ---
>  net/mptcp/subflow.c | 35 ++++++++++++++++++-----------------
>  1 file changed, 18 insertions(+), 17 deletions(-)
> 
> diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
> index 05099b3760b5..2ff3840fc058 100644
> --- a/net/mptcp/subflow.c
> +++ b/net/mptcp/subflow.c
> @@ -307,12 +307,9 @@ static struct dst_entry *subflow_v4_route_req(const struct sock *sk,
>  	return NULL;
>  }
>  
> -static int subflow_v4_send_synack(const struct sock *sk, struct dst_entry *dst,
> -				  struct flowi *fl,
> -				  struct request_sock *req,
> -				  struct tcp_fastopen_cookie *foc,
> -				  enum tcp_synack_type synack_type,
> -				  struct sk_buff *syn_skb)
> +static void subflow_send_synack(const struct sock *sk, struct request_sock *req,

I just applied this patch with a small change:

    s/subflow_send_synack/subflow_prep_synack/

- 61e817662ce3: "squashed" in "mptcp: add subflow_v(4,6)_send_synack()"
- Results: 2deca8211919..ace83548981f (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20221125T222831

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net