Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: Add check for intel device on use_enginecopy

[Maira Canal <mairacanal@riseup.net>]

Hi Arthur,

On 7/3/23 16:00, Arthur Grillo wrote:
> Certain tests (eg: kms_plane) are failing on vkms due to an assert in
> intel_get_drm_devid which checks for an intel device.
> 
> Add check for intel device before calling intel_get_drm_devid.
> 
> Fixes: 422557124731 ("lib/igt_fb: include lib/intel_blt functions to blitter path")
> 
> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>

Reviewed-by: Maíra Canal <mairacanal@riseup.net>

Best Regards,
- Maíra

> ---
>   lib/igt_fb.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 9529d198a..a8988274f 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -2526,6 +2526,9 @@ static bool blitter_ok(const struct igt_fb *fb)
>   
>   static bool use_enginecopy(const struct igt_fb *fb)
>   {
> +	if (!is_intel_device(fb->fd))
> +		return false;
> +
>   	if (!is_xe_device(fb->fd) && blitter_ok(fb))
>   		return false;
>