From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clinton Taylor Subject: Re: [PATCH v3 1/2] drm/i915: Make sandybridge_pcode_read() deal with the second data register Date: Mon, 6 May 2019 15:01:59 -0700 Message-ID: References: <20190503190831.1759-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E76E8991E for ; Mon, 6 May 2019 23:00:59 +0000 (UTC) In-Reply-To: <20190503190831.1759-1-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org VmVyeSBzdHJhaWdodCBmb3J3YXJkLiBOaXQgdmFyaWFibGUgbmFtZXMgdmFsIGFuZCB2YWwxLCBt YXliZSB2YWwwIGFuZCB2YWwxLgoKUmV2aWV3ZWQtYnk6IENsaW50IFRheWxvciA8Q2xpbnRvbi5B LlRheWxvckBpbnRlbC5jb20+CgotQ2xpbnQKCgpPbiA1LzMvMTkgMTI6MDggUE0sIFZpbGxlIFN5 cmphbGEgd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPgo+IFRoZSBwY29kZSBtYWlsYm94IGhhcyB0d28gZGF0YSByZWdpc3RlcnMu IFNvIGZhciB3ZSd2ZSBvbmx5IGV2ZXIgdXNlZAo+IHRoZSBvbmUsIGJ1dCB0aGF0J3MgYWJvdXQg dG8gY2hhbmdlLiBFeHBvc2UgdGhlIHNlY29uZCBkYXRhIHJlZ2lzdGVyIHRvCj4gdGhlIGNhbGxl cnMgb2Ygc2FuZHlicmlkZ2VfcGNvZGVfcmVhZCgpLgo+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jICAgfCAgNCArKy0tCj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9wbS5jICAgICAgIHwgMTIgKysrKysrKy0tLS0tCj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9zaWRlYmFuZC5jIHwgMTUgKysrKysrKysrLS0tLS0tCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zaWRlYmFuZC5oIHwgIDMgKystCj4gICA0IGZpbGVz IGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBpbmRleCAxNGNkODNlOWVhOGIuLjIwMzA4OGY2ZjI2OSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gQEAgLTE0OTQsNyArMTQ5NCw3 IEBAIHN0YXRpYyBpbnQgZ2VuNl9kcnBjX2luZm8oc3RydWN0IHNlcV9maWxlICptKQo+ICAgCj4g ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPD0gNykKPiAgIAkJc2FuZHlicmlkZ2VfcGNvZGVf cmVhZChkZXZfcHJpdiwgR0VONl9QQ09ERV9SRUFEX1JDNlZJRFMsCj4gLQkJCQkgICAgICAgJnJj NnZpZHMpOwo+ICsJCQkJICAgICAgICZyYzZ2aWRzLCBOVUxMKTsKPiAgIAo+ICAgCXNlcV9wcmlu dGYobSwgIlJDMWUgRW5hYmxlZDogJXNcbiIsCj4gICAJCSAgIHllc25vKHJjY3RsMSAmIEdFTjZf UkNfQ1RMX1JDMWVfRU5BQkxFKSk7Cj4gQEAgLTE3NzcsNyArMTc3Nyw3IEBAIHN0YXRpYyBpbnQg aTkxNV9yaW5nX2ZyZXFfdGFibGUoc3RydWN0IHNlcV9maWxlICptLCB2b2lkICp1bnVzZWQpCj4g ICAJCWlhX2ZyZXEgPSBncHVfZnJlcTsKPiAgIAkJc2FuZHlicmlkZ2VfcGNvZGVfcmVhZChkZXZf cHJpdiwKPiAgIAkJCQkgICAgICAgR0VONl9QQ09ERV9SRUFEX01JTl9GUkVRX1RBQkxFLAo+IC0J CQkJICAgICAgICZpYV9mcmVxKTsKPiArCQkJCSAgICAgICAmaWFfZnJlcSwgTlVMTCk7Cj4gICAJ CXNlcV9wcmludGYobSwgIiVkXHRcdCVkXHRcdFx0XHQlZFxuIiwKPiAgIAkJCSAgIGludGVsX2dw dV9mcmVxKGRldl9wcml2LCAoZ3B1X2ZyZXEgKgo+ICAgCQkJCQkJICAgICAoSVNfR0VOOV9CQyhk ZXZfcHJpdikgfHwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0u YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBpbmRleCBlZjlmYzc3ZjgxNjIu LmIwNDNhOTZlMTIzYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9w bS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IEBAIC0yODIyLDcg KzI4MjIsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9yZWFkX3dtX2xhdGVuY3koc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCQl2YWwgPSAwOyAvKiBkYXRhMCB0byBiZSBwcm9n cmFtbWVkIHRvIDAgZm9yIGZpcnN0IHNldCAqLwo+ICAgCQlyZXQgPSBzYW5keWJyaWRnZV9wY29k ZV9yZWFkKGRldl9wcml2LAo+ICAgCQkJCQkgICAgIEdFTjlfUENPREVfUkVBRF9NRU1fTEFURU5D WSwKPiAtCQkJCQkgICAgICZ2YWwpOwo+ICsJCQkJCSAgICAgJnZhbCwgTlVMTCk7Cj4gICAKPiAg IAkJaWYgKHJldCkgewo+ICAgCQkJRFJNX0VSUk9SKCJTS0wgTWFpbGJveCByZWFkIGVycm9yID0g JWRcbiIsIHJldCk7Cj4gQEAgLTI4NDEsNyArMjg0MSw3IEBAIHN0YXRpYyB2b2lkIGludGVsX3Jl YWRfd21fbGF0ZW5jeShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJCXZh bCA9IDE7IC8qIGRhdGEwIHRvIGJlIHByb2dyYW1tZWQgdG8gMSBmb3Igc2Vjb25kIHNldCAqLwo+ ICAgCQlyZXQgPSBzYW5keWJyaWRnZV9wY29kZV9yZWFkKGRldl9wcml2LAo+ICAgCQkJCQkgICAg IEdFTjlfUENPREVfUkVBRF9NRU1fTEFURU5DWSwKPiAtCQkJCQkgICAgICZ2YWwpOwo+ICsJCQkJ CSAgICAgJnZhbCwgTlVMTCk7Cj4gICAJCWlmIChyZXQpIHsKPiAgIAkJCURSTV9FUlJPUigiU0tM IE1haWxib3ggcmVhZCBlcnJvciA9ICVkXG4iLCByZXQpOwo+ICAgCQkJcmV0dXJuOwo+IEBAIC03 MDYxLDcgKzcwNjEsNyBAQCBzdGF0aWMgdm9pZCBnZW42X2luaXRfcnBzX2ZyZXF1ZW5jaWVzKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAo+ICAgCQlpZiAoc2FuZHlicmlk Z2VfcGNvZGVfcmVhZChkZXZfcHJpdiwKPiAgIAkJCQkJICAgSFNXX1BDT0RFX0RZTkFNSUNfRFVU WV9DWUNMRV9DT05UUk9MLAo+IC0JCQkJCSAgICZkZGNjX3N0YXR1cykgPT0gMCkKPiArCQkJCQkg ICAmZGRjY19zdGF0dXMsIE5VTEwpID09IDApCj4gICAJCQlycHMtPmVmZmljaWVudF9mcmVxID0K PiAgIAkJCQljbGFtcF90KHU4LAo+ICAgCQkJCQkoKGRkY2Nfc3RhdHVzID4+IDgpICYgMHhmZiks Cj4gQEAgLTc0MDgsNyArNzQwOCw4IEBAIHN0YXRpYyB2b2lkIGdlbjZfZW5hYmxlX3JjNihzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJCSAgIEdFTjZfUkNfQ1RMX0hXX0VO QUJMRSk7Cj4gICAKPiAgIAlyYzZ2aWRzID0gMDsKPiAtCXJldCA9IHNhbmR5YnJpZGdlX3Bjb2Rl X3JlYWQoZGV2X3ByaXYsIEdFTjZfUENPREVfUkVBRF9SQzZWSURTLCAmcmM2dmlkcyk7Cj4gKwly ZXQgPSBzYW5keWJyaWRnZV9wY29kZV9yZWFkKGRldl9wcml2LCBHRU42X1BDT0RFX1JFQURfUkM2 VklEUywKPiArCQkJCSAgICAgJnJjNnZpZHMsIE5VTEwpOwo+ICAgCWlmIChJU19HRU4oZGV2X3By aXYsIDYpICYmIHJldCkgewo+ICAgCQlEUk1fREVCVUdfRFJJVkVSKCJDb3VsZG4ndCBjaGVjayBm b3IgQklPUyB3b3JrYXJvdW5kXG4iKTsKPiAgIAl9IGVsc2UgaWYgKElTX0dFTihkZXZfcHJpdiwg NikgJiYgKEdFTjZfREVDT0RFX1JDNl9WSUQocmM2dmlkcyAmIDB4ZmYpIDwgNDUwKSkgewo+IEBA IC04NTU1LDcgKzg1NTYsOCBAQCB2b2lkIGludGVsX2luaXRfZ3RfcG93ZXJzYXZlKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAkgICAgSVNfSVZZQlJJREdFKGRldl9wcml2 KSB8fCBJU19IQVNXRUxMKGRldl9wcml2KSkgewo+ICAgCQl1MzIgcGFyYW1zID0gMDsKPiAgIAo+ IC0JCXNhbmR5YnJpZGdlX3Bjb2RlX3JlYWQoZGV2X3ByaXYsIEdFTjZfUkVBRF9PQ19QQVJBTVMs ICZwYXJhbXMpOwo+ICsJCXNhbmR5YnJpZGdlX3Bjb2RlX3JlYWQoZGV2X3ByaXYsIEdFTjZfUkVB RF9PQ19QQVJBTVMsCj4gKwkJCQkgICAgICAgJnBhcmFtcywgTlVMTCk7Cj4gICAJCWlmIChwYXJh bXMgJiBCSVQoMzEpKSB7IC8qIE9DIHN1cHBvcnRlZCAqLwo+ICAgCQkJRFJNX0RFQlVHX0RSSVZF UigiT3ZlcmNsb2NraW5nIHN1cHBvcnRlZCwgbWF4OiAlZE1Ieiwgb3ZlcmNsb2NrOiAlZE1Ielxu IiwKPiAgIAkJCQkJIChycHMtPm1heF9mcmVxICYgMHhmZikgKiA1MCwKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3NpZGViYW5kLmMKPiBpbmRleCA4N2I1YTE0YzdjYTguLmExMTU2MjVlOTgwYyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zaWRlYmFuZC5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQuYwo+IEBAIC0zNzQsNyArMzc0 LDcgQEAgc3RhdGljIGlubGluZSBpbnQgZ2VuN19jaGVja19tYWlsYm94X3N0YXR1cyh1MzIgbWJv eCkKPiAgIH0KPiAgIAo+ICAgc3RhdGljIGludCBfX3NhbmR5YnJpZGdlX3Bjb2RlX3J3KHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+IC0JCQkJICB1MzIgbWJveCwgdTMyICp2YWwsCj4g KwkJCQkgIHUzMiBtYm94LCB1MzIgKnZhbCwgdTMyICp2YWwxLAo+ICAgCQkJCSAgaW50IGZhc3Rf dGltZW91dF91cywKPiAgIAkJCQkgIGludCBzbG93X3RpbWVvdXRfbXMsCj4gICAJCQkJICBib29s IGlzX3JlYWQpCj4gQEAgLTM5Myw3ICszOTMsNyBAQCBzdGF0aWMgaW50IF9fc2FuZHlicmlkZ2Vf cGNvZGVfcncoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gICAJCXJldHVybiAtRUFH QUlOOwo+ICAgCj4gICAJaW50ZWxfdW5jb3JlX3dyaXRlX2Z3KHVuY29yZSwgR0VONl9QQ09ERV9E QVRBLCAqdmFsKTsKPiAtCWludGVsX3VuY29yZV93cml0ZV9mdyh1bmNvcmUsIEdFTjZfUENPREVf REFUQTEsIDApOwo+ICsJaW50ZWxfdW5jb3JlX3dyaXRlX2Z3KHVuY29yZSwgR0VONl9QQ09ERV9E QVRBMSwgdmFsMSA/ICp2YWwxIDogMCk7Cj4gICAJaW50ZWxfdW5jb3JlX3dyaXRlX2Z3KHVuY29y ZSwKPiAgIAkJCSAgICAgIEdFTjZfUENPREVfTUFJTEJPWCwgR0VONl9QQ09ERV9SRUFEWSB8IG1i b3gpOwo+ICAgCj4gQEAgLTQwNyw2ICs0MDcsOCBAQCBzdGF0aWMgaW50IF9fc2FuZHlicmlkZ2Vf cGNvZGVfcncoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gICAKPiAgIAlpZiAoaXNf cmVhZCkKPiAgIAkJKnZhbCA9IGludGVsX3VuY29yZV9yZWFkX2Z3KHVuY29yZSwgR0VONl9QQ09E RV9EQVRBKTsKPiArCWlmIChpc19yZWFkICYmIHZhbDEpCj4gKwkJKnZhbDEgPSBpbnRlbF91bmNv cmVfcmVhZF9mdyh1bmNvcmUsIEdFTjZfUENPREVfREFUQTEpOwo+ICAgCj4gICAJaWYgKElOVEVM X0dFTihpOTE1KSA+IDYpCj4gICAJCXJldHVybiBnZW43X2NoZWNrX21haWxib3hfc3RhdHVzKG1i b3gpOwo+IEBAIC00MTQsMTIgKzQxNiwxMyBAQCBzdGF0aWMgaW50IF9fc2FuZHlicmlkZ2VfcGNv ZGVfcncoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gICAJCXJldHVybiBnZW42X2No ZWNrX21haWxib3hfc3RhdHVzKG1ib3gpOwo+ICAgfQo+ICAgCj4gLWludCBzYW5keWJyaWRnZV9w Y29kZV9yZWFkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LCB1MzIgbWJveCwgdTMyICp2 YWwpCj4gK2ludCBzYW5keWJyaWRnZV9wY29kZV9yZWFkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICppOTE1LCB1MzIgbWJveCwKPiArCQkJICAgdTMyICp2YWwsIHUzMiAqdmFsMSkKPiAgIHsKPiAg IAlpbnQgZXJyOwo+ICAgCj4gICAJbXV0ZXhfbG9jaygmaTkxNS0+c2JfbG9jayk7Cj4gLQllcnIg PSBfX3NhbmR5YnJpZGdlX3Bjb2RlX3J3KGk5MTUsIG1ib3gsIHZhbCwKPiArCWVyciA9IF9fc2Fu ZHlicmlkZ2VfcGNvZGVfcncoaTkxNSwgbWJveCwgdmFsLCB2YWwxLAo+ICAgCQkJCSAgICAgNTAw LCAwLAo+ICAgCQkJCSAgICAgdHJ1ZSk7Cj4gICAJbXV0ZXhfdW5sb2NrKCZpOTE1LT5zYl9sb2Nr KTsKPiBAQCAtNDQwLDcgKzQ0Myw3IEBAIGludCBzYW5keWJyaWRnZV9wY29kZV93cml0ZV90aW1l b3V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICAgCWludCBlcnI7Cj4gICAKPiAg IAltdXRleF9sb2NrKCZpOTE1LT5zYl9sb2NrKTsKPiAtCWVyciA9IF9fc2FuZHlicmlkZ2VfcGNv ZGVfcncoaTkxNSwgbWJveCwgJnZhbCwKPiArCWVyciA9IF9fc2FuZHlicmlkZ2VfcGNvZGVfcnco aTkxNSwgbWJveCwgJnZhbCwgTlVMTCwKPiAgIAkJCQkgICAgIGZhc3RfdGltZW91dF91cywgc2xv d190aW1lb3V0X21zLAo+ICAgCQkJCSAgICAgZmFsc2UpOwo+ICAgCW11dGV4X3VubG9jaygmaTkx NS0+c2JfbG9jayk7Cj4gQEAgLTQ1Nyw3ICs0NjAsNyBAQCBzdGF0aWMgYm9vbCBza2xfcGNvZGVf dHJ5X3JlcXVlc3Qoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIHUzMiBtYm94LAo+ICAg CQkJCSAgdTMyIHJlcXVlc3QsIHUzMiByZXBseV9tYXNrLCB1MzIgcmVwbHksCj4gICAJCQkJICB1 MzIgKnN0YXR1cykKPiAgIHsKPiAtCSpzdGF0dXMgPSBfX3NhbmR5YnJpZGdlX3Bjb2RlX3J3KGk5 MTUsIG1ib3gsICZyZXF1ZXN0LAo+ICsJKnN0YXR1cyA9IF9fc2FuZHlicmlkZ2VfcGNvZGVfcnco aTkxNSwgbWJveCwgJnJlcXVlc3QsIE5VTEwsCj4gICAJCQkJCSA1MDAsIDAsCj4gICAJCQkJCSB0 cnVlKTsKPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zaWRl YmFuZC5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQuaAo+IGluZGV4IGEw OTA3ZTJjNDk5Mi4uN2ZiOTU3NDVhNDQ0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3NpZGViYW5kLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9z aWRlYmFuZC5oCj4gQEAgLTEyNyw3ICsxMjcsOCBAQCB1MzIgaW50ZWxfc2JpX3JlYWQoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIHUxNiByZWcsCj4gICB2b2lkIGludGVsX3NiaV93cml0 ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwgdTE2IHJlZywgdTMyIHZhbHVlLAo+ICAg CQkgICAgIGVudW0gaW50ZWxfc2JpX2Rlc3RpbmF0aW9uIGRlc3RpbmF0aW9uKTsKPiAgIAo+IC1p bnQgc2FuZHlicmlkZ2VfcGNvZGVfcmVhZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwg dTMyIG1ib3gsIHUzMiAqdmFsKTsKPiAraW50IHNhbmR5YnJpZGdlX3Bjb2RlX3JlYWQoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIHUzMiBtYm94LAo+ICsJCQkgICB1MzIgKnZhbCwgdTMy ICp2YWwxKTsKPiAgIGludCBzYW5keWJyaWRnZV9wY29kZV93cml0ZV90aW1lb3V0KHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICppOTE1LCB1MzIgbWJveCwKPiAgIAkJCQkgICAgdTMyIHZhbCwgaW50 IGZhc3RfdGltZW91dF91cywKPiAgIAkJCQkgICAgaW50IHNsb3dfdGltZW91dF9tcyk7Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==