From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6801960387185999872 X-Received: by 2002:a37:40d2:: with SMTP id n201mr14927945qka.211.1583760370883; Mon, 09 Mar 2020 06:26:10 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:ac8:5057:: with SMTP id h23ls3608693qtm.8.gmail; Mon, 09 Mar 2020 06:26:09 -0700 (PDT) X-Google-Smtp-Source: ADFU+vt166M9UB5V2vAKOz9FIqtdN9uXBbJ0GlzPaBMKdnSzUddC+Ghv5blzIDj52NLr3VWwfiEA X-Received: by 2002:ac8:1e8e:: with SMTP id c14mr13488712qtm.330.1583760369718; Mon, 09 Mar 2020 06:26:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583760369; cv=none; d=google.com; s=arc-20160816; b=ejs0Vx/KkktnHConzEay+lM+DUMjdpmiXcFuDTYUSs/g7f6wI4d7u0zWLj9w3sNDJT 7ivmDj3XmNNTBaCvCtXDdzW/LhBg2gFqOJeY5arIjjyw7XFJRq7RdfF4XC0//3ctqutf +N0EV+nwzI6Ot1c3Ul0/UjWRIFIsAgYc3jS6HogH4Jo88YIemIsRAOObbhmW7SGXUJZX Ydl86/oCRCsI1EYJ9enqT8gHezPzRMneDezd2DXM6m1QRAgP3LaT8uD0jc2P79TeoQTA 1NYHEAPNir56UxH7CSlmlSZHSS+VkkdRBngZKLtwGi9Rjc9CLflMQsziEp+ZbEb6oQXB k51g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to:date :cc:to:from:subject:message-id:dkim-signature; bh=SN/uB0D2Yzk6crG8CckiI8AbJhkaIxgSVOsdNRCejtQ=; b=Rb76mzyuV9gTmdbselTXCW5Vvm7EMCEJLHvaCiuPMj86MtRWSUUz88wM4AA5ntR+ce DqueWOuWbM+qFEhFLf5TE2C11kdQunmdS/o0aTXmKY+QnNZDSyAZ2XTtQ9u7CxYE7BnK jOdJcac/CXjRXVEFB3YixzKnfEz3JVNHWty+YNcQ69Ghr8QER8yFxNoeyfOIT5c5X8rm QgWNaVw8l+O2v/M8zH91MaLPSHcXac0tjaxmActLlN0xeIjCp4SfuVTdlmVOWx3uX0UB VyBhCEabfkhgaV1Jf8VKc5opF8EfC50SQqprhtX9mkwfkK6pUQ5jofsryy4DPbr1EAER LkNA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vZN2XnYD; spf=pass (google.com: domain of shreeya.patel23498@gmail.com designates 2607:f8b0:4864:20::1042 as permitted sender) smtp.mailfrom=shreeya.patel23498@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com. [2607:f8b0:4864:20::1042]) by gmr-mx.google.com with ESMTPS id 198si523174qkh.7.2020.03.09.06.26.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2020 06:26:09 -0700 (PDT) Received-SPF: pass (google.com: domain of shreeya.patel23498@gmail.com designates 2607:f8b0:4864:20::1042 as permitted sender) client-ip=2607:f8b0:4864:20::1042; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vZN2XnYD; spf=pass (google.com: domain of shreeya.patel23498@gmail.com designates 2607:f8b0:4864:20::1042 as permitted sender) smtp.mailfrom=shreeya.patel23498@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-pj1-x1042.google.com with SMTP id y7so992931pjn.1 for ; Mon, 09 Mar 2020 06:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=SN/uB0D2Yzk6crG8CckiI8AbJhkaIxgSVOsdNRCejtQ=; b=vZN2XnYDJ42k+ninu6A+IqHKelBwH0M+hvsD+QV5C1ROyLTi2CL/HhhIyjJdutTh/1 pm1NaWqdB3J+PCc/hmjN7jo8hHGJwXnBk4S+fbh5wZFbZ5jjP2Km+6L0VY7iMrY0L7aA Y7p+WwwdH8DtI3Lb4sE1zsFcv5tQrvN4g/xCdPryr+YFKoAy2AZ2fR72wC2pJp4GuQKj KcLsJGg4vKdABf8bMPdCfQuisRs+6A89s78laLH06lBhpeZBHPaDAyZYwR7gPXSVmw70 p6HMEoGKYu041hKfHOxlPj7MIZzisw82/ECfEnov4ZOLA/1j4hFO+xgcM4dmYDOiHlkl EHlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=SN/uB0D2Yzk6crG8CckiI8AbJhkaIxgSVOsdNRCejtQ=; b=LcO9YGjaowsW3bLzC6le0+5qhl0yYCXaBDQNB2xWQhIQ1ZLPxo4fp3+IXWNC1Md/6N u/QMmgUR0iIncjG17+rY4sLECAQG8oPmWVHUdlbCRHoRvUUu+wxRgKJaTho4ilJb/n3+ fFiZhBH9/DEKzMzo7r3GcooJv5wL+tVeJdwiZ8GIVzx7nGHup4b82gkwWiG0zp3cA5EB +1hrKCpfuBwqXOsyGzL36PAZgGOfv63XLD9Jq5L9LI2/m2+yy6kY8UaI1EOZ+xNsy/0O 9TsmFWEOvi+q1UntuNsjzg95Hs4KRPsW0Cd/TcuIIxe4gpUjW2yLberWS+NhkNV007Dp 5tvA== X-Gm-Message-State: ANhLgQ2I+E83iDIwz5CCLdlHHELDULh3NQxvOMkS30ns7ZBBuh4dIOqG xEdwwpG0A94bvLz309ebBDc= X-Received: by 2002:a17:90b:238c:: with SMTP id mr12mr3164241pjb.161.1583760368597; Mon, 09 Mar 2020 06:26:08 -0700 (PDT) Return-Path: Received: from Shreeya-Patel ([2405:204:2188:9cfe:18bc:a849:c699:3914]) by smtp.googlemail.com with ESMTPSA id v133sm33700710pfc.68.2020.03.09.06.26.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Mar 2020 06:26:07 -0700 (PDT) Message-ID: Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators From: Shreeya Patel To: Julia Lawall Cc: Joe Perches , outreachy-kernel , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, sbrivio@redhat.com, daniel.baluta@gmail.com, nramas@linux.microsoft.com, hverkuil@xs4all.nl, Larry.Finger@lwfinger.net Date: Mon, 09 Mar 2020 18:56:00 +0530 In-Reply-To: References: <20200308220004.9960-1-shreeya.patel23498@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit On Mon, 2020-03-09 at 08:35 +0100, Julia Lawall wrote: > On Mon, 9 Mar 2020, Shreeya Patel wrote: > > > On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote: > > > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > > > > Add space around operators for improving the code > > > > readability. > > > > > > Hello again Shreeya. > > > > > > > I have some questions here... > > > > > The subject isn't really quite appropriate as you > > > are not doing this space around operator addition > > > for the entire subsystem. > > > > > > IMO, the subject should be: > > > > > > [PATCH] staging: rtl8188eu: rtw_mlme: Add spaces around operators > > > > > > because you are only performing this change on this > > > single file. > > > > > > If you were to do this for every single file in the > > > subsystem, you could have many individual patches with > > > the exact same subject line. > > > > > > And it would be good to show in the changelog that you > > > have compiled the file pre and post patch without object > > > code change. > > > > > > > I'm not sure how to show this. Do you mean to add the output of > > "make drivers/staging/rtl8188eu/core" before and after the changes? > > You are working on one specific file, maybe foo.c. Compile before > making changes, which will give you foo.o. Rename that file to > something > else. Make your changes and compile again. Do a diff with the > previously > compiled file. It should produce nothing, indicating no difference. > > If this .o file doesn't change and you only changed this .c file, the > whole compiled driver won't change either. > ok, got it. > > I also don't understand the meaning of no object code change. If we > > are > > making the changes to code and then compiling it using the make > > command > > then a new file with .o extension is created and replaced by the > > previous one isn't it? > > > > > Also, it's good to show that git diff -w shows no source > > > file changes. > > > > > > > And this has to be... > > git diff -w --shortstat drivers/staging/rtl8188eu/core/ > > --shortstat does not seem useful. What you hope to see is that it > produces nothing. > Okay. I will send a V2 with all the changes required. Btw Joe, I am working against staging-testing tree > julia > > > Am I correct? > > > > Thanks > > > > > > Reported by checkpatch.pl > > > > > > > > Signed-off-by: Shreeya Patel > > > > --- > > > > drivers/staging/rtl8188eu/core/rtw_mlme.c | 40 +++++++++++-- > > > > ---- > > > > ------ > > > > 1 file changed, 20 insertions(+), 20 deletions(-) > > > > > > When I try this using checkpatch --fix-inplace, I get > > > 21 changes against the latest -next tree. > > > > > > What tree are you doing this against? > > > > > > > > > > -- > > You received this message because you are subscribed to the Google > > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, > > send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To view this discussion on the web visit > > https://groups.google.com/d/msgid/outreachy-kernel/af1a27fb8c5f7efbaf99ce3055cf3801b366d627.camel%40gmail.com > > . > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFCEC10F27 for ; Mon, 9 Mar 2020 13:26:16 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4AC0C20727 for ; Mon, 9 Mar 2020 13:26:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vZN2XnYD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AC0C20727 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id E1CD288340; Mon, 9 Mar 2020 13:26:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PhGUhvbMBndR; Mon, 9 Mar 2020 13:26:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 3001488326; Mon, 9 Mar 2020 13:26:11 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id DCEEE1BF35F for ; Mon, 9 Mar 2020 13:26:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D98A2888FE for ; Mon, 9 Mar 2020 13:26:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ueUiNaSD45Ur for ; Mon, 9 Mar 2020 13:26:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by hemlock.osuosl.org (Postfix) with ESMTPS id 47B39888FC for ; Mon, 9 Mar 2020 13:26:09 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id ay11so3989878plb.0 for ; Mon, 09 Mar 2020 06:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=SN/uB0D2Yzk6crG8CckiI8AbJhkaIxgSVOsdNRCejtQ=; b=vZN2XnYDJ42k+ninu6A+IqHKelBwH0M+hvsD+QV5C1ROyLTi2CL/HhhIyjJdutTh/1 pm1NaWqdB3J+PCc/hmjN7jo8hHGJwXnBk4S+fbh5wZFbZ5jjP2Km+6L0VY7iMrY0L7aA Y7p+WwwdH8DtI3Lb4sE1zsFcv5tQrvN4g/xCdPryr+YFKoAy2AZ2fR72wC2pJp4GuQKj KcLsJGg4vKdABf8bMPdCfQuisRs+6A89s78laLH06lBhpeZBHPaDAyZYwR7gPXSVmw70 p6HMEoGKYu041hKfHOxlPj7MIZzisw82/ECfEnov4ZOLA/1j4hFO+xgcM4dmYDOiHlkl EHlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=SN/uB0D2Yzk6crG8CckiI8AbJhkaIxgSVOsdNRCejtQ=; b=A+rnx6FMaXCLKmTk84PXyDOgz54PSLb7KuQ6U9LMCsk+IM1YDQOEpBEPCxYJENFQwx axGzVCyPmknnWXjwuD3g3cMKdvF1YYTcmmkgIpDRIftOWPd4cHAAKT8hg/gQ3E/g3+j1 sSNTdNxZu5NdP+mE4k4lb+S0yV7K6gST/W9XkSgUVM5QOIdlR7wBmlx75oKxv8uiQnkJ sm1RGfahIuedxNQzrzT99+OGx7e8nq8BlEUfOjQIAxhbz/GzkKMCP3t/CRnPkamOX4Kj 7mZcatpeF7TVBFrsH1a5pLIrPdqBY0Ka08/B8o8552Ml4RG3OVhRtt8YMng9NWThHi92 ecuw== X-Gm-Message-State: ANhLgQ3aYUmn12aNHJNLbrJAYykMfpIZOTTpXY94+K4yl3CCQskVVJy/ tqJqifbFFYfC81J8/ADZYNI= X-Google-Smtp-Source: ADFU+vuvA9G9Mzw9D+dwlX93AP7zcnrABY3oCgOA0sXAqr3IsZ/b+/wj64/nixCwGiiRrOLixf9kiw== X-Received: by 2002:a17:90b:238c:: with SMTP id mr12mr3164241pjb.161.1583760368597; Mon, 09 Mar 2020 06:26:08 -0700 (PDT) Received: from Shreeya-Patel ([2405:204:2188:9cfe:18bc:a849:c699:3914]) by smtp.googlemail.com with ESMTPSA id v133sm33700710pfc.68.2020.03.09.06.26.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Mar 2020 06:26:07 -0700 (PDT) Message-ID: Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators From: Shreeya Patel To: Julia Lawall Date: Mon, 09 Mar 2020 18:56:00 +0530 In-Reply-To: References: <20200308220004.9960-1-shreeya.patel23498@gmail.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, nramas@linux.microsoft.com, daniel.baluta@gmail.com, sbrivio@redhat.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, hverkuil@xs4all.nl, outreachy-kernel , Joe Perches , Larry.Finger@lwfinger.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, 2020-03-09 at 08:35 +0100, Julia Lawall wrote: > On Mon, 9 Mar 2020, Shreeya Patel wrote: > > > On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote: > > > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > > > > Add space around operators for improving the code > > > > readability. > > > > > > Hello again Shreeya. > > > > > > > I have some questions here... > > > > > The subject isn't really quite appropriate as you > > > are not doing this space around operator addition > > > for the entire subsystem. > > > > > > IMO, the subject should be: > > > > > > [PATCH] staging: rtl8188eu: rtw_mlme: Add spaces around operators > > > > > > because you are only performing this change on this > > > single file. > > > > > > If you were to do this for every single file in the > > > subsystem, you could have many individual patches with > > > the exact same subject line. > > > > > > And it would be good to show in the changelog that you > > > have compiled the file pre and post patch without object > > > code change. > > > > > > > I'm not sure how to show this. Do you mean to add the output of > > "make drivers/staging/rtl8188eu/core" before and after the changes? > > You are working on one specific file, maybe foo.c. Compile before > making changes, which will give you foo.o. Rename that file to > something > else. Make your changes and compile again. Do a diff with the > previously > compiled file. It should produce nothing, indicating no difference. > > If this .o file doesn't change and you only changed this .c file, the > whole compiled driver won't change either. > ok, got it. > > I also don't understand the meaning of no object code change. If we > > are > > making the changes to code and then compiling it using the make > > command > > then a new file with .o extension is created and replaced by the > > previous one isn't it? > > > > > Also, it's good to show that git diff -w shows no source > > > file changes. > > > > > > > And this has to be... > > git diff -w --shortstat drivers/staging/rtl8188eu/core/ > > --shortstat does not seem useful. What you hope to see is that it > produces nothing. > Okay. I will send a V2 with all the changes required. Btw Joe, I am working against staging-testing tree > julia > > > Am I correct? > > > > Thanks > > > > > > Reported by checkpatch.pl > > > > > > > > Signed-off-by: Shreeya Patel > > > > --- > > > > drivers/staging/rtl8188eu/core/rtw_mlme.c | 40 +++++++++++-- > > > > ---- > > > > ------ > > > > 1 file changed, 20 insertions(+), 20 deletions(-) > > > > > > When I try this using checkpatch --fix-inplace, I get > > > 21 changes against the latest -next tree. > > > > > > What tree are you doing this against? > > > > > > > > > > -- > > You received this message because you are subscribed to the Google > > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, > > send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To view this discussion on the web visit > > https://groups.google.com/d/msgid/outreachy-kernel/af1a27fb8c5f7efbaf99ce3055cf3801b366d627.camel%40gmail.com > > . > > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel