From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3FA2C433F5 for ; Fri, 11 Mar 2022 18:05:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 912648390E; Fri, 11 Mar 2022 19:05:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1647021942; bh=sPVYCemJiV4mWGXLXqMbesNYFvVFyUizGQmR/9/Wv5g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=butgBh0e0x/Nf+dnnmUYC3flX1kl3W5zvY8Cvms63Hc7bTNeSAcss6Zpr9mt3Afkz fbjnDRXBBmCv9wt6Z7TmOLgI0iRRMWldJks1mGU4nqXkITYmjjI/D9HJOSUQOYYPG9 QhbzPKWRDRhK9URXm0LhJ35WXO2LfdV6SjqhELM5LE5aWXjK98Qi2VWLhLlJbaCYQU FGlbKciMeBWCZmCuML3DQPWWkn84esxP9TwCmX6bXvB8xsg0J8dovgUsTilPWo0fVl H71QaXN7X6eHER3QoZg38z2f46gD3tdJAw3tC6YlytvYhMiqwCjtjg1kO/wcNIfAnZ CAZJgO0DlnqSQ== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6A96B80288; Fri, 11 Mar 2022 19:05:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1647021941; bh=sPVYCemJiV4mWGXLXqMbesNYFvVFyUizGQmR/9/Wv5g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qEWmFudev5KOU74BQSjvrlwHnPIo/OTLXq6h8FO9FVyXrWLcZO3rbzn2r9cIuwsCW PMdjeYumE0ixZNLUtOSBwlBnt8hhvqH8PJC1ocmv8L6Ta0S7RO9wD/1JIFSQJ/tWQC PGmTozjSPICq4QXwjGyDggxUesq/odN5Xsg4P3boCP9Zy3emI+hMda69sBAS+GORHC 6Ncn6K2Ti6YPqtl4zMcNhDu/F592WWZuMYAIKnQ1WICJJRZzl1FwBYnB0OA/nx+K5M tQm9cs05851KZtgY3RJlmDJwk0s1ZwobLKeCeudVJSnEmaMK/mtx35FZ1NXGpMNlBF slid6XVTMOH0Q== Message-ID: Date: Fri, 11 Mar 2022 19:05:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 2/2] clk: imx8mq: Add a clock driver for the imx8mq Content-Language: en-US To: Angus Ainslie , Angus Ainslie , u-boot@lists.denx.de Cc: lukma@denx.de, seanga2@gmail.com, sbabic@denx.de, festevam@gmail.com, kernel@puri.sm, uboot-imx@nxp.com References: <20220311163536.1330032-1-angus@akkea.ca> <20220311163536.1330032-3-angus@akkea.ca> <14af7ab4-59a7-1af6-2f53-446eefcb87b5@denx.de> <86e82fc6-4a10-3d7c-19bf-e171815ef0e6@puri.sm> From: Marek Vasut In-Reply-To: <86e82fc6-4a10-3d7c-19bf-e171815ef0e6@puri.sm> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/11/22 18:02, Angus Ainslie wrote: > On 2022-03-11 08:57, Marek Vasut wrote: >> On 3/11/22 17:35, Angus Ainslie wrote: >>> This is a DM clock drvier based off the imx8mm u-boot driver and the >>> linux >>> kernel driver. >> >> s@drvier@driver@ >> > Thanks Sure >>> All of the PLLs and clocks are initialized so the subsystems below are >>> functional and tested. >>> >>> 1) USB host and peripheral >>> 2) ECSPI >>> 3) UART >>> 4) I2C all busses >>> 5) USDHC for eMMC support >>> 6) USB storage >>> 7) GPIO >>> 8) DRAM >>> >>> The PLL rate tables are from the kernel >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=43cdaa1567ad3931fbde438853947d45238cc040 >>> >> >> That patch is three years old. >> That patch is for MX8M Mini clock, not for MX8M(Q). >> >> You can use the abbreviated commit ID instead: >> 43cdaa1567ad3 ("clk: imx8mm: Move 1443X/1416X PLL clock structure to >> common place") >> But that seems to be the wrong commit. > > That's the commit where the imx8m PLL frequency table is moved to a > common file for use by all of the imx8m variants. The imx8mq linux > driver does not even use the frequency tables so there is not a specific > commit for it. Isn't large part of this driver coming from these tables ? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/clk/imx/clk-imx8mq.c