From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932801AbdLTIRO (ORCPT ); Wed, 20 Dec 2017 03:17:14 -0500 Received: from mx2.suse.de ([195.135.220.15]:59154 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932747AbdLTIRJ (ORCPT ); Wed, 20 Dec 2017 03:17:09 -0500 Subject: Re: [Xen-devel] [RFC PATCH 01/60] hyper_dmabuf: initial working version of hyper_dmabuf drv To: Dongwon Kim , "linux-kernel@vger.kernel.org" Cc: "xen-devel@lists.xenproject.org" , "Potrola, MateuszX" , "dri-devel@lists.freedesktop.org" References: <1513711816-2618-1-git-send-email-dongwon.kim@intel.com> <20171219232731.GA6497@downor-Z87X-UD5H> From: Juergen Gross Message-ID: Date: Wed, 20 Dec 2017 09:17:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171219232731.GA6497@downor-Z87X-UD5H> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/12/17 00:27, Dongwon Kim wrote: > I forgot to include this brief information about this patch series. > > This patch series contains the implementation of a new device driver, > hyper_dmabuf, which provides a method for DMA-BUF sharing across > different OSes running on the same virtual OS platform powered by > a hypervisor. Some general remarks regarding this series: You are starting the whole driver in drivers/xen/ and in the last patch you move it over to drivers/dma-buf/. Why don't you use drivers/dma-buf/ from the beginning? The same applies to e.g. patch 22 changing the license. Please make it easier for the reviewers by not letting us review the development history of your work. Please run ./scripts/checkpatch.pl on each patch and correct the issues it is reporting. At the first glance I've seen several style problems which I won't comment until the next round. Please add the maintainers as Cc:, not only the related mailing lists. As you seem to aim supporting other hypervisors than Xen you might want to add virtualization@lists.linux-foundation.org as well. Juergen