From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30AC6C761AF for ; Mon, 3 Apr 2023 22:38:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233475AbjDCWiV (ORCPT ); Mon, 3 Apr 2023 18:38:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233325AbjDCWiU (ORCPT ); Mon, 3 Apr 2023 18:38:20 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDC531FF9 for ; Mon, 3 Apr 2023 15:38:18 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id h25so40007463lfv.6 for ; Mon, 03 Apr 2023 15:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680561497; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FtsOWrQW7hkNYFADGqbjwZ60d4zvSefDrCxExKDl8Ps=; b=hwuZ8XieWgBLN5adU41i6xX2s4eNlMpyUG883h6xHBqIp68TLP0PISWCmEmBxbOFNp La0z50tJWUVSnxmQGKjzd2D0TI3d8OdvzjbH9uwZNYgcJWNoG92y7hvf5wRLkIcNnJkT 9xaak/ZDCbwD9kqTd2ISNgfEwhja79Z07uNJPnxcGhHgeZ9/vQGpDOoJeWvRtPZ/2Gxc TvPZiYYuhXrmLzm7gBiYz6zwetuFr+2zYf3U5JHJIDUNZM1JFosfH9/7+5HX0jn7xUye RlhlegeuGZo1+3qU3CEAaNzaV47X5Q9mtT55migZtfvsp6ZvbmSskgy9parZdncdzPQx BKWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680561497; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FtsOWrQW7hkNYFADGqbjwZ60d4zvSefDrCxExKDl8Ps=; b=rovimURk4YKYqut5QOmRXQXjlwuIHNRzVr47DXIgaWesU+SWZ/K8JuRUFlWjQl5LjT GT82Lp7jSxWwoeO2pfFwl1BoQyB1171sZO0fHvfCwUG69eRogxdXC43rQPV86PPUnNVf 2d7xa8XTfzBSM7v6jvi3DfzLDYfvsE+qk192LpHnPIryEuqhUU8dUnpUm5kA9hQXhdYP RvlM2K0MuirSfRmGCQv/EXE3X5DlW3cFQeW8wy59sNlwa23DmpQUHr8OdmrnVjCEGQ9L RDf/t+jFm9zZIAFx8csJNb5fzvCcFneOqNN8uTGv0C6x1AAVQxDWl0HwbJ5GxEyMPIlb hODQ== X-Gm-Message-State: AAQBX9f0kBWmczVy1CAwTgN3PuuSVICRKEDpXA3R7qxl9i4Gt1/HgQRT OyptwjJn1qVhojQ2UNoX3bW37g== X-Google-Smtp-Source: AKy350YZO6iPPjj1sua6F66RRClLCkmeKk/nQmT2y4PKC2eroOuYFkNzuee/Tto92qVvDnzdKwZi/Q== X-Received: by 2002:a05:6512:2192:b0:4e8:3da6:485a with SMTP id b18-20020a056512219200b004e83da6485amr56645lft.68.1680561496989; Mon, 03 Apr 2023 15:38:16 -0700 (PDT) Received: from [192.168.1.101] (abxj135.neoplus.adsl.tpnet.pl. [83.9.3.135]) by smtp.gmail.com with ESMTPSA id u5-20020ac248a5000000b004e9cad1cd7csm1985379lfg.229.2023.04.03.15.38.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 15:38:16 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 00:38:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 4/7] dt-bindings: iommu: arm,smmu: enable clocks for sa8775p Content-Language: en-US To: Rob Herring , Bartosz Golaszewski Cc: Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Bartosz Golaszewski , Will Deacon , Robin Murphy , Joerg Roedel References: <20230328193632.226095-1-brgl@bgdev.pl> <20230328193632.226095-5-brgl@bgdev.pl> <20230403204127.GA1708388-robh@kernel.org> From: Konrad Dybcio In-Reply-To: <20230403204127.GA1708388-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3.04.2023 22:41, Rob Herring wrote: > On Tue, Mar 28, 2023 at 09:36:29PM +0200, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski >> >> The KGSL iommu will require the clocks property to be set. Enable it for > > Isn't KGSL the name for QCom's adreno vendor driver? What does that have > to do with bindings? It's called "KGSL SMMU" (as opposed to the other "APPS SMMU" (Application Processor SubSystem) in some places in Qualcommland Konrad > >> sa8775p in the bindings. >> >> Cc: Will Deacon >> Cc: Robin Murphy >> Cc: Joerg Roedel >> Signed-off-by: Bartosz Golaszewski >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 807cb511fe18..74d5164ed1e8 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -375,7 +375,6 @@ allOf: >> - nvidia,smmu-500 >> - qcom,qcm2290-smmu-500 >> - qcom,qdu1000-smmu-500 >> - - qcom,sa8775p-smmu-500 >> - qcom,sc7180-smmu-500 >> - qcom,sc8180x-smmu-500 >> - qcom,sc8280xp-smmu-500 >> -- >> 2.37.2 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6696C76188 for ; Mon, 3 Apr 2023 22:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YtqznVyHaGME4cktIrmrp9FjxTRtLUU0VtuCDTl0kBE=; b=MBqgso7DRDfjAW Xz3lmGsy8X80RAUURiGjHWO+FOJSaPjwHDj2WnDJwaQPq/zlFnqEmUqdCRzFNODMp38k4W9PmboH6 WaEQCMFUY/kJhYXPqYsT1p9bgyLor2Ed/9CHe2uPua9JBZBl1MbQLVIwyuH/cOVN8hYixJCfQCrIc /3Uk0XrLh/En6mJAKCSZW+iLOkPUzHOcH87qP3Au2ucNF9eJZSm4gqdfcEZfyFfAdzTw2f5wiJIJ2 cdPwnbvD3OTdgDE+kS3LHeszGe1ry8hWiuIp0MOzTBHZEh6DNOEBYl7eSqHZM85V3UHyPkEPnAYdJ 2+a8ge5URTU1rzBBZ7sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjSoh-00H639-1e; Mon, 03 Apr 2023 22:38:23 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjSof-00H628-1U for linux-arm-kernel@lists.infradead.org; Mon, 03 Apr 2023 22:38:22 +0000 Received: by mail-lf1-x12a.google.com with SMTP id y15so39994362lfa.7 for ; Mon, 03 Apr 2023 15:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680561497; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FtsOWrQW7hkNYFADGqbjwZ60d4zvSefDrCxExKDl8Ps=; b=hwuZ8XieWgBLN5adU41i6xX2s4eNlMpyUG883h6xHBqIp68TLP0PISWCmEmBxbOFNp La0z50tJWUVSnxmQGKjzd2D0TI3d8OdvzjbH9uwZNYgcJWNoG92y7hvf5wRLkIcNnJkT 9xaak/ZDCbwD9kqTd2ISNgfEwhja79Z07uNJPnxcGhHgeZ9/vQGpDOoJeWvRtPZ/2Gxc TvPZiYYuhXrmLzm7gBiYz6zwetuFr+2zYf3U5JHJIDUNZM1JFosfH9/7+5HX0jn7xUye RlhlegeuGZo1+3qU3CEAaNzaV47X5Q9mtT55migZtfvsp6ZvbmSskgy9parZdncdzPQx BKWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680561497; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FtsOWrQW7hkNYFADGqbjwZ60d4zvSefDrCxExKDl8Ps=; b=miAQbKdGryXNEXZh9TcBD+mAX1MROJsQjoPuAP9ujbmh/CKeg9hJmBmzhmLZw4vNoe XPM92UqMtawwdfh9JZol3oGCJ307wk69kKBkBF7CuBDjB33m8syHMCJKmHlGzNX0ddWV LOi8clYS9mewwnyg12bC0VIjP8ZgyzHFya66QGHeD+f2rkmj1XYbhVlz/pvj4OByXt8w tl6HR1DgI/TQAbZkbYtRJv3MF/4PElHbqSkJy19bNyC7qEm5sD7kMYDt08WYrL0zP2l4 /l28Q5yHx4ZQcaTeSVjL6/nZVfULq3ZWrY31bJhL2XWH48mITRQc7g3Qk25dF5zuxoVB tqWQ== X-Gm-Message-State: AAQBX9eneZ4qafkbDTfttEfKuN7kPA6EM4IW8fBXt91ZsIZpwb7jOCDe kVtNr+8aWnBPIWjlzW3v0CmoTQ== X-Google-Smtp-Source: AKy350YZO6iPPjj1sua6F66RRClLCkmeKk/nQmT2y4PKC2eroOuYFkNzuee/Tto92qVvDnzdKwZi/Q== X-Received: by 2002:a05:6512:2192:b0:4e8:3da6:485a with SMTP id b18-20020a056512219200b004e83da6485amr56645lft.68.1680561496989; Mon, 03 Apr 2023 15:38:16 -0700 (PDT) Received: from [192.168.1.101] (abxj135.neoplus.adsl.tpnet.pl. [83.9.3.135]) by smtp.gmail.com with ESMTPSA id u5-20020ac248a5000000b004e9cad1cd7csm1985379lfg.229.2023.04.03.15.38.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 15:38:16 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 00:38:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 4/7] dt-bindings: iommu: arm,smmu: enable clocks for sa8775p Content-Language: en-US To: Rob Herring , Bartosz Golaszewski Cc: Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Bartosz Golaszewski , Will Deacon , Robin Murphy , Joerg Roedel References: <20230328193632.226095-1-brgl@bgdev.pl> <20230328193632.226095-5-brgl@bgdev.pl> <20230403204127.GA1708388-robh@kernel.org> From: Konrad Dybcio In-Reply-To: <20230403204127.GA1708388-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230403_153821_548146_8D1B0FC1 X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3.04.2023 22:41, Rob Herring wrote: > On Tue, Mar 28, 2023 at 09:36:29PM +0200, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski >> >> The KGSL iommu will require the clocks property to be set. Enable it for > > Isn't KGSL the name for QCom's adreno vendor driver? What does that have > to do with bindings? It's called "KGSL SMMU" (as opposed to the other "APPS SMMU" (Application Processor SubSystem) in some places in Qualcommland Konrad > >> sa8775p in the bindings. >> >> Cc: Will Deacon >> Cc: Robin Murphy >> Cc: Joerg Roedel >> Signed-off-by: Bartosz Golaszewski >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 807cb511fe18..74d5164ed1e8 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -375,7 +375,6 @@ allOf: >> - nvidia,smmu-500 >> - qcom,qcm2290-smmu-500 >> - qcom,qdu1000-smmu-500 >> - - qcom,sa8775p-smmu-500 >> - qcom,sc7180-smmu-500 >> - qcom,sc8180x-smmu-500 >> - qcom,sc8280xp-smmu-500 >> -- >> 2.37.2 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel