From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1434581AbdDZCAb (ORCPT ); Tue, 25 Apr 2017 22:00:31 -0400 Received: from mail.netline.ch ([148.251.143.178]:44157 "EHLO netline-mail3.netline.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S948185AbdDZCAV (ORCPT ); Tue, 25 Apr 2017 22:00:21 -0400 Subject: Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, Gerd Hoffmann , amd-gfx@lists.freedesktop.org, open list References: <20170424062532.26722-1-kraxel@redhat.com> <20170424062532.26722-4-kraxel@redhat.com> <3b872a56-80b5-0c44-712f-a9517489eb24@daenzer.net> <20170425095259.GK30290@intel.com> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Message-ID: Date: Wed, 26 Apr 2017 11:00:09 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170425095259.GK30290@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/04/17 06:52 PM, Ville Syrjälä wrote: > On Tue, Apr 25, 2017 at 12:18:52PM +0900, Michel Dänzer wrote: >> On 24/04/17 03:25 PM, Gerd Hoffmann wrote: >>> +#ifdef __BIG_ENDIAN >>> + switch (bpp) { >>> + case 8: >>> + fmt = DRM_FORMAT_C8; >>> + break; >>> + case 24: >>> + fmt = DRM_FORMAT_BGR888; >>> + break; >> >> BTW, endianness as a concept cannot apply to 8 or 24 bpp formats. > > To 8bpp no, but it can easily apply to 24bpp. Any byte swapping rips apart the bytes of a 24bpp pixel, so those formats only make sense as straight array formats. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format Date: Wed, 26 Apr 2017 11:00:09 +0900 Message-ID: References: <20170424062532.26722-1-kraxel@redhat.com> <20170424062532.26722-4-kraxel@redhat.com> <3b872a56-80b5-0c44-712f-a9517489eb24@daenzer.net> <20170425095259.GK30290@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170425095259.GK30290-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Daniel Vetter , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Gerd Hoffmann , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, open list List-Id: dri-devel@lists.freedesktop.org T24gMjUvMDQvMTcgMDY6NTIgUE0sIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiBPbiBUdWUsIEFw ciAyNSwgMjAxNyBhdCAxMjoxODo1MlBNICswOTAwLCBNaWNoZWwgRMOkbnplciB3cm90ZToKPj4g T24gMjQvMDQvMTcgMDM6MjUgUE0sIEdlcmQgSG9mZm1hbm4gd3JvdGU6Cj4+PiArI2lmZGVmIF9f QklHX0VORElBTgo+Pj4gKwlzd2l0Y2ggKGJwcCkgewo+Pj4gKwljYXNlIDg6Cj4+PiArCQlmbXQg PSBEUk1fRk9STUFUX0M4Owo+Pj4gKwkJYnJlYWs7Cj4+PiArCWNhc2UgMjQ6Cj4+PiArCQlmbXQg PSBEUk1fRk9STUFUX0JHUjg4ODsKPj4+ICsJCWJyZWFrOwo+Pgo+PiBCVFcsIGVuZGlhbm5lc3Mg YXMgYSBjb25jZXB0IGNhbm5vdCBhcHBseSB0byA4IG9yIDI0IGJwcCBmb3JtYXRzLgo+IAo+IFRv IDhicHAgbm8sIGJ1dCBpdCBjYW4gZWFzaWx5IGFwcGx5IHRvIDI0YnBwLgoKQW55IGJ5dGUgc3dh cHBpbmcgcmlwcyBhcGFydCB0aGUgYnl0ZXMgb2YgYSAyNGJwcCBwaXhlbCwgc28gdGhvc2UKZm9y bWF0cyBvbmx5IG1ha2Ugc2Vuc2UgYXMgc3RyYWlnaHQgYXJyYXkgZm9ybWF0cy4KCgotLSAKRWFy dGhsaW5nIE1pY2hlbCBEw6RuemVyICAgICAgICAgICAgICAgfCAgICAgICAgICAgICAgIGh0dHA6 Ly93d3cuYW1kLmNvbQpMaWJyZSBzb2Z0d2FyZSBlbnRodXNpYXN0ICAgICAgICAgICAgIHwgICAg ICAgICAgICAgTWVzYSBhbmQgWCBkZXZlbG9wZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9hbWQtZ2Z4Cg==