From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: u-boot@lists.denx.de
Subject: caching BLOBLISTT_SPL_HANDOFF
Date: Mon, 2 Mar 2020 20:01:29 +0000 [thread overview]
Message-ID: <b31362c2-260f-da9a-4c0f-3e819ad43def@prevas.dk> (raw)
In-Reply-To: <CAPnjgZ0RFPNNy64POKirvaxAQZGJg27mtBKD60QEtXYB826irw@mail.gmail.com>
On 02/03/2020 20.47, Simon Glass wrote:
> Hi Rasmus,
>
> On Fri, 28 Feb 2020 at 16:09, Rasmus Villemoes
> <rasmus.villemoes@prevas.dk> wrote:
>>
>> Now that particular one seems a bit fishy: Why is it ok to cache the
>> location of the BLOBLISTT_SPL_HANDOFF blob in gd->spl_handoff? Later in
>> the init sequence there's a call to reserve_bloblist, and later again
>> reloc_bloblist. Doesn't that leave gd->spl_handoff stale?
>
> Yes it does. It is only supposed to be used in the early stages of
> U-Boot (proper) init.
Yes, that's what I thought - and if it's only actually used once or
twice during the early stages, there's not much point in caching it.
> Actually I think that member could be dropped and we could search for
> it each time:
>
> ./arch/x86/cpu/broadwell/cpu_from_spl.c
Yes, there didn't seem to be many users, so it should not be that hard
to get rid of. I also think that sets a better precedent for future
bloblist users.
Rasmus
next prev parent reply other threads:[~2020-03-02 20:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 8:18 [PATCH] common/board_f.c: use #ifdefs a little more consistently Rasmus Villemoes
2020-02-27 23:40 ` Simon Glass
2020-02-28 8:42 ` Rasmus Villemoes
2020-02-28 15:46 ` Tom Rini
2020-02-28 17:24 ` Rasmus Villemoes
2020-02-28 17:35 ` Tom Rini
2020-02-28 23:09 ` caching BLOBLISTT_SPL_HANDOFF (was Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently) Rasmus Villemoes
2020-03-02 19:47 ` Simon Glass
2020-03-02 20:01 ` Rasmus Villemoes [this message]
2020-03-04 23:11 ` caching BLOBLISTT_SPL_HANDOFF Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b31362c2-260f-da9a-4c0f-3e819ad43def@prevas.dk \
--to=rasmus.villemoes@prevas.dk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.