From: Sanjay R Mehta <sanmehta@amd.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"Hook, Gary" <Gary.Hook@amd.com>
Cc: "S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>,
"Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@amd.com>,
"Kumar, Rajesh" <Rajesh1.Kumar@amd.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"robh@kernel.org" <robh@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: Re: [PATCH 4/4] dmaengine: Add debugfs entries for PTDMA information
Date: Thu, 26 Sep 2019 06:43:51 +0000 [thread overview]
Message-ID: <b334d159-531f-4e0a-c5bb-11de7968dcd7@amd.com> (raw)
In-Reply-To: <20190924080503.GA564935@kroah.com>
On 9/24/2019 1:35 PM, gregkh@linuxfoundation.org wrote:
> [CAUTION: External Email]
>
> On Tue, Sep 24, 2019 at 07:33:02AM +0000, Mehta, Sanju wrote:
>> +static const struct file_operations pt_debugfs_info_ops = {
>> + .owner = THIS_MODULE,
>> + .open = simple_open,
>> + .read = ptdma_debugfs_info_read,
>> + .write = NULL,
>> +};
>> +
>> +static const struct file_operations pt_debugfs_queue_ops = {
>> + .owner = THIS_MODULE,
>> + .open = simple_open,
>> + .read = ptdma_debugfs_queue_read,
>> + .write = ptdma_debugfs_queue_write,
>> +};
>> +
>> +static const struct file_operations pt_debugfs_stats_ops = {
>> + .owner = THIS_MODULE,
>> + .open = simple_open,
>> + .read = ptdma_debugfs_stats_read,
>> + .write = ptdma_debugfs_stats_write,
>> +};
> Can you use DEFINE_SIMPLE_ATTRIBUTE() here intead of these?
Okay Greg, noted. This will be resolved in next set of patches.
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2019-09-26 6:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 7:33 [PATCH 4/4] dmaengine: Add debugfs entries for PTDMA information Mehta, Sanju
2019-09-24 8:05 ` gregkh
2019-09-26 6:33 ` Sanjay R Mehta
2019-09-26 6:43 ` Sanjay R Mehta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b334d159-531f-4e0a-c5bb-11de7968dcd7@amd.com \
--to=sanmehta@amd.com \
--cc=Gary.Hook@amd.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Rajesh1.Kumar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.