All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Dyasli <sergey.dyasli@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Chao Gao <chao.gao@intel.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel@lists.xen.org, Wei Liu <wei.liu2@citrix.com>,
	"sergey.dyasli@citrix.com >> Sergey Dyasli"
	<sergey.dyasli@citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v1] x86/microcode: always collect_cpu_info() during boot
Date: Mon, 1 Apr 2019 11:19:19 +0100	[thread overview]
Message-ID: <b33556d4-5911-d0c6-9663-3e8f4eed79f8@citrix.com> (raw)
In-Reply-To: <5C990B220200007800221BB9@prv1-mh.provo.novell.com>

On 25/03/2019 17:08, Jan Beulich wrote:
>>>> On 25.03.19 at 12:12, <sergey.dyasli@citrix.com> wrote:
>> Currently cpu_sig struct is not updated during boot when either:
>>
>>     1. ucode_scan is set to false (e.g. no "ucode=scan" in cmdline)
>>     2. initrd does not contain a microcode blob
> 
> What about "ucode=<number>"?

Yes, it's equally affected, I'll update the commit message.

>> These will result in cpu_sig.rev being 0 which affects APIC's
>> check_deadline_errata() and retpoline_safe() functions.
>>
>> Fix this by getting ucode revision early during boot and SMP bring up.
> 
> Can't you then drop the call from microcode_update_cpu()?

I tried this and found that properly handling errors requires
a call to __microcode_fini_cpu(). But instead of doing all this
refactoring now, I'd prefer this patch to go on top of Chao's
series, which greatly simplifies things in "remove struct
ucode_cpu_info". Otherwise, most of my work here would be removed
by the next version of Chao's series.

Chao,
To help me with this decision, when can we expect a v7 of your
series?

Thanks,
Sergey

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-04-01 10:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 11:12 [PATCH v1] x86/microcode: always collect_cpu_info() during boot Sergey Dyasli
2019-03-25 11:40 ` Chao Gao
2019-03-25 17:08 ` Jan Beulich
2019-04-01 10:19   ` Sergey Dyasli [this message]
2019-04-01 13:49     ` Chao Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b33556d4-5911-d0c6-9663-3e8f4eed79f8@citrix.com \
    --to=sergey.dyasli@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=chao.gao@intel.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.