All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkh@osg.samsung.com>
To: "Daniel Díaz" <daniel.diaz@linaro.org>, linux-kselftest@vger.kernel.org
Cc: Shuah Khan <shuah@kernel.org>, Darren Hart <dvhart@infradead.org>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Pintu Agarwal <pintu.ping@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftests/android: Fix line continuation in Makefile
Date: Tue, 13 Feb 2018 14:25:55 -0700	[thread overview]
Message-ID: <b343b99b-0c55-1032-cc6e-dacd367f7e8f@osg.samsung.com> (raw)
In-Reply-To: <1517961219-17700-1-git-send-email-daniel.diaz@linaro.org>

On 02/06/2018 04:52 PM, Daniel Díaz wrote:
> The Makefile lacks a couple of line continuation backslashes
> in an `if' clause, which can make the subsequent rsync
> command go awry over the whole filesystem (`rsync -a / /`).
> 
>   /bin/sh: -c: line 5: syntax error: unexpected end of file
>   make[1]: [all] Error 1 (ignored)
>   TEST=$DIR"_test.sh"; \
>                   if [ -e $DIR/$TEST ]; then
>   /bin/sh: -c: line 2: syntax error: unexpected end of file
>   make[1]: [all] Error 1 (ignored)
>   rsync -a $DIR/$TEST $BUILD_TARGET/;
>   [...a myriad of:]
>   [  rsync: readlink_stat("...") failed: Permission denied (13)]
>   [  skipping non-regular file "..."]
>   [  rsync: opendir "..." failed: Permission denied (13)]
>   [and many other errors...]
>   fi
>   make[1]: fi: Command not found
>   make[1]: [all] Error 127 (ignored)
>   done
>   make[1]: done: Command not found
>   make[1]: [all] Error 127 (ignored)
> 
> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
> ---
>  tools/testing/selftests/android/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/android/Makefile b/tools/testing/selftests/android/Makefile
> index 1a74922..f6304d2 100644
> --- a/tools/testing/selftests/android/Makefile
> +++ b/tools/testing/selftests/android/Makefile
> @@ -11,11 +11,11 @@ all:
>  		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
>  		mkdir $$BUILD_TARGET  -p;	\
>  		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> -		#SUBDIR test prog name should be in the form: SUBDIR_test.sh
> +		#SUBDIR test prog name should be in the form: SUBDIR_test.sh \
>  		TEST=$$DIR"_test.sh"; \
> -		if [ -e $$DIR/$$TEST ]; then
> -			rsync -a $$DIR/$$TEST $$BUILD_TARGET/;
> -		fi
> +		if [ -e $$DIR/$$TEST ]; then \
> +			rsync -a $$DIR/$$TEST $$BUILD_TARGET/; \
> +		fi \
>  	done
>  
>  override define RUN_TESTS
> 

Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3

thanks,
-- Shuah

WARNING: multiple messages have this Message-ID (diff)
From: shuahkh at osg.samsung.com (Shuah Khan)
Subject: [PATCH] selftests/android: Fix line continuation in Makefile
Date: Tue, 13 Feb 2018 14:25:55 -0700	[thread overview]
Message-ID: <b343b99b-0c55-1032-cc6e-dacd367f7e8f@osg.samsung.com> (raw)
In-Reply-To: <1517961219-17700-1-git-send-email-daniel.diaz@linaro.org>

On 02/06/2018 04:52 PM, Daniel Díaz wrote:
> The Makefile lacks a couple of line continuation backslashes
> in an `if' clause, which can make the subsequent rsync
> command go awry over the whole filesystem (`rsync -a / /`).
> 
>   /bin/sh: -c: line 5: syntax error: unexpected end of file
>   make[1]: [all] Error 1 (ignored)
>   TEST=$DIR"_test.sh"; \
>                   if [ -e $DIR/$TEST ]; then
>   /bin/sh: -c: line 2: syntax error: unexpected end of file
>   make[1]: [all] Error 1 (ignored)
>   rsync -a $DIR/$TEST $BUILD_TARGET/;
>   [...a myriad of:]
>   [  rsync: readlink_stat("...") failed: Permission denied (13)]
>   [  skipping non-regular file "..."]
>   [  rsync: opendir "..." failed: Permission denied (13)]
>   [and many other errors...]
>   fi
>   make[1]: fi: Command not found
>   make[1]: [all] Error 127 (ignored)
>   done
>   make[1]: done: Command not found
>   make[1]: [all] Error 127 (ignored)
> 
> Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
> ---
>  tools/testing/selftests/android/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/android/Makefile b/tools/testing/selftests/android/Makefile
> index 1a74922..f6304d2 100644
> --- a/tools/testing/selftests/android/Makefile
> +++ b/tools/testing/selftests/android/Makefile
> @@ -11,11 +11,11 @@ all:
>  		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
>  		mkdir $$BUILD_TARGET  -p;	\
>  		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> -		#SUBDIR test prog name should be in the form: SUBDIR_test.sh
> +		#SUBDIR test prog name should be in the form: SUBDIR_test.sh \
>  		TEST=$$DIR"_test.sh"; \
> -		if [ -e $$DIR/$$TEST ]; then
> -			rsync -a $$DIR/$$TEST $$BUILD_TARGET/;
> -		fi
> +		if [ -e $$DIR/$$TEST ]; then \
> +			rsync -a $$DIR/$$TEST $$BUILD_TARGET/; \
> +		fi \
>  	done
>  
>  override define RUN_TESTS
> 

Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: shuahkh@osg.samsung.com (Shuah Khan)
Subject: [PATCH] selftests/android: Fix line continuation in Makefile
Date: Tue, 13 Feb 2018 14:25:55 -0700	[thread overview]
Message-ID: <b343b99b-0c55-1032-cc6e-dacd367f7e8f@osg.samsung.com> (raw)
Message-ID: <20180213212555.f9EQD6_802XzrY9wPYHub1QlX3N7rbUiZiW8z1WLBH4@z> (raw)
In-Reply-To: <1517961219-17700-1-git-send-email-daniel.diaz@linaro.org>

On 02/06/2018 04:52 PM, Daniel Díaz wrote:
> The Makefile lacks a couple of line continuation backslashes
> in an `if' clause, which can make the subsequent rsync
> command go awry over the whole filesystem (`rsync -a / /`).
> 
>   /bin/sh: -c: line 5: syntax error: unexpected end of file
>   make[1]: [all] Error 1 (ignored)
>   TEST=$DIR"_test.sh"; \
>                   if [ -e $DIR/$TEST ]; then
>   /bin/sh: -c: line 2: syntax error: unexpected end of file
>   make[1]: [all] Error 1 (ignored)
>   rsync -a $DIR/$TEST $BUILD_TARGET/;
>   [...a myriad of:]
>   [  rsync: readlink_stat("...") failed: Permission denied (13)]
>   [  skipping non-regular file "..."]
>   [  rsync: opendir "..." failed: Permission denied (13)]
>   [and many other errors...]
>   fi
>   make[1]: fi: Command not found
>   make[1]: [all] Error 127 (ignored)
>   done
>   make[1]: done: Command not found
>   make[1]: [all] Error 127 (ignored)
> 
> Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
> ---
>  tools/testing/selftests/android/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/android/Makefile b/tools/testing/selftests/android/Makefile
> index 1a74922..f6304d2 100644
> --- a/tools/testing/selftests/android/Makefile
> +++ b/tools/testing/selftests/android/Makefile
> @@ -11,11 +11,11 @@ all:
>  		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
>  		mkdir $$BUILD_TARGET  -p;	\
>  		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> -		#SUBDIR test prog name should be in the form: SUBDIR_test.sh
> +		#SUBDIR test prog name should be in the form: SUBDIR_test.sh \
>  		TEST=$$DIR"_test.sh"; \
> -		if [ -e $$DIR/$$TEST ]; then
> -			rsync -a $$DIR/$$TEST $$BUILD_TARGET/;
> -		fi
> +		if [ -e $$DIR/$$TEST ]; then \
> +			rsync -a $$DIR/$$TEST $$BUILD_TARGET/; \
> +		fi \
>  	done
>  
>  override define RUN_TESTS
> 

Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-02-13 21:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 23:52 [PATCH] selftests/android: Fix line continuation in Makefile Daniel Díaz
2018-02-06 23:52 ` [Linux-kselftest-mirror] " Daniel Díaz
2018-02-06 23:52 ` 
2018-02-07  6:01 ` Pintu Kumar
2018-02-07  6:01   ` [Linux-kselftest-mirror] " Pintu Kumar
2018-02-07  6:01   ` pintu.ping
2018-02-07 17:16   ` Daniel Díaz Rodríguez
2018-02-07 17:16     ` [Linux-kselftest-mirror] " Daniel Díaz Rodríguez
2018-02-07 17:16     ` 
2018-02-08  5:15     ` Pintu Kumar
2018-02-08  5:15       ` [Linux-kselftest-mirror] " Pintu Kumar
2018-02-08  5:15       ` pintu.ping
2018-02-08  5:17 ` Pintu Kumar
2018-02-08  5:17   ` [Linux-kselftest-mirror] " Pintu Kumar
2018-02-08  5:17   ` pintu.ping
2018-02-13 21:25 ` Shuah Khan [this message]
2018-02-13 21:25   ` Shuah Khan
2018-02-13 21:25   ` shuahkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b343b99b-0c55-1032-cc6e-dacd367f7e8f@osg.samsung.com \
    --to=shuahkh@osg.samsung.com \
    --cc=daniel.diaz@linaro.org \
    --cc=dvhart@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pintu.ping@gmail.com \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.