From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] io_uring: optimise sqe-to-req flags translation
Date: Sat, 18 Jan 2020 13:45:12 -0700 [thread overview]
Message-ID: <b358b578-f0bd-8886-a75b-b9caefea2496@kernel.dk> (raw)
In-Reply-To: <ad7c75c3-b660-9814-e3fe-ef5a3acd7e8f@gmail.com>
On 1/18/20 10:10 AM, Pavel Begunkov wrote:
> On 18/01/2020 19:34, Jens Axboe wrote:
>>> +enum {
>>> + /* correspond one-to-one to IOSQE_IO_* flags*/
>>> + REQ_F_FIXED_FILE = BIT(REQ_F_FIXED_FILE_BIT), /* ctx owns file */
>>
>> I'd put the comment on top of the line instead, these lines are way too
>> long.
>
> I find it less readable, but let's see
Well, the monster lines are unreadable on an 80-char display... I'm generally
not a stickler with 80 chars, if a few over needs we don't need to break,
I'm all for it. But the long comments are unreadable for me.
--
Jens Axboe
next prev parent reply other threads:[~2020-01-18 20:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 22:22 [PATCH 1/2] io_uring: remove REQ_F_IO_DRAINED Pavel Begunkov
2020-01-17 22:22 ` [PATCH 2/2] io_uring: optimise sqe-to-req flags translation Pavel Begunkov
2020-01-17 22:41 ` [PATCH 0/2] optimise sqe-to-req flags Pavel Begunkov
2020-01-17 22:49 ` Jens Axboe
2020-01-17 23:14 ` Pavel Begunkov
2020-01-18 0:16 ` Jens Axboe
2020-01-18 10:24 ` [PATCH v2] io_uring: optimise sqe-to-req flags translation Pavel Begunkov
2020-01-18 16:34 ` Jens Axboe
2020-01-18 17:10 ` Pavel Begunkov
2020-01-18 17:22 ` [PATCH v3 1/1] " Pavel Begunkov
2020-01-18 20:46 ` Jens Axboe
2020-01-19 7:46 ` Pavel Begunkov
2020-01-19 17:36 ` Jens Axboe
2020-01-18 20:45 ` Jens Axboe [this message]
2020-01-17 22:50 ` [PATCH 1/2] io_uring: remove REQ_F_IO_DRAINED Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b358b578-f0bd-8886-a75b-b9caefea2496@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.