From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sai Prakash Ranjan Subject: Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs Date: Fri, 7 Sep 2018 10:32:01 +0530 Message-ID: References: <1536103345-1919-1-git-send-email-vnkgutta@codeaurora.org> <1536103345-1919-4-git-send-email-vnkgutta@codeaurora.org> <105f8339-61bc-072e-0498-ed44470a5fb8@codeaurora.org> <5d8f92b480e1b53e7e04da965d44f7ea@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <5d8f92b480e1b53e7e04da965d44f7ea@codeaurora.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: vnkgutta@codeaurora.org Cc: Borislav Petkov , evgreen@chromium.org, robh@kernel.org, mchehab@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, tsoni@codeaurora.org, ckadabi@codeaurora.org, rishabhb@codeaurora.org, swboyd@chromium.org, bjorn.andersson@linaro.org List-Id: linux-arm-msm@vger.kernel.org On 9/7/2018 4:01 AM, vnkgutta@codeaurora.org wrote: > On 2018-09-06 05:38, Sai Prakash Ranjan wrote: >> On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: >>> +static const struct of_device_id qcom_llcc_edac_match_table[] = { >>> +    { .compatible = "qcom,llcc-edac" }, >>> +    { }, >>> +}; >>> + >>> >> Hi Venkata, >> >> Devicetree binding for llcc is updated, but what about this compatible? > > Does it need documentation too? I was not sure if I should add > documentation for this or not! > It does not require a separate binding, what I meant was to add this compatible in the llcc binding itself, maybe as a subnode if it is correct. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,3/4] drivers: edac: Add EDAC driver support for QCOM SoCs From: saiprakash.ranjan@codeaurora.org Message-Id: Date: Fri, 7 Sep 2018 10:32:01 +0530 To: vnkgutta@codeaurora.org Cc: Borislav Petkov , evgreen@chromium.org, robh@kernel.org, mchehab@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, tsoni@codeaurora.org, ckadabi@codeaurora.org, rishabhb@codeaurora.org, swboyd@chromium.org, bjorn.andersson@linaro.org List-ID: T24gOS83LzIwMTggNDowMSBBTSwgdm5rZ3V0dGFAY29kZWF1cm9yYS5vcmcgd3JvdGU6Cj4gT24g MjAxOC0wOS0wNiAwNTozOCwgU2FpIFByYWthc2ggUmFuamFuIHdyb3RlOgo+PiBPbiA5LzUvMjAx OCA0OjUyIEFNLCBWZW5rYXRhIE5hcmVuZHJhIEt1bWFyIEd1dHRhIHdyb3RlOgo+Pj4gK3N0YXRp YyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHFjb21fbGxjY19lZGFjX21hdGNoX3RhYmxlW10g PSB7Cj4+PiArwqDCoMKgIHsgLmNvbXBhdGlibGUgPSAicWNvbSxsbGNjLWVkYWMiIH0sCj4+PiAr wqDCoMKgIHsgfSwKPj4+ICt9Owo+Pj4gKwo+Pj4KPj4gSGkgVmVua2F0YSwKPj4KPj4gRGV2aWNl dHJlZSBiaW5kaW5nIGZvciBsbGNjIGlzIHVwZGF0ZWQsIGJ1dCB3aGF0IGFib3V0IHRoaXMgY29t cGF0aWJsZT8KPiAKPiBEb2VzIGl0IG5lZWQgZG9jdW1lbnRhdGlvbiB0b28/IEkgd2FzIG5vdCBz dXJlIGlmIEkgc2hvdWxkIGFkZCAKPiBkb2N1bWVudGF0aW9uIGZvciB0aGlzIG9yIG5vdCEKPiAK Ckl0IGRvZXMgbm90IHJlcXVpcmUgYSBzZXBhcmF0ZSBiaW5kaW5nLCB3aGF0IEkgbWVhbnQgd2Fz IHRvIGFkZCB0aGlzIApjb21wYXRpYmxlIGluIHRoZSBsbGNjIGJpbmRpbmcgaXRzZWxmLCBtYXli ZSBhcyBhIHN1Ym5vZGUgaWYgaXQgaXMgY29ycmVjdC4K