From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCHv3 02/30] drm/omap: refactor CRTC HW property setup Date: Wed, 29 Mar 2017 11:12:01 +0300 Message-ID: References: <1490706496-4959-1-git-send-email-tomi.valkeinen@ti.com> <1490706496-4959-3-git-send-email-tomi.valkeinen@ti.com> <2048643.8WzJVPJgeQ@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0607016340==" Return-path: Received: from fllnx209.ext.ti.com (fllnx209.ext.ti.com [198.47.19.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF4536E3D0 for ; Wed, 29 Mar 2017 08:12:31 +0000 (UTC) In-Reply-To: <2048643.8WzJVPJgeQ@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Jyri Sarha , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0607016340== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p9nWeaGqjU882V9wgHNOBgAHvi2GwQgfW" --p9nWeaGqjU882V9wgHNOBgAHvi2GwQgfW Content-Type: multipart/mixed; boundary="63ermNATK4xTnxH2tAcucwsHL5EIcsFdx"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Jyri Sarha Message-ID: Subject: Re: [PATCHv3 02/30] drm/omap: refactor CRTC HW property setup References: <1490706496-4959-1-git-send-email-tomi.valkeinen@ti.com> <1490706496-4959-3-git-send-email-tomi.valkeinen@ti.com> <2048643.8WzJVPJgeQ@avalon> In-Reply-To: <2048643.8WzJVPJgeQ@avalon> --63ermNATK4xTnxH2tAcucwsHL5EIcsFdx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 29/03/17 11:05, Laurent Pinchart wrote: >> +static void omap_crtc_write_crtc_properties(struct drm_crtc *crtc) >> +{ >> + struct omap_crtc *omap_crtc =3D to_omap_crtc(crtc); >> + struct omap_overlay_manager_info info; >> + >> + memset(&info, 0, sizeof(info)); >> + >> + info.default_color =3D 0x000000; >> + info.trans_enabled =3D false; >> + info.partial_alpha_enabled =3D false; >> + info.cpr_enable =3D false; >=20 > Nitpicking, you could initialize info when declaring it, I think it wou= ld be=20 > slightly more efficient. These are open coded here so that it's easy to change these line by line when we add the properties, and that code most likely can't be in the initializer. But yes, at the moment it looks a bit silly. >> + >> + dispc_mgr_setup(omap_crtc->channel, &info); >=20 > dispc_mgr_setup() was previously called from omap_crtc_dss_enable() wit= h the=20 > DSS disabled. Now it can be called with the DSS enabled. Have you doubl= e- > checked that this isn't an issue ? It's not an issue, it's how it's supposed to work. These mgr-settings are "shadow" settings, i.e. they take effect when we set the GO bit (like the plane settings). They were only written in dss_enable() as we didn't have support to change those properties. I hope will get those properties some time soon, so we need to write the mgr-settings even when the output is enable= d. Tomi --63ermNATK4xTnxH2tAcucwsHL5EIcsFdx-- --p9nWeaGqjU882V9wgHNOBgAHvi2GwQgfW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJY22xRAAoJEPo9qoy8lh71DnwP/icyBtfBBoYZG3qgdqRXWTrj +cq7DYpsjHJ+1UyB5igKqgamsKLIeuZpa3xO+26/xUliDpIer7uUDjA+sat4cwBX HCdpvssWyxSIgjHod2T1GkLjPO56ToWCbmy/CpxRtiTk9O/z4QLwu02nw2usC4vo Ql2iL0LPThYjCkALkRRbUie1UwE/389a7OhH/fBx62J9n8lLjFhOluJVGJ7M3utA LE0WkTLbi65hmG2rlk/cCJcmr2b8PJTSFiCYooUw/scOnsxhCsV9ipObqXnLXzu/ g1a/wLf2GHWgIamt3vVFexlOsKVljRHlfdnRkigY9CeyZTiHYmLSG289KJ/J5VNY sTIP4pLPEILRciZVPutbHjXGo97vKQSkwpMkZSf+zQVwxf9nrxX077ZsOMiE3tjh qyYez9mIzWGwActanmewKCUUIDrFlTcAJDldxubdsc5lNiHa0Bxc1WplPunRUh1c +VY2aJAdsFLteWstHmbLhA1lwzo90mCpwdSTGD3Lp41CnEfPLMg/G24vJX2TlHoR W/O78bqw1h/kgSMRFRc0Uq0palqY8vJCkJF2gIETXHTQsingFKwaKqRttAr22yjt 6rgdu/+2+cgbTFGfCheVV6LZ+pQBzPGopY9LFB+Clu4NNbG4YirBTbw/cQVnI+KS NhwMrCiszn1mWOFK227v =Prwz -----END PGP SIGNATURE----- --p9nWeaGqjU882V9wgHNOBgAHvi2GwQgfW-- --===============0607016340== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0607016340==--