From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 059C7C433FE for ; Sat, 8 Jan 2022 05:34:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230292AbiAHFeZ (ORCPT ); Sat, 8 Jan 2022 00:34:25 -0500 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:17913 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229708AbiAHFeY (ORCPT ); Sat, 8 Jan 2022 00:34:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1641620064; x=1673156064; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=rur0/nZv+Mm/lbEL32xKYlmQrxtSdjeSo48l1xph7k8=; b=jjkZLFZMHk8L/E7zv84O+8hjotCGU4HCcqqa2NGm6871gfL5ghjNaFWN d+v3mnOD7yR9mVliP5pnau7JXFmBqWmc4pDAPB2+VcXeLuepkWM9yJpxA Lq/6B5mm0sz41GZ24UFFYQc3QNMimtWnSGXgyeitROeaKQMCicWAhA+iS 4=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 07 Jan 2022 21:34:24 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2022 21:34:24 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Fri, 7 Jan 2022 21:34:23 -0800 Received: from [10.50.8.216] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Fri, 7 Jan 2022 21:34:19 -0800 Message-ID: Date: Sat, 8 Jan 2022 11:04:16 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCHv6 4/5] tracing: Add register read/write tracing support Content-Language: en-US To: Steven Rostedt CC: Will Deacon , Catalin Marinas , Marc Zyngier , Arnd Bergmann , gregkh , , , , , Prasad Sodagudi References: <76983c26d889df7252a17017a48754163fb6b0d5.1638858747.git.quic_saipraka@quicinc.com> <20220106131824.073fbe5c@gandalf.local.home> <20220107095638.7d81c1b9@gandalf.local.home> From: Sai Prakash Ranjan In-Reply-To: <20220107095638.7d81c1b9@gandalf.local.home> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On 1/7/2022 8:26 PM, Steven Rostedt wrote: > On Fri, 7 Jan 2022 10:40:05 +0530 > Sai Prakash Ranjan wrote: > >> Hi Steve, >> >> On 1/6/2022 11:48 PM, Steven Rostedt wrote: >>> This should not be in the kernel/trace directory. It should be in the >> Hmm these are called from low level generic io header file >> (include/asm-generic/) where >> we wouldn't have any Kconfig to control this feature flexibly and as we >> can have this as >> a generic feature selectable by other architectures, wouldn't this be >> suited in kernel/trace? > Isn't there a place for generic rwmmio code? I am thinking of moving it to lib/ similar to an interface of logic_iomem.c which Arnd had initially suggested to look at. >> I thought you were ok with the folder structure in the initial versions >> of the series? > Sorry, I missed the C file in kernel/trace. The files in kernel/trace tend > to be specific for the internals of tracing. This C file is more to hold > helper functions for mmio, which to me should be someplace for mmio code. > Perhaps in mm/ ? > Oh ok, mm would not be the right fit as it is memory management and this is about memory mapped IO, let me try and move it to lib/ as done for logic_iomem.c Thanks, Sai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E4D4C433EF for ; Sat, 8 Jan 2022 05:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tTSNPiIt4bhkFyaSXjiZqaCDhV5DFclUzAGXybAnanU=; b=hv5BSuP8v0W3/S zWg3GifDWVslxt9UPy/VONhbIfJfEKeM6gOlvBq+gl5Fl2/xlkOBqVtuhAsR1z3mCcLW+QljpjWfZ nFTD8lqr8X5o8qaB5CTQA3j1xv08JYO5WHX+mj9fhI8gDzAbtwga8TffP+HOXMdFziTEUGPD8pf5I c81mljva+QldMIUIGAiccuVB16rSmEHf26tiY1S7TGJWyPME6JxuqprHutLsu6CSbp5zRnsPtCNru loA6nGF9reQwo9cLhhc5aReVqjK6jJdVvggB8svorAJ1+cEDERiuE6Lsyjn3h3AF9+vpB/q2PaMk6 VwO60HA2t9b/dVTYatOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n64N3-005zNh-OD; Sat, 08 Jan 2022 05:34:29 +0000 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n64N0-005zNL-Ff for linux-arm-kernel@lists.infradead.org; Sat, 08 Jan 2022 05:34:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1641620066; x=1673156066; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=rur0/nZv+Mm/lbEL32xKYlmQrxtSdjeSo48l1xph7k8=; b=LDk0YTs+R0yZe0kdpJk7d0dms1YEYVObHFuxOsVKJJBVWLGABYYHgbGW yiKjzinE6Dj2NXrgYNgpJZg87bZDMdvlukNmhyBy8vF4TkSSruYHcmGNB Jc1HA/AUDuopAHcBD8KHThxIBAMUNkI2zpW03Y/+5F2jaRQvqTXOo3YWz I=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 07 Jan 2022 21:34:24 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2022 21:34:24 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Fri, 7 Jan 2022 21:34:23 -0800 Received: from [10.50.8.216] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Fri, 7 Jan 2022 21:34:19 -0800 Message-ID: Date: Sat, 8 Jan 2022 11:04:16 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCHv6 4/5] tracing: Add register read/write tracing support Content-Language: en-US To: Steven Rostedt CC: Will Deacon , Catalin Marinas , Marc Zyngier , Arnd Bergmann , gregkh , , , , , Prasad Sodagudi References: <76983c26d889df7252a17017a48754163fb6b0d5.1638858747.git.quic_saipraka@quicinc.com> <20220106131824.073fbe5c@gandalf.local.home> <20220107095638.7d81c1b9@gandalf.local.home> From: Sai Prakash Ranjan In-Reply-To: <20220107095638.7d81c1b9@gandalf.local.home> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_213426_613989_289EA8B5 X-CRM114-Status: GOOD ( 14.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 1/7/2022 8:26 PM, Steven Rostedt wrote: > On Fri, 7 Jan 2022 10:40:05 +0530 > Sai Prakash Ranjan wrote: > >> Hi Steve, >> >> On 1/6/2022 11:48 PM, Steven Rostedt wrote: >>> This should not be in the kernel/trace directory. It should be in the >> Hmm these are called from low level generic io header file >> (include/asm-generic/) where >> we wouldn't have any Kconfig to control this feature flexibly and as we >> can have this as >> a generic feature selectable by other architectures, wouldn't this be >> suited in kernel/trace? > Isn't there a place for generic rwmmio code? I am thinking of moving it to lib/ similar to an interface of logic_iomem.c which Arnd had initially suggested to look at. >> I thought you were ok with the folder structure in the initial versions >> of the series? > Sorry, I missed the C file in kernel/trace. The files in kernel/trace tend > to be specific for the internals of tracing. This C file is more to hold > helper functions for mmio, which to me should be someplace for mmio code. > Perhaps in mm/ ? > Oh ok, mm would not be the right fit as it is memory management and this is about memory mapped IO, let me try and move it to lib/ as done for logic_iomem.c Thanks, Sai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel