From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C63A1C433EF for ; Wed, 8 Jun 2022 07:47:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234196AbiFHHry (ORCPT ); Wed, 8 Jun 2022 03:47:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239443AbiFHHiJ (ORCPT ); Wed, 8 Jun 2022 03:38:09 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1194D1B82AD for ; Wed, 8 Jun 2022 00:03:44 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id c2so25770883edf.5 for ; Wed, 08 Jun 2022 00:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=/P5DonPEbL4zrk1lq27Ekk5M3s4m3V/4aGFOiKZb8iw=; b=tNxFbUlk894ytaMSQBGHCh2CKU8QcY9xUHyTRn9WX4sjlRipH13BWFDnYPyywlXCiE adRCZ3HNmK3ewQyLZLZPFIUP5PmCymNE0ruugSr1SUwDTyNBQ7wc268t93ZM/mIiy3PB tSTOrGBxURXhUDSRctt4qvT8Jw5biZn6m7IIUB2DdG2KNqG3R0iEzrjOwdvixNmicvbG iaBwNe5PBucqG0KmhHdNMeAb31cTu6GxNggVFyJBJxJtSaWI6kSVyc9+12z1QSKAOwlD F+hKqjIXw/fHIWrius0cqfAOAkJocFLfUKdSg7Iv54CkF8jh0AGWdkhJ+qjzYCVWas+m bQZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/P5DonPEbL4zrk1lq27Ekk5M3s4m3V/4aGFOiKZb8iw=; b=6GCphqYm/R57hzn02NLDUpBGs33Uvuss0tOWkGBVb1a8791/UMe1rKJ/UVK1cUE1rx oLwwfC8JODBmFp4eIK46hoMERrGp/QGWwLYMElfqVVZcXcxRf8QiJTPC8/UOg4Os0WWn aK9dVWwv2SiaOZjFtRGqJMdjEDXIILLu6rB4aG+VRnmzfxdn9hbs2js4JNhxZfJ9b8Ir 6SR/Yu35ZFXMEiWgEUviy4MJ8o933ApayXdIWaCKs/q53amnjoliLqgXePMrT7dqrIQT uHyCRA4LdM+0Xcl7cRl6BObE/iUfxu25zjUM9936BSQlI4nRy1olVMrrowd4+VybhFar 9Q6w== X-Gm-Message-State: AOAM533GFLURz+hNzcSWNlyGgo54r47KlvbV64TLe/Upi3RqWaRdMHmF 4xfFQguZLpcy37eVgP/uhi91Dw== X-Google-Smtp-Source: ABdhPJw2vWTH67y24uKVTvgMlYsRtG5nGCSYzVcpmzPlzZcTRbGD2+Va5H64O4ZQ/Ih1pH+cLtpzNQ== X-Received: by 2002:a05:6402:1692:b0:42d:e291:67f3 with SMTP id a18-20020a056402169200b0042de29167f3mr36847187edv.392.1654671822360; Wed, 08 Jun 2022 00:03:42 -0700 (PDT) Received: from [192.168.0.188] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id 10-20020a170906058a00b007101f6f0720sm5919524ejn.120.2022.06.08.00.03.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 00:03:41 -0700 (PDT) Message-ID: Date: Wed, 8 Jun 2022 09:03:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 4/4] input: misc: rt5120: Add power key support Content-Language: en-US To: cy_huang , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee.jones@linaro.org, broonie@kernel.org, dmitry.torokhov@gmail.com Cc: lgirdwood@gmail.com, cy_huang@richtek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org References: <1654581161-12349-1-git-send-email-u0084500@gmail.com> <1654581161-12349-5-git-send-email-u0084500@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <1654581161-12349-5-git-send-email-u0084500@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2022 07:52, cy_huang wrote: > From: ChiYuan Huang > > Add RT5120 PMIC power key support. > > Signed-off-by: ChiYuan Huang > --- > drivers/input/misc/Kconfig | 9 +++ > drivers/input/misc/Makefile | 1 + > drivers/input/misc/rt5120-pwrkey.c | 115 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 125 insertions(+) > create mode 100644 drivers/input/misc/rt5120-pwrkey.c > > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig > index dd5227c..9c0d814 100644 > --- a/drivers/input/misc/Kconfig > +++ b/drivers/input/misc/Kconfig > @@ -881,6 +881,15 @@ config INPUT_SC27XX_VIBRA > To compile this driver as a module, choose M here. The module will > be called sc27xx_vibra. > > +config INPUT_RT5120_PWRKEY > + tristate "RT5120 PMIC power key support" > + depends on MFD_RT5120 > + help > + This enables support for RT5120 PMIC power key driver. > + > + To compile this driver as a module, choose M here. the module will > + be called rt5120-pwerkey. > + > config INPUT_STPMIC1_ONKEY > tristate "STPMIC1 PMIC Onkey support" > depends on MFD_STPMIC1 > diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile > index b92c53a..164ea20 100644 > --- a/drivers/input/misc/Makefile > +++ b/drivers/input/misc/Makefile > @@ -68,6 +68,7 @@ obj-$(CONFIG_INPUT_RAVE_SP_PWRBUTTON) += rave-sp-pwrbutton.o > obj-$(CONFIG_INPUT_RB532_BUTTON) += rb532_button.o > obj-$(CONFIG_INPUT_REGULATOR_HAPTIC) += regulator-haptic.o > obj-$(CONFIG_INPUT_RETU_PWRBUTTON) += retu-pwrbutton.o > +obj-$(CONFIG_INPUT_RT5120_PWRKEY) += rt5120-pwrkey.o > obj-$(CONFIG_INPUT_AXP20X_PEK) += axp20x-pek.o > obj-$(CONFIG_INPUT_GPIO_ROTARY_ENCODER) += rotary_encoder.o > obj-$(CONFIG_INPUT_RK805_PWRKEY) += rk805-pwrkey.o > diff --git a/drivers/input/misc/rt5120-pwrkey.c b/drivers/input/misc/rt5120-pwrkey.c > new file mode 100644 > index 00000000..42bd2f3 > --- /dev/null > +++ b/drivers/input/misc/rt5120-pwrkey.c > @@ -0,0 +1,115 @@ > +// SPDX-License-Identifier: GPL-2.0+ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define RT5120_REG_INTSTAT 0x1E > +#define RT5120_PWRKEYSTAT_MASK BIT(7) > + > +struct rt5120_priv { > + struct regmap *regmap; > + struct input_dev *input; > + int press_irq; > + int release_irq; > +}; > + > +static irqreturn_t rt5120_pwrkey_handler(int irq, void *devid) > +{ > + struct rt5120_priv *priv = devid; > + unsigned int stat; > + bool is_pressed; > + int ret; > + > + ret = regmap_read(priv->regmap, RT5120_REG_INTSTAT, &stat); > + if (ret) > + return IRQ_NONE; > + > + is_pressed = !(stat & RT5120_PWRKEYSTAT_MASK); > + > + if ((is_pressed && irq == priv->press_irq) || > + (!is_pressed && irq == priv->release_irq)) { > + input_report_key(priv->input, KEY_POWER, is_pressed); > + input_sync(priv->input); > + } > + > + return IRQ_HANDLED; > +} > + > +static int rt5120_pwrkey_probe(struct platform_device *pdev) > +{ > + struct rt5120_priv *priv; > + int ret; > + > + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + priv->regmap = dev_get_regmap(pdev->dev.parent, NULL); > + if (!priv->regmap) { > + dev_err(&pdev->dev, "Failed to init regmap\n"); > + return -ENODEV; > + } > + > + priv->press_irq = platform_get_irq_byname(pdev, "pwrkey-press"); > + if (priv->press_irq < 0) > + return priv->press_irq; > + > + priv->release_irq = platform_get_irq_byname(pdev, "pwrkey-release"); > + if (priv->release_irq < 0) > + return priv->release_irq; Not described in the bindings. All properties need to be documented. Best regards, Krzysztof