From: Jens Axboe <axboe@kernel.dk>
To: Ammar Faizi <ammar.faizi@students.amikom.ac.id>,
Pavel Begunkov <asml.silence@gmail.com>,
io-uring Mailing List <io-uring@vger.kernel.org>
Cc: Bedirhan KURT <windowz414@gnuweeb.org>,
Louvian Lyndal <louvianlyndal@gmail.com>
Subject: Re: [PATCH v2 liburing 3/4] Add no libc build support
Date: Sun, 10 Oct 2021 05:19:29 -0600 [thread overview]
Message-ID: <b37e2154-6555-4a0c-1212-ddb31bc7309e@kernel.dk> (raw)
In-Reply-To: <20211010063906.341014-4-ammar.faizi@students.amikom.ac.id>
On 10/10/21 12:39 AM, Ammar Faizi wrote:
> +#ifdef CONFIG_NOLIBC
> +# if defined(__x86_64__) || defined(__i386__)
> +# include "arch/x86/lib.h"
> +# else
> +# error "The arch is currently not supported to build liburing without libc"
> +# endif
> +#endif
That reads a bit awkwardly, how about:
"This arch doesn't support building liburing without linc"
--
Jens Axboe
next prev parent reply other threads:[~2021-10-10 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 6:39 [PATCHSET v2 liburing 0/4] Add nolibc support for x86-64 arch Ammar Faizi
2021-10-10 6:39 ` [PATCH v2 liburing 1/4] test/thread-exit: Fix use after free bug Ammar Faizi
2021-10-10 11:25 ` Jens Axboe
2021-10-10 6:39 ` [PATCH v2 liburing 2/4] Add arch dependent directory and files Ammar Faizi
2021-10-10 11:16 ` Jens Axboe
2021-10-10 6:39 ` [PATCH v2 liburing 3/4] Add no libc build support Ammar Faizi
2021-10-10 11:19 ` Jens Axboe [this message]
2021-10-10 6:39 ` [PATCH v2 liburing 4/4] Add CONFIG_NOLIBC variable and macro Ammar Faizi
2021-10-10 11:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b37e2154-6555-4a0c-1212-ddb31bc7309e@kernel.dk \
--to=axboe@kernel.dk \
--cc=ammar.faizi@students.amikom.ac.id \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=louvianlyndal@gmail.com \
--cc=windowz414@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.