From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572AbdLGFhW (ORCPT ); Thu, 7 Dec 2017 00:37:22 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:54747 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752326AbdLGFhI (ORCPT ); Thu, 7 Dec 2017 00:37:08 -0500 Subject: Re: [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare To: Christoph Hellwig Cc: Mark Rutland , devicetree@vger.kernel.org, Liam Girdwood , Shawn Guo , Michael Turquette , Stephen Boyd , Russell King , linux-kernel@vger.kernel.org, Rob Herring , Mark Brown , kernel@pengutronix.de, Fabio Estevam , Andrew Morton , Leonard Crestez , Linus Torvalds , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20171206072402.11694-1-o.rempel@pengutronix.de> <20171206072402.11694-4-o.rempel@pengutronix.de> <20171206231130.GA6235@infradead.org> From: Oleksij Rempel Message-ID: Date: Thu, 7 Dec 2017 06:36:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171206231130.GA6235@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:13da X-SA-Exim-Mail-From: o.rempel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.12.2017 00:11, Christoph Hellwig wrote: >> void (*pm_power_off_prepare)(void); >> +EXPORT_SYMBOL(pm_power_off_prepare); > > EXPORT_SYMBOL_GPL for something this deeply internal, please. Ok, probably all other symbols should be converted in this file in to EXPORT_SYMBOL_GPL as well? grep EXPORT_SYMBOL kernel/reboot.c EXPORT_SYMBOL(cad_pid); EXPORT_SYMBOL(pm_power_off_prepare); EXPORT_SYMBOL_GPL(emergency_restart); EXPORT_SYMBOL(register_reboot_notifier); EXPORT_SYMBOL(unregister_reboot_notifier); EXPORT_SYMBOL(devm_register_reboot_notifier); EXPORT_SYMBOL(register_restart_handler); EXPORT_SYMBOL(unregister_restart_handler); EXPORT_SYMBOL_GPL(kernel_restart); EXPORT_SYMBOL_GPL(kernel_halt); EXPORT_SYMBOL_GPL(kernel_power_off); EXPORT_SYMBOL_GPL(orderly_poweroff); EXPORT_SYMBOL_GPL(orderly_reboot); From mboxrd@z Thu Jan 1 00:00:00 1970 From: o.rempel@pengutronix.de (Oleksij Rempel) Date: Thu, 7 Dec 2017 06:36:55 +0100 Subject: [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare In-Reply-To: <20171206231130.GA6235@infradead.org> References: <20171206072402.11694-1-o.rempel@pengutronix.de> <20171206072402.11694-4-o.rempel@pengutronix.de> <20171206231130.GA6235@infradead.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07.12.2017 00:11, Christoph Hellwig wrote: >> void (*pm_power_off_prepare)(void); >> +EXPORT_SYMBOL(pm_power_off_prepare); > > EXPORT_SYMBOL_GPL for something this deeply internal, please. Ok, probably all other symbols should be converted in this file in to EXPORT_SYMBOL_GPL as well? grep EXPORT_SYMBOL kernel/reboot.c EXPORT_SYMBOL(cad_pid); EXPORT_SYMBOL(pm_power_off_prepare); EXPORT_SYMBOL_GPL(emergency_restart); EXPORT_SYMBOL(register_reboot_notifier); EXPORT_SYMBOL(unregister_reboot_notifier); EXPORT_SYMBOL(devm_register_reboot_notifier); EXPORT_SYMBOL(register_restart_handler); EXPORT_SYMBOL(unregister_restart_handler); EXPORT_SYMBOL_GPL(kernel_restart); EXPORT_SYMBOL_GPL(kernel_halt); EXPORT_SYMBOL_GPL(kernel_power_off); EXPORT_SYMBOL_GPL(orderly_poweroff); EXPORT_SYMBOL_GPL(orderly_reboot);