From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 04/41] bus/dpaa: add OF parser for device
	scanning
Date: Tue, 19 Sep 2017 19:07:33 +0530
Message-ID: <b3a1e038-987f-6c03-ffca-c023fa0af4f5@nxp.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-5-shreyansh.jain@nxp.com>
 <01df3c65-e7dc-b2b8-a188-dd88018010dc@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0064.outbound.protection.outlook.com [104.47.33.64])
 by dpdk.org (Postfix) with ESMTP id 729FF1AEF0
 for <dev@dpdk.org>; Tue, 19 Sep 2017 15:26:39 +0200 (CEST)
In-Reply-To: <01df3c65-e7dc-b2b8-a188-dd88018010dc@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote:
> On 9/9/2017 12:20 PM, Shreyansh Jain wrote:
>> This layer is used by Bus driver's scan function. Devices are parsed
>> using OF parser and added to DPAA device list.
> 
> So this is device tree parser in DPDK. Do we really want this, and as
> long as DPDK target the bare metal why not get device information from
> Linux, as done in other cases?
As of now I don't prefer to modify the internal framework as much as 
possible as this is stable DPDK DPAA driver.
There is indeed a planned transition from OF to /sys/ parsing, but it is 
still in pipeline.

You see a blocking issue if we go incremental here?
That would be probably more of replacing this file with another /sys 
parser without much changes to the DPDK glue code.

> 
>>
>> Signed-off-by: Geoff Thorpe <geoff.thorpe@nxp.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> ---
>>   drivers/bus/dpaa/Makefile       |   7 +
>>   drivers/bus/dpaa/base/fman/of.c | 576 ++++++++++++++++++++++++++++++++++++++++
>>   drivers/bus/dpaa/include/of.h   | 190 +++++++++++++
>>   3 files changed, 773 insertions(+)
>>   create mode 100644 drivers/bus/dpaa/base/fman/of.c
>>   create mode 100644 drivers/bus/dpaa/include/of.h
>>
> 
> <...>
> 
>