From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF06C54EE9 for ; Thu, 22 Sep 2022 19:54:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229496AbiIVTy3 (ORCPT ); Thu, 22 Sep 2022 15:54:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231896AbiIVTyZ (ORCPT ); Thu, 22 Sep 2022 15:54:25 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D63C10CA41 for ; Thu, 22 Sep 2022 12:54:24 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id z25so16475187lfr.2 for ; Thu, 22 Sep 2022 12:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=zDb70WoeINlNx9irFKk6bRAswY6QKXf8jtRE5Sg+xuc=; b=e14Rma8aobSIPoTFiAvddfO9VrrSEWb5OAv/vAYZrJyxHZLKgNe7FRwCy8H+rMq55z 9SgiTOBTOW5fbmBNgeSLAEswJqAdv+LvGlIkFYAwH5ZmH67wkj9mWeUbArfatAFrMITy 9DTvu3wxHjcAVDwgrJzXLdF5we1tV7FdJIj9KDmNAUPS02FjiFghQr2HzEoA0jbmBTdD yFe40SVo0m6meu1ADwI7rqHmpd4ZXWuul8inj7VP+Iu89bdcLwE+TX3DtI1IyE6YolYu EE9zpZO9JDEx7z8DE50gxK2keFlv11vniqms6lWh7RqacygUPDuWhhjAvMThlrht3wx3 meug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=zDb70WoeINlNx9irFKk6bRAswY6QKXf8jtRE5Sg+xuc=; b=x0Zo2WXIupFX/Mu28Kvhw133GdBUxNyn5wmxeePq8Ym+l/jkHP0F+n9QpiosozmsQ9 buXiwsHrM/FJ7XQcXMlZJnQWxCJCLXVHa0m0qqYr79jxPlOeduIdNLW8QXIp4IRc7psI LCnmtu2iy8cejU7HPp1OcxXyvHuDbLNmXMlBwLdLOhNp4Pizsue0TsXkQvWVBqNeVRxm 27M5smtGZ4NREG3VwgRSr5YGtSL1QRYpgNnBegPMlp+GBZo6RgFDYpGuonpb3iHaG2qL ajQgLhrb6lPBUWal7Rvyzqjne3BW+TltVUST8RaNC1+FALcd+j4f6X8p4XJGWpONRWsF A0Gg== X-Gm-Message-State: ACrzQf2pUusOtoj9sqCgxLTS6jidbiEpz2nDhMn4f2IQyWX/6uRZJD41 usDUun1n02MaMVxinQ3TtV4L5Q== X-Google-Smtp-Source: AMsMyM6rSKkJT7IrEEGLQaau0EqzxrS/guqoT52jaku/kN4wSEXcJRuY7+W54WkiFW0yNFbLYDB6yQ== X-Received: by 2002:ac2:454a:0:b0:49c:6212:c44d with SMTP id j10-20020ac2454a000000b0049c6212c44dmr2035689lfm.430.1663876462589; Thu, 22 Sep 2022 12:54:22 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id r10-20020ac24d0a000000b0048af3c090f8sm1089401lfi.13.2022.09.22.12.54.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 12:54:22 -0700 (PDT) Message-ID: Date: Thu, 22 Sep 2022 22:54:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 02/10] drm/msm/dp: fix memory corruption with too many bridges Content-Language: en-GB To: Johan Hovold , Douglas Anderson , Rob Clark , Abhinav Kumar Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Daniel Vetter , Sean Paul , Stephen Boyd , Bjorn Andersson , Manivannan Sadhasivam , Kuogee Hsieh , Steev Klimaszewski , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20220913085320.8577-1-johan+linaro@kernel.org> <20220913085320.8577-3-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20220913085320.8577-3-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 13/09/2022 11:53, Johan Hovold wrote: > Add the missing sanity check on the bridge counter to avoid corrupting > data beyond the fixed-sized bridge array in case there are ever more > than eight bridges. > > Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") > Cc: stable@vger.kernel.org # 5.17 > Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BF19C6FA82 for ; Thu, 22 Sep 2022 19:54:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7764610E16E; Thu, 22 Sep 2022 19:54:43 +0000 (UTC) Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 460BE10E20A for ; Thu, 22 Sep 2022 19:54:24 +0000 (UTC) Received: by mail-lf1-x12d.google.com with SMTP id f14so16462359lfg.5 for ; Thu, 22 Sep 2022 12:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=zDb70WoeINlNx9irFKk6bRAswY6QKXf8jtRE5Sg+xuc=; b=e14Rma8aobSIPoTFiAvddfO9VrrSEWb5OAv/vAYZrJyxHZLKgNe7FRwCy8H+rMq55z 9SgiTOBTOW5fbmBNgeSLAEswJqAdv+LvGlIkFYAwH5ZmH67wkj9mWeUbArfatAFrMITy 9DTvu3wxHjcAVDwgrJzXLdF5we1tV7FdJIj9KDmNAUPS02FjiFghQr2HzEoA0jbmBTdD yFe40SVo0m6meu1ADwI7rqHmpd4ZXWuul8inj7VP+Iu89bdcLwE+TX3DtI1IyE6YolYu EE9zpZO9JDEx7z8DE50gxK2keFlv11vniqms6lWh7RqacygUPDuWhhjAvMThlrht3wx3 meug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=zDb70WoeINlNx9irFKk6bRAswY6QKXf8jtRE5Sg+xuc=; b=Jt32K560FqhqM2Oy5kHn48u4flYcHaikPY0655LMD+IZ2ePZCBYjEKQs2bUF65CgOv TgETjm1qx4401FQMbuBdtjUUNTQfS9Wu01Wd7MDnCJSXrUmhs8aGx3lGRojoIm2lA3Xb xgS26Q+3VKpUAXMxKigo7ju9C0Y09m0quk8KVG/gcaedkg6rnofvjCGW27xyPO7haCI+ G13I68zLTg1VxRnMAJ7GulxA+yjnvN2cdSANMCS+HRFj0MmaF3U00DItdAgxidjH69TH DiVW2RSEqP/dbDDhirJ4E5X/0AN7IwZil/4iWI7yQ4SjA8hwuuPTGrBS0lbVBNmAuhg3 6n3A== X-Gm-Message-State: ACrzQf2z3vljWZbxi+TuPHIDQvnKRbBLRzKvFGLjUo70dV+PaSYhQ2CE 2ZiMLAvku6MmuQYqvQQIS0krVg== X-Google-Smtp-Source: AMsMyM6rSKkJT7IrEEGLQaau0EqzxrS/guqoT52jaku/kN4wSEXcJRuY7+W54WkiFW0yNFbLYDB6yQ== X-Received: by 2002:ac2:454a:0:b0:49c:6212:c44d with SMTP id j10-20020ac2454a000000b0049c6212c44dmr2035689lfm.430.1663876462589; Thu, 22 Sep 2022 12:54:22 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id r10-20020ac24d0a000000b0048af3c090f8sm1089401lfi.13.2022.09.22.12.54.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 12:54:22 -0700 (PDT) Message-ID: Date: Thu, 22 Sep 2022 22:54:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 02/10] drm/msm/dp: fix memory corruption with too many bridges Content-Language: en-GB To: Johan Hovold , Douglas Anderson , Rob Clark , Abhinav Kumar References: <20220913085320.8577-1-johan+linaro@kernel.org> <20220913085320.8577-3-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20220913085320.8577-3-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Neil Armstrong , Jonas Karlman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , Stephen Boyd , Robert Foss , Andrzej Hajda , Manivannan Sadhasivam , stable@vger.kernel.org, Kuogee Hsieh , Sean Paul , Steev Klimaszewski , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 13/09/2022 11:53, Johan Hovold wrote: > Add the missing sanity check on the bridge counter to avoid corrupting > data beyond the fixed-sized bridge array in case there are ever more > than eight bridges. > > Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") > Cc: stable@vger.kernel.org # 5.17 > Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry