From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF574C282CD for ; Tue, 29 Jan 2019 03:00:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B373C2175B for ; Tue, 29 Jan 2019 03:00:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727166AbfA2DAp (ORCPT ); Mon, 28 Jan 2019 22:00:45 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2791 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727065AbfA2DAp (ORCPT ); Mon, 28 Jan 2019 22:00:45 -0500 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3602F5C6BBE5261A9D7B; Tue, 29 Jan 2019 11:00:43 +0800 (CST) Received: from [127.0.0.1] (10.177.96.96) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.408.0; Tue, 29 Jan 2019 11:00:42 +0800 Subject: Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO. To: , , References: <1548214428-114642-1-git-send-email-maowenan@huawei.com> From: maowenan Message-ID: Date: Tue, 29 Jan 2019 11:00:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1548214428-114642-1-git-send-email-maowenan@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.96.96] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi all， Do you have any comments about this change? On 2019/1/23 11:33, Mao Wenan wrote: > When udp4_gro_receive() get one packet that uh->check=0, > skb_gro_checksum_validate_zero_check() will set the > skb->ip_summed = CHECKSUM_UNNECESSARY; > skb->csum_level = 0; > Then udp_gro_receive() will flush the packet which is not CHECKSUM_PARTIAL, > It is not our expect, because check=0 in udp header indicates this > packet is no need to caculate checksum, we should go further to do GRO. > > This patch changes the value of csum_cnt according to skb->csum_level. > --- > include/linux/netdevice.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 1377d08..9c819f1 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -2764,6 +2764,7 @@ static inline void skb_gro_incr_csum_unnecessary(struct sk_buff *skb) > * during GRO. This saves work if we fallback to normal path. > */ > __skb_incr_checksum_unnecessary(skb); > + NAPI_GRO_CB(skb)->csum_cnt = skb->csum_level + 1; > } > } > >