From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy
Date: Fri, 26 Oct 2018 10:02:01 -0600
Message-ID: <b3d1f6a1-e1aa-1323-33fc-2dadb9602a95@gmail.com>
References: <20181024153249.15374-1-dsahern@kernel.org>
 <20181025063148.GA2143@nanopsycho>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, davem@davemloft.net, pupilla@libero.it
To: Jiri Pirko <jiri@resnulli.us>, David Ahern <dsahern@kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f194.google.com ([209.85.210.194]:46294 "EHLO
        mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726159AbeJ0Ajk (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 26 Oct 2018 20:39:40 -0400
Received: by mail-pf1-f194.google.com with SMTP id r64-v6so750918pfb.13
        for <netdev@vger.kernel.org>; Fri, 26 Oct 2018 09:02:04 -0700 (PDT)
In-Reply-To: <20181025063148.GA2143@nanopsycho>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 10/25/18 12:31 AM, Jiri Pirko wrote:
> Wed, Oct 24, 2018 at 05:32:49PM CEST, dsahern@kernel.org wrote:
>> From: David Ahern <dsahern@gmail.com>
>>
>> Marco reported an error with hfsc:
>> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
>> Error: Attribute failed policy validation.
>>
>> Apparently a few implementations pass TCA_OPTIONS as a binary instead
>> of nested attribute, so drop TCA_OPTIONS from the policy.
> 
> Yeah, this is nice example of a case, where I think it wouldn't hurt to
> be a bit more strict. Apparently, the userspace app is buggy. It should
> be fixed. Note that I'm aware of the bw compatibility.

Kernel side for hfsc expects TCA_OPTIONS as a binary as well - a struct
tc_hfsc_qopt. Nothing that can be done.