From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings Date: Thu, 27 Feb 2020 17:50:19 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Julia Lawall , Andrew Morton Cc: kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Linux Memory Management List , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jon Hunter List-Id: linux-tegra@vger.kernel.org 27.02.2020 13:35, Julia Lawall пишет: > From: kbuild test robot > > Remove dev_err() messages after platform_get_irq*() failures. > platform_get_irq() already prints an error. > > Generated by: scripts/coccinelle/api/platform_get_irq.cocci > > Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST") > CC: Dmitry Osipenko > Signed-off-by: kbuild test robot > Signed-off-by: Julia Lawall > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8 > commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST > :::::: branch date: 17 hours ago > :::::: commit date: 2 days ago > > Please take the patch only if it's a positive warning. Thanks! > > tegra20-apb-dma.c | 1 - > 1 file changed, 1 deletion(-) > > --- a/drivers/dma/tegra20-apb-dma.c > +++ b/drivers/dma/tegra20-apb-dma.c > @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo > irq = platform_get_irq(pdev, i); > if (irq < 0) { > ret = irq; > - dev_err(&pdev->dev, "No irq resource for chan %d\n", i); > goto err_pm_disable; > } > Reviewed-by: Dmitry Osipenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 164A8C11D3D for ; Thu, 27 Feb 2020 14:50:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B230E24656 for ; Thu, 27 Feb 2020 14:50:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dXnm5y8j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B230E24656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0F0C36B0003; Thu, 27 Feb 2020 09:50:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A1356B0005; Thu, 27 Feb 2020 09:50:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1F9E6B0006; Thu, 27 Feb 2020 09:50:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id D7A8E6B0003 for ; Thu, 27 Feb 2020 09:50:23 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 90D25AF81 for ; Thu, 27 Feb 2020 14:50:23 +0000 (UTC) X-FDA: 76536192726.02.noise38_35a2f7b8061d X-HE-Tag: noise38_35a2f7b8061d X-Filterd-Recvd-Size: 4605 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Feb 2020 14:50:22 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id n25so2309291lfl.0 for ; Thu, 27 Feb 2020 06:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kyigCAC3LveOhMS2W/sCuz36oCY49l6gPUPv/Ubz4zI=; b=dXnm5y8jJruyF65hGmRuc/FUzvFO5qM1D44EoSlgVCDIf9XIE8lLiZUJ2ToPyqqSOd HT+x5fv41jRXF5WD4MLE/bfJx2zgZdAWL1VRf2T+wwRN7i+zYaj8ylIIaXcecpT5hbTa ZuGfDgXMe6UcKUA09pjTuz92G6yijRSEHxyAcSOJkDelQ16EeL3Gp5Xz+AphpgwYUCcm gOTpZhJ94tiJ9wBXE5tcqxL9F739xv2tuILCweawnbPcnQXCuijecKVHXKWdRulZvN0f NQelxZVTlZKYqahom8MVwmxuLezbOIb52cTVkf9V9nTmTHJGHcUEPnJmD/V5nIgBWgPa Ddyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kyigCAC3LveOhMS2W/sCuz36oCY49l6gPUPv/Ubz4zI=; b=lQqSjZ6opwCgkMUpqnwLWM7KpPRdNeqgy791hFUTxNMRnQnqQABo4SQP3Pw+rhQTr9 Go3gx67SDGlJpL3cUJJEhl8qzo1ag8JNH0Mi6iVvDtVNNGDCp4MIYaEpno55vYqkcOmJ QkFA7riH3ursFS3SawDkcmZCdUygOs0FClEOgUoLlsD3mOPqLkVjCX6kt9j6j/S9yd13 0sd+K98UW008K+mdDXQhd6jN6WR+1PLLaHK9nDGH73qjc8fjW8aOs7GEx0RA/OXsej05 ZMMikdsm85HYhyQg3cHH4r1VTnHP0ZyTwuCrreZpHxoUhECQfW2VtD2X33RGLO5TORDP R0LA== X-Gm-Message-State: ANhLgQ1GHCKMpHS3RBW+q8edGLzwU+xB5Agzc2PlXHsZ9UmyW5JA4G0g 129473IG7r4LkDdkAI2SCI4= X-Google-Smtp-Source: ADFU+vvzU+LutXBZVfQXvLWlgTjWlcGqlp8HHZniS69joPFA0mFPRd/1wGkm2NQ9p3JV8rnfetIPZw== X-Received: by 2002:a19:490b:: with SMTP id w11mr2439563lfa.125.1582815021060; Thu, 27 Feb 2020 06:50:21 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id i18sm1244479lfe.15.2020.02.27.06.50.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Feb 2020 06:50:20 -0800 (PST) Subject: Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings To: Julia Lawall , Andrew Morton Cc: kbuild-all@lists.01.org, Linux Memory Management List , "linux-tegra@vger.kernel.org" , Jon Hunter References: From: Dmitry Osipenko Message-ID: Date: Thu, 27 Feb 2020 17:50:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 27.02.2020 13:35, Julia Lawall =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > From: kbuild test robot >=20 > Remove dev_err() messages after platform_get_irq*() failures. > platform_get_irq() already prints an error. >=20 > Generated by: scripts/coccinelle/api/platform_get_irq.cocci >=20 > Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST") > CC: Dmitry Osipenko > Signed-off-by: kbuild test robot > Signed-off-by: Julia Lawall > --- >=20 > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > head: f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8 > commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine:= tegra-apb: Support COMPILE_TEST > :::::: branch date: 17 hours ago > :::::: commit date: 2 days ago >=20 > Please take the patch only if it's a positive warning. Thanks! >=20 > tegra20-apb-dma.c | 1 - > 1 file changed, 1 deletion(-) >=20 > --- a/drivers/dma/tegra20-apb-dma.c > +++ b/drivers/dma/tegra20-apb-dma.c > @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo > irq =3D platform_get_irq(pdev, i); > if (irq < 0) { > ret =3D irq; > - dev_err(&pdev->dev, "No irq resource for chan %d\n", i); > goto err_pm_disable; > } >=20 Reviewed-by: Dmitry Osipenko