Re: [Intel-xe] [PATCH] fixup! drm/xe: Introduce a new DRM driver for Intel GPUs

[Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>]

On 3/16/23 19:29, Lucas De Marchi wrote:
> Introduced with the 6.2 rebase due to
> commit 000458b5966f ("drm: Only select I2C_ALGOBIT for drivers that
> actually need it"). Make a similar selection when CONFIG_DRM_XE_DISPLAY
> is enabled. Also, provide this as a fixup-only commit, to be squashed in
> the next rebase. With this, the following command works again:
>
> 	./tools/testing/kunit/kunit.py build \
> 		--kunitconfig drivers/gpu/drm/xe/.kunitconfig
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Yeah, selecting I2C and I2C_ALGOBIT is something that needs to be done 
on each driver.

Doing such kind of things subsystem-wide doesn't sound right. So, LGTM.

Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

> ---
>   drivers/gpu/drm/xe/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index 4684e99549d3..aeaf3ce19c4f 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -44,6 +44,8 @@ config DRM_XE
>   config DRM_XE_DISPLAY
>   	bool "Enable display support"
>   	depends on DRM_XE && EXPERT
> +	select I2C
> +	select I2C_ALGOBIT
>   	default y
>   	help
>   	  Disable this option only if you want to compile out display support.