From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Date: Mon, 08 Apr 2019 14:30:22 +0200
Subject: [U-Boot] arm: sunxi: Bananapi_M2_Ultra not working with DM_MMC
In-Reply-To: <acdfd617-1427-7bed-c900-0515dbb5e959@centosproject.org>
References: <acdfd617-1427-7bed-c900-0515dbb5e959@centosproject.org>
Message-ID: <b3f14fb9e5ff07b81692ec1c24b6bd9bdc804e88.camel@bootlin.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

Hi,

On Thu, 2019-04-04 at 05:51 -0300, Pablo Sebasti=C3=A1n Greco wrote:
> A few days ago I tried to boot my Bananapi_M2_Ultra with 2019.04rc, I=20
> found that it wasn't booting, 2019.01 was working ok.
> Bisecting indicated that the problem was after=20
> http://git.denx.de/?p=3Du-boot.git;a=3Dcommitdiff;h=3Da7cca5793774ee139b7=
5a704d6efaa4d29f09f93

I think the patch should be reverted ASAP since it obviously breaks
some supported configs. Sadly, the offending commit doesn't say
anything about the test coverage for the change and what the status is
after it. There is probably a reason why it was enabled for sun4i only
before and there must have been a motivation for doing this on all
sunxi platforms, but then again, the commit message says nothing about
those underlying reasons.

I believe we should be more strict on patch review and not let any
change bringing such a major change get applied with a commit message
that provides no context about why the change is okay and how it was
tested.

Cheers,

Paul

> Here's what I see when booting:
>=20
> U-Boot SPL 2019.04-rc4 (Apr 02 2019 - 16:17:43 +0000)
> DRAM: 2048 MiB
> Trying to boot from MMC1
>=20
>=20
> U-Boot 2019.04-rc4 (Apr 02 2019 - 16:17:43 +0000) Allwinner Technology
>=20
> CPU:   Allwinner R40 (SUN8I 1701)
> Model: Banana Pi BPI-M2-Ultra
> I2C:   ready
> DRAM:  2 GiB
> MMC:   Device 'mmc at 1c11000': seq 1 is in use by 'mmc at 1c10000'
> mmc at 1c0f000: 0, mmc at 1c10000: 2, mmc at 1c11000: 1
> Loading Environment from FAT... ** No valid partitions found **
> In:    serial at 1c28000
> Out:   serial at 1c28000
> Err:   serial at 1c28000
> SCSI:  Target spinup took 0 ms.
> AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
> flags: ncq stag pm led clo only pmp pio slum part ccc apst
>=20
> Net:   phy interface7
> eth0: ethernet at 1c50000
> starting USB...
> No controllers found
> Hit any key to stop autoboot:  0
> switch to partitions #0, OK
> mmc0 is current device
> Scanning mmc 0:1...
> switch to partitions #0, OK
> mmc1(part 0) is current device
> ** Invalid partition 1 **
> scanning bus for devices...
> data abort
> pc : [<bff9c6da>]          lr : [<bff98991>]
> reloc pc : [<4a01a6da>]    lr : [<4a016991>]
> sp : bbf5d620  ip : 0000001c     fp : 000000c0
> r10: 00000000  r9 : bbf61ed8     r8 : 00000000
> r7 : bbf5d8a0  r6 : bffdbff0     r5 : bffdbff0  r4 : bffdbff0
> r3 : 00000000  r2 : 00000000     r1 : ea000016  r0 : bffdbff0
> Flags: nZcv  IRQs off  FIQs off  Mode SVC_32
> Code: e92dbd10 f8d045f0 b0858080 1000f8d8 (f8d14604)
> Resetting CPU ...
>=20
> resetting ...
>=20
> Any pointers on what to text next?
>=20
> Thanks.
> Pablo.
>=20
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
--=20
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com