From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75CAEC433E0 for ; Mon, 6 Jul 2020 12:17:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51DA920739 for ; Mon, 6 Jul 2020 12:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594037855; bh=KuxlYi/WPeTd60f/cMp3naUg3QZOGwvNaBWXU66jIVE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=J2o3Zsf8FUFhrH9y51j3Vu4FLBjkgszmu82edlXAQ7Gn/IMBdqR7rUhGWrdO0dRGZ Asdj8sIsQUOiyI9eaCm5TqttA8wSipsvcY4FzY7QlTKIz9m2UAR3k1/E3JWNZtpgCI qHJ71jz2JFhVln0yhmJjQK47j5r7x2T/QQ0db4No= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728938AbgGFMRe (ORCPT ); Mon, 6 Jul 2020 08:17:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:53196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727896AbgGFMRe (ORCPT ); Mon, 6 Jul 2020 08:17:34 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49A3F2070C; Mon, 6 Jul 2020 12:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594037853; bh=KuxlYi/WPeTd60f/cMp3naUg3QZOGwvNaBWXU66jIVE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CgttgXoal5cvnNee8/vDQpHse3xCG5b9UzDhFHkcuTafKGilaGK2bDf0F0nsTECi5 vpQnUWxcleiB4DOEcoQ90TVvF1AYQEUmfZZ9243cL4JvJa3nfLQKAwtpRj1M2ncV/r GU0xUFi+YHrWj9cX8fvPCLkse+RK0KbdaUylhHyE= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jsQ3v-009Rdk-KW; Mon, 06 Jul 2020 13:17:31 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 06 Jul 2020 13:17:31 +0100 From: Marc Zyngier To: Alexandru Elisei Cc: Mark Rutland , kernel-team@android.com, kvm@vger.kernel.org, Suzuki K Poulose , Jintack Lim , Andre Przywara , Christoffer Dall , kvmarm@lists.cs.columbia.edu, George Cherian , James Morse , Andrew Scull , "Zengtao (B)" , Catalin Marinas , Julien Thierry , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/17] KVM: arm64: Factor out stage 2 page table data from struct kvm In-Reply-To: References: <20200615132719.1932408-1-maz@kernel.org> <20200615132719.1932408-2-maz@kernel.org> <17d37bde-2fc8-d165-ee02-7640fc561167@arm.com> <9c0044564885d3356f76b55f35426987@kernel.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, mark.rutland@arm.com, kernel-team@android.com, kvm@vger.kernel.org, suzuki.poulose@arm.com, jintack@cs.columbia.edu, andre.przywara@arm.com, christoffer.dall@arm.com, kvmarm@lists.cs.columbia.edu, gcherian@marvell.com, james.morse@arm.com, ascull@google.com, prime.zeng@hisilicon.com, catalin.marinas@arm.com, julien.thierry.kdev@gmail.com, will@kernel.org, Dave.Martin@arm.com, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2020-06-25 13:19, Alexandru Elisei wrote: > Hi Marc, > > On 6/16/20 5:18 PM, Marc Zyngier wrote: >> Hi Alexandru, >> [..] >>>> [..] >>>> >>>>  /** >>>> - * kvm_alloc_stage2_pgd - allocate level-1 table for stage-2 >>>> translation. >>>> - * @kvm:    The KVM struct pointer for the VM. >>>> + * kvm_init_stage2_mmu - Initialise a S2 MMU strucrure >>>> + * @kvm:    The pointer to the KVM structure >>>> + * @mmu:    The pointer to the s2 MMU structure >>>>   * >>>>   * Allocates only the stage-2 HW PGD level table(s) of size defined >>>> by >>>> - * stage2_pgd_size(kvm). >>>> + * stage2_pgd_size(mmu->kvm). >>>>   * >>>>   * Note we don't need locking here as this is only called when the >>>> VM is >>>>   * created, which can only be done once. >>>>   */ >>>> -int kvm_alloc_stage2_pgd(struct kvm *kvm) >>>> +int kvm_init_stage2_mmu(struct kvm *kvm, struct kvm_s2_mmu *mmu) >>>>  { >>>>      phys_addr_t pgd_phys; >>>>      pgd_t *pgd; >>>> +    int cpu; >>>> >>>> -    if (kvm->arch.pgd != NULL) { >>>> +    if (mmu->pgd != NULL) { >>>>          kvm_err("kvm_arch already initialized?\n"); >>>>          return -EINVAL; >>>>      } >>>> @@ -1024,8 +1040,20 @@ int kvm_alloc_stage2_pgd(struct kvm *kvm) >>>>      if (WARN_ON(pgd_phys & ~kvm_vttbr_baddr_mask(kvm))) >>>>          return -EINVAL; >>> >>> We don't free the pgd if we get the error above, but we do free it >>> below, if >>> allocating last_vcpu_ran fails. Shouldn't we free it in both cases? >> >> Worth investigating. This code gets majorly revamped in the NV series, >> so it is >> likely that I missed something in the middle. > > You didn't miss anything, I checked and it's the same in the upstream > version of KVM. > > kvm_arch_init_vm() returns with an error if this functions fails, so > it's up to > the function to do the clean up. kvm_alloc_pages_exact() returns NULL > on error, so > at this point we have a valid allocation of physical contiguous pages. > Failing to > create a VM is not a fatal error for the system, so I'm thinking that > maybe we > should free those pages for the rest of the system to use. However, > this is a > minor issue, and the patch isn't supposed to make any functional > changes, so it > can be probably be left for another patch and not add more to an > already big series. Cool. Will you be posting such patch? Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD3AAC433DF for ; Mon, 6 Jul 2020 12:17:38 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 3D58D20739 for ; Mon, 6 Jul 2020 12:17:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CgttgXoa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D58D20739 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DAAD34B3E0; Mon, 6 Jul 2020 08:17:37 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B2ocM7AZu2+x; Mon, 6 Jul 2020 08:17:36 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AE5BE4B392; Mon, 6 Jul 2020 08:17:36 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B6A8B4B2B3 for ; Mon, 6 Jul 2020 08:17:35 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SqVtCs9wKi21 for ; Mon, 6 Jul 2020 08:17:34 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 7CC144B29A for ; Mon, 6 Jul 2020 08:17:34 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49A3F2070C; Mon, 6 Jul 2020 12:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594037853; bh=KuxlYi/WPeTd60f/cMp3naUg3QZOGwvNaBWXU66jIVE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CgttgXoal5cvnNee8/vDQpHse3xCG5b9UzDhFHkcuTafKGilaGK2bDf0F0nsTECi5 vpQnUWxcleiB4DOEcoQ90TVvF1AYQEUmfZZ9243cL4JvJa3nfLQKAwtpRj1M2ncV/r GU0xUFi+YHrWj9cX8fvPCLkse+RK0KbdaUylhHyE= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jsQ3v-009Rdk-KW; Mon, 06 Jul 2020 13:17:31 +0100 MIME-Version: 1.0 Date: Mon, 06 Jul 2020 13:17:31 +0100 From: Marc Zyngier To: Alexandru Elisei Subject: Re: [PATCH v2 01/17] KVM: arm64: Factor out stage 2 page table data from struct kvm In-Reply-To: References: <20200615132719.1932408-1-maz@kernel.org> <20200615132719.1932408-2-maz@kernel.org> <17d37bde-2fc8-d165-ee02-7640fc561167@arm.com> <9c0044564885d3356f76b55f35426987@kernel.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, mark.rutland@arm.com, kernel-team@android.com, kvm@vger.kernel.org, suzuki.poulose@arm.com, jintack@cs.columbia.edu, andre.przywara@arm.com, christoffer.dall@arm.com, kvmarm@lists.cs.columbia.edu, gcherian@marvell.com, james.morse@arm.com, ascull@google.com, prime.zeng@hisilicon.com, catalin.marinas@arm.com, julien.thierry.kdev@gmail.com, will@kernel.org, Dave.Martin@arm.com, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andre Przywara , kvmarm@lists.cs.columbia.edu, Will Deacon , George Cherian , "Zengtao \(B\)" , Catalin Marinas , kernel-team@android.com, Dave Martin X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMjAyMC0wNi0yNSAxMzoxOSwgQWxleGFuZHJ1IEVsaXNlaSB3cm90ZToKPiBIaSBNYXJjLAo+ IAo+IE9uIDYvMTYvMjAgNToxOCBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+PiBIaSBBbGV4YW5k cnUsCj4+IFsuLl0KPj4+PiBbLi5dCj4+Pj4gCj4+Pj4gwqAvKioKPj4+PiAtICoga3ZtX2FsbG9j X3N0YWdlMl9wZ2QgLSBhbGxvY2F0ZSBsZXZlbC0xIHRhYmxlIGZvciBzdGFnZS0yIAo+Pj4+IHRy YW5zbGF0aW9uLgo+Pj4+IC0gKiBAa3ZtOsKgwqDCoCBUaGUgS1ZNIHN0cnVjdCBwb2ludGVyIGZv ciB0aGUgVk0uCj4+Pj4gKyAqIGt2bV9pbml0X3N0YWdlMl9tbXUgLSBJbml0aWFsaXNlIGEgUzIg TU1VIHN0cnVjcnVyZQo+Pj4+ICsgKiBAa3ZtOsKgwqDCoCBUaGUgcG9pbnRlciB0byB0aGUgS1ZN IHN0cnVjdHVyZQo+Pj4+ICsgKiBAbW11OsKgwqDCoCBUaGUgcG9pbnRlciB0byB0aGUgczIgTU1V IHN0cnVjdHVyZQo+Pj4+IMKgICoKPj4+PiDCoCAqIEFsbG9jYXRlcyBvbmx5IHRoZSBzdGFnZS0y IEhXIFBHRCBsZXZlbCB0YWJsZShzKSBvZiBzaXplIGRlZmluZWQgCj4+Pj4gYnkKPj4+PiAtICog c3RhZ2UyX3BnZF9zaXplKGt2bSkuCj4+Pj4gKyAqIHN0YWdlMl9wZ2Rfc2l6ZShtbXUtPmt2bSku Cj4+Pj4gwqAgKgo+Pj4+IMKgICogTm90ZSB3ZSBkb24ndCBuZWVkIGxvY2tpbmcgaGVyZSBhcyB0 aGlzIGlzIG9ubHkgY2FsbGVkIHdoZW4gdGhlIAo+Pj4+IFZNIGlzCj4+Pj4gwqAgKiBjcmVhdGVk LCB3aGljaCBjYW4gb25seSBiZSBkb25lIG9uY2UuCj4+Pj4gwqAgKi8KPj4+PiAtaW50IGt2bV9h bGxvY19zdGFnZTJfcGdkKHN0cnVjdCBrdm0gKmt2bSkKPj4+PiAraW50IGt2bV9pbml0X3N0YWdl Ml9tbXUoc3RydWN0IGt2bSAqa3ZtLCBzdHJ1Y3Qga3ZtX3MyX21tdSAqbW11KQo+Pj4+IMKgewo+ Pj4+IMKgwqDCoMKgIHBoeXNfYWRkcl90IHBnZF9waHlzOwo+Pj4+IMKgwqDCoMKgIHBnZF90ICpw Z2Q7Cj4+Pj4gK8KgwqDCoCBpbnQgY3B1Owo+Pj4+IAo+Pj4+IC3CoMKgwqAgaWYgKGt2bS0+YXJj aC5wZ2QgIT0gTlVMTCkgewo+Pj4+ICvCoMKgwqAgaWYgKG1tdS0+cGdkICE9IE5VTEwpIHsKPj4+ PiDCoMKgwqDCoMKgwqDCoMKgIGt2bV9lcnIoImt2bV9hcmNoIGFscmVhZHkgaW5pdGlhbGl6ZWQ/ XG4iKTsKPj4+PiDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+Pj4+IMKgwqDCoMKg IH0KPj4+PiBAQCAtMTAyNCw4ICsxMDQwLDIwIEBAIGludCBrdm1fYWxsb2Nfc3RhZ2UyX3BnZChz dHJ1Y3Qga3ZtICprdm0pCj4+Pj4gwqDCoMKgwqAgaWYgKFdBUk5fT04ocGdkX3BoeXMgJiB+a3Zt X3Z0dGJyX2JhZGRyX21hc2soa3ZtKSkpCj4+Pj4gwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJ TlZBTDsKPj4+IAo+Pj4gV2UgZG9uJ3QgZnJlZSB0aGUgcGdkIGlmIHdlIGdldCB0aGUgZXJyb3Ig YWJvdmUsIGJ1dCB3ZSBkbyBmcmVlIGl0IAo+Pj4gYmVsb3csIGlmCj4+PiBhbGxvY2F0aW5nIGxh c3RfdmNwdV9yYW4gZmFpbHMuIFNob3VsZG4ndCB3ZSBmcmVlIGl0IGluIGJvdGggY2FzZXM/Cj4+ IAo+PiBXb3J0aCBpbnZlc3RpZ2F0aW5nLiBUaGlzIGNvZGUgZ2V0cyBtYWpvcmx5IHJldmFtcGVk IGluIHRoZSBOViBzZXJpZXMsIAo+PiBzbyBpdCBpcwo+PiBsaWtlbHkgdGhhdCBJIG1pc3NlZCBz b21ldGhpbmcgaW4gdGhlIG1pZGRsZS4KPiAKPiBZb3UgZGlkbid0IG1pc3MgYW55dGhpbmcsIEkg Y2hlY2tlZCBhbmQgaXQncyB0aGUgc2FtZSBpbiB0aGUgdXBzdHJlYW0KPiB2ZXJzaW9uIG9mIEtW TS4KPiAKPiBrdm1fYXJjaF9pbml0X3ZtKCkgcmV0dXJucyB3aXRoIGFuIGVycm9yIGlmIHRoaXMg ZnVuY3Rpb25zIGZhaWxzLCBzbyAKPiBpdCdzIHVwIHRvCj4gdGhlIGZ1bmN0aW9uIHRvIGRvIHRo ZSBjbGVhbiB1cC4ga3ZtX2FsbG9jX3BhZ2VzX2V4YWN0KCkgcmV0dXJucyBOVUxMCj4gb24gZXJy b3IsIHNvCj4gYXQgdGhpcyBwb2ludCB3ZSBoYXZlIGEgdmFsaWQgYWxsb2NhdGlvbiBvZiBwaHlz aWNhbCBjb250aWd1b3VzIHBhZ2VzLgo+IEZhaWxpbmcgdG8KPiBjcmVhdGUgYSBWTSBpcyBub3Qg YSBmYXRhbCBlcnJvciBmb3IgdGhlIHN5c3RlbSwgc28gSSdtIHRoaW5raW5nIHRoYXQgCj4gbWF5 YmUgd2UKPiBzaG91bGQgZnJlZSB0aG9zZSBwYWdlcyBmb3IgdGhlIHJlc3Qgb2YgdGhlIHN5c3Rl bSB0byB1c2UuIEhvd2V2ZXIsIAo+IHRoaXMgaXMgYQo+IG1pbm9yIGlzc3VlLCBhbmQgdGhlIHBh dGNoIGlzbid0IHN1cHBvc2VkIHRvIG1ha2UgYW55IGZ1bmN0aW9uYWwgCj4gY2hhbmdlcywgc28g aXQKPiBjYW4gYmUgcHJvYmFibHkgYmUgbGVmdCBmb3IgYW5vdGhlciBwYXRjaCBhbmQgbm90IGFk ZCBtb3JlIHRvIGFuCj4gYWxyZWFkeSBiaWcgc2VyaWVzLgoKQ29vbC4gV2lsbCB5b3UgYmUgcG9z dGluZyBzdWNoIHBhdGNoPwoKVGhhbmtzLAoKICAgICAgICAgTS4KLS0gCkphenogaXMgbm90IGRl YWQuIEl0IGp1c3Qgc21lbGxzIGZ1bm55Li4uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNv bHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZv L2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA967C433E0 for ; Mon, 6 Jul 2020 12:18:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 756892070C for ; Mon, 6 Jul 2020 12:18:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G3Vq0d6g"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CgttgXoa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 756892070C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0of9sDK4M5KI/ixbyooENlwHiHdn2N+I1HVnzC11EsI=; b=G3Vq0d6gPYT8eyIsf2ako8kwv HeU6ZpD+4iww9/cV+4VkWmChb40Q0Uk2lxZCxxrIcwm22zsli+lRbbTj6Fqp13NXT1Rg8ocL+KDvT wiwXMU0zztzJsnlns98SpOs6VZ7H4dH0n6zVwDX5TUSwmWCgJ7nnUWJU2OK/FUo0lR0va+MhFDUlv 8V9IN9BpVNqpUB+oZHfLM93spzff5MHIuOPMo6CC3fwBEJDPw6AVUrPj0IAlShP8WCk3HVPxg5i1x iSc+yERaEUf609PyCjh+JBJYDr+/eCUQ+iq9xwWbXpSb4sx+hFWpGCDSaPDLa+3UEkRiDOtKc3EFu ZGkG3V5/A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsQ40-0006CW-4H; Mon, 06 Jul 2020 12:17:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsQ3y-0006Bx-5O for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 12:17:34 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49A3F2070C; Mon, 6 Jul 2020 12:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594037853; bh=KuxlYi/WPeTd60f/cMp3naUg3QZOGwvNaBWXU66jIVE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CgttgXoal5cvnNee8/vDQpHse3xCG5b9UzDhFHkcuTafKGilaGK2bDf0F0nsTECi5 vpQnUWxcleiB4DOEcoQ90TVvF1AYQEUmfZZ9243cL4JvJa3nfLQKAwtpRj1M2ncV/r GU0xUFi+YHrWj9cX8fvPCLkse+RK0KbdaUylhHyE= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jsQ3v-009Rdk-KW; Mon, 06 Jul 2020 13:17:31 +0100 MIME-Version: 1.0 Date: Mon, 06 Jul 2020 13:17:31 +0100 From: Marc Zyngier To: Alexandru Elisei Subject: Re: [PATCH v2 01/17] KVM: arm64: Factor out stage 2 page table data from struct kvm In-Reply-To: References: <20200615132719.1932408-1-maz@kernel.org> <20200615132719.1932408-2-maz@kernel.org> <17d37bde-2fc8-d165-ee02-7640fc561167@arm.com> <9c0044564885d3356f76b55f35426987@kernel.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, mark.rutland@arm.com, kernel-team@android.com, kvm@vger.kernel.org, suzuki.poulose@arm.com, jintack@cs.columbia.edu, andre.przywara@arm.com, christoffer.dall@arm.com, kvmarm@lists.cs.columbia.edu, gcherian@marvell.com, james.morse@arm.com, ascull@google.com, prime.zeng@hisilicon.com, catalin.marinas@arm.com, julien.thierry.kdev@gmail.com, will@kernel.org, Dave.Martin@arm.com, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_081734_325879_F220C627 X-CRM114-Status: GOOD ( 21.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kvm@vger.kernel.org, Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, Andre Przywara , Christoffer Dall , kvmarm@lists.cs.columbia.edu, Will Deacon , George Cherian , James Morse , Andrew Scull , "Zengtao \(B\)" , Catalin Marinas , kernel-team@android.com, Jintack Lim , Julien Thierry , Dave Martin Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wNi0yNSAxMzoxOSwgQWxleGFuZHJ1IEVsaXNlaSB3cm90ZToKPiBIaSBNYXJjLAo+ IAo+IE9uIDYvMTYvMjAgNToxOCBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+PiBIaSBBbGV4YW5k cnUsCj4+IFsuLl0KPj4+PiBbLi5dCj4+Pj4gCj4+Pj4gwqAvKioKPj4+PiAtICoga3ZtX2FsbG9j X3N0YWdlMl9wZ2QgLSBhbGxvY2F0ZSBsZXZlbC0xIHRhYmxlIGZvciBzdGFnZS0yIAo+Pj4+IHRy YW5zbGF0aW9uLgo+Pj4+IC0gKiBAa3ZtOsKgwqDCoCBUaGUgS1ZNIHN0cnVjdCBwb2ludGVyIGZv ciB0aGUgVk0uCj4+Pj4gKyAqIGt2bV9pbml0X3N0YWdlMl9tbXUgLSBJbml0aWFsaXNlIGEgUzIg TU1VIHN0cnVjcnVyZQo+Pj4+ICsgKiBAa3ZtOsKgwqDCoCBUaGUgcG9pbnRlciB0byB0aGUgS1ZN IHN0cnVjdHVyZQo+Pj4+ICsgKiBAbW11OsKgwqDCoCBUaGUgcG9pbnRlciB0byB0aGUgczIgTU1V IHN0cnVjdHVyZQo+Pj4+IMKgICoKPj4+PiDCoCAqIEFsbG9jYXRlcyBvbmx5IHRoZSBzdGFnZS0y IEhXIFBHRCBsZXZlbCB0YWJsZShzKSBvZiBzaXplIGRlZmluZWQgCj4+Pj4gYnkKPj4+PiAtICog c3RhZ2UyX3BnZF9zaXplKGt2bSkuCj4+Pj4gKyAqIHN0YWdlMl9wZ2Rfc2l6ZShtbXUtPmt2bSku Cj4+Pj4gwqAgKgo+Pj4+IMKgICogTm90ZSB3ZSBkb24ndCBuZWVkIGxvY2tpbmcgaGVyZSBhcyB0 aGlzIGlzIG9ubHkgY2FsbGVkIHdoZW4gdGhlIAo+Pj4+IFZNIGlzCj4+Pj4gwqAgKiBjcmVhdGVk LCB3aGljaCBjYW4gb25seSBiZSBkb25lIG9uY2UuCj4+Pj4gwqAgKi8KPj4+PiAtaW50IGt2bV9h bGxvY19zdGFnZTJfcGdkKHN0cnVjdCBrdm0gKmt2bSkKPj4+PiAraW50IGt2bV9pbml0X3N0YWdl Ml9tbXUoc3RydWN0IGt2bSAqa3ZtLCBzdHJ1Y3Qga3ZtX3MyX21tdSAqbW11KQo+Pj4+IMKgewo+ Pj4+IMKgwqDCoMKgIHBoeXNfYWRkcl90IHBnZF9waHlzOwo+Pj4+IMKgwqDCoMKgIHBnZF90ICpw Z2Q7Cj4+Pj4gK8KgwqDCoCBpbnQgY3B1Owo+Pj4+IAo+Pj4+IC3CoMKgwqAgaWYgKGt2bS0+YXJj aC5wZ2QgIT0gTlVMTCkgewo+Pj4+ICvCoMKgwqAgaWYgKG1tdS0+cGdkICE9IE5VTEwpIHsKPj4+ PiDCoMKgwqDCoMKgwqDCoMKgIGt2bV9lcnIoImt2bV9hcmNoIGFscmVhZHkgaW5pdGlhbGl6ZWQ/ XG4iKTsKPj4+PiDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+Pj4+IMKgwqDCoMKg IH0KPj4+PiBAQCAtMTAyNCw4ICsxMDQwLDIwIEBAIGludCBrdm1fYWxsb2Nfc3RhZ2UyX3BnZChz dHJ1Y3Qga3ZtICprdm0pCj4+Pj4gwqDCoMKgwqAgaWYgKFdBUk5fT04ocGdkX3BoeXMgJiB+a3Zt X3Z0dGJyX2JhZGRyX21hc2soa3ZtKSkpCj4+Pj4gwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJ TlZBTDsKPj4+IAo+Pj4gV2UgZG9uJ3QgZnJlZSB0aGUgcGdkIGlmIHdlIGdldCB0aGUgZXJyb3Ig YWJvdmUsIGJ1dCB3ZSBkbyBmcmVlIGl0IAo+Pj4gYmVsb3csIGlmCj4+PiBhbGxvY2F0aW5nIGxh c3RfdmNwdV9yYW4gZmFpbHMuIFNob3VsZG4ndCB3ZSBmcmVlIGl0IGluIGJvdGggY2FzZXM/Cj4+ IAo+PiBXb3J0aCBpbnZlc3RpZ2F0aW5nLiBUaGlzIGNvZGUgZ2V0cyBtYWpvcmx5IHJldmFtcGVk IGluIHRoZSBOViBzZXJpZXMsIAo+PiBzbyBpdCBpcwo+PiBsaWtlbHkgdGhhdCBJIG1pc3NlZCBz b21ldGhpbmcgaW4gdGhlIG1pZGRsZS4KPiAKPiBZb3UgZGlkbid0IG1pc3MgYW55dGhpbmcsIEkg Y2hlY2tlZCBhbmQgaXQncyB0aGUgc2FtZSBpbiB0aGUgdXBzdHJlYW0KPiB2ZXJzaW9uIG9mIEtW TS4KPiAKPiBrdm1fYXJjaF9pbml0X3ZtKCkgcmV0dXJucyB3aXRoIGFuIGVycm9yIGlmIHRoaXMg ZnVuY3Rpb25zIGZhaWxzLCBzbyAKPiBpdCdzIHVwIHRvCj4gdGhlIGZ1bmN0aW9uIHRvIGRvIHRo ZSBjbGVhbiB1cC4ga3ZtX2FsbG9jX3BhZ2VzX2V4YWN0KCkgcmV0dXJucyBOVUxMCj4gb24gZXJy b3IsIHNvCj4gYXQgdGhpcyBwb2ludCB3ZSBoYXZlIGEgdmFsaWQgYWxsb2NhdGlvbiBvZiBwaHlz aWNhbCBjb250aWd1b3VzIHBhZ2VzLgo+IEZhaWxpbmcgdG8KPiBjcmVhdGUgYSBWTSBpcyBub3Qg YSBmYXRhbCBlcnJvciBmb3IgdGhlIHN5c3RlbSwgc28gSSdtIHRoaW5raW5nIHRoYXQgCj4gbWF5 YmUgd2UKPiBzaG91bGQgZnJlZSB0aG9zZSBwYWdlcyBmb3IgdGhlIHJlc3Qgb2YgdGhlIHN5c3Rl bSB0byB1c2UuIEhvd2V2ZXIsIAo+IHRoaXMgaXMgYQo+IG1pbm9yIGlzc3VlLCBhbmQgdGhlIHBh dGNoIGlzbid0IHN1cHBvc2VkIHRvIG1ha2UgYW55IGZ1bmN0aW9uYWwgCj4gY2hhbmdlcywgc28g aXQKPiBjYW4gYmUgcHJvYmFibHkgYmUgbGVmdCBmb3IgYW5vdGhlciBwYXRjaCBhbmQgbm90IGFk ZCBtb3JlIHRvIGFuCj4gYWxyZWFkeSBiaWcgc2VyaWVzLgoKQ29vbC4gV2lsbCB5b3UgYmUgcG9z dGluZyBzdWNoIHBhdGNoPwoKVGhhbmtzLAoKICAgICAgICAgTS4KLS0gCkphenogaXMgbm90IGRl YWQuIEl0IGp1c3Qgc21lbGxzIGZ1bm55Li4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==