From: Peter Krefting <peter@softwolves.pp.se>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Junio C Hamano <gitster@pobox.com>,
"Osipov, Michael (IN IT IN)" <michael.osipov@innomotics.com>,
git@vger.kernel.org
Subject: Re: [RFC PATCH] bisect: Honor log.date
Date: Fri, 29 Mar 2024 00:18:17 +0100 [thread overview]
Message-ID: <b3f7c1c7f126a3c0a65f034ed6166d6a@softwolves.pp.se> (raw)
In-Reply-To: <CAPig+cSKbGW57dh13T6p20B_EY_C4K=LiQ3TP59wheMSi4qsQA@mail.gmail.com>
2024-03-28 22:38 skrev Eric Sunshine:
> Nit: The comment doesn't tell the reader anything that the code itself
> isn't already clearly telling the reader, thus the comment is
> redundant and unnecessary. Moreover, the comment is likely to become
> outdated when people adjust the code but forget to update the comment.
> As such, I'd recommend dropping the comment altogether.
Yes, that does make sense. I copied the code for invoking "git show"
from builtin/notes.c, which does have that type of redundant comment.
I'll remove it.
--
\\// Peter - http://www.softwolves.pp.se/
prev parent reply other threads:[~2024-03-28 23:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 11:07 bisect does not respect 'log.date' Osipov, Michael (IN IT IN)
2024-03-13 18:24 ` Junio C Hamano
2024-03-13 19:26 ` Osipov, Michael (IN IT IN)
2024-03-25 20:27 ` Peter Krefting
2024-03-25 21:49 ` Junio C Hamano
2024-03-28 20:53 ` [RFC PATCH] bisect: Honor log.date Peter Krefting
2024-03-28 21:38 ` Eric Sunshine
2024-03-28 23:18 ` Peter Krefting [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3f7c1c7f126a3c0a65f034ed6166d6a@softwolves.pp.se \
--to=peter@softwolves.pp.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michael.osipov@innomotics.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.