From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 17/41] doc: add NXP DPAA PMD documentation
Date: Mon, 18 Sep 2017 15:53:45 +0100
Message-ID: <b3f8fdbf-fd6e-c70e-fc3f-24cd5344793a@intel.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-18-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: hemant.agrawal@nxp.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 9596225A1
 for <dev@dpdk.org>; Mon, 18 Sep 2017 16:53:48 +0200 (CEST)
In-Reply-To: <20170909112132.13936-18-shreyansh.jain@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

<...>

> +Config File Options
> +~~~~~~~~~~~~~~~~~~~
> +
> +The following options can be modified in the ``config`` file.
> +Please note that enabling debugging options may affect system performance.
> +
> +- ``CONFIG_RTE_LIBRTE_DPAA_BUS`` (default ``n``)
> +
> +  By default it is enabled only for defconfig_arm64-dpaa-* config.
> +  Toggle compilation of the ``librte_bus_dpaa`` driver.
> +
> +- ``CONFIG_RTE_LIBRTE_DPAA_PMD`` (default ``n``)
> +
> +  By default it is enabled only for defconfig_arm64-dpaa-* config.
> +  Toggle compilation of the ``librte_pmd_dpaa`` driver.
> +
> +- ``CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER`` (default ``n``)
> +
> +  Toggle display of generic debugging messages
> +
> +- ``CONFIG_RTE_LIBRTE_DPAA_DEBUG_INIT`` (default ``n``)
> +
> +  Toggle display of initialization related messages.
> +
> +- ``CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS`` (default ``dpaa``)

There are a few new config missing in documentation.

> +
> +  This is not a DPAA specific configuration - it is a generic RTE config.
> +  For optimal performance and hardware utilization, it is expected that DPAA
> +  Mempool driver is used for mempools. For that, this configuration needs to
> +  enabled.
> +
> +Environment Variables
> +~~~~~~~~~~~~~~~~~~~~~
> +
> +DPAA drivers uses the following environment variables to configure its
> +state during application initialization:
> +
> +- ``DPAA_NUM_RX_QUEUES`` (default 1)

Why not getting this value as device arg?

<...>