All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: keith.wiles@intel.com
Cc: dpdk-dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 01/10] eal: add shorthand __rte_weak macro
Date: Wed, 3 Oct 2018 17:09:24 +0100	[thread overview]
Message-ID: <b3fbbaef-9596-e39a-084f-d1b4dc2f5749@intel.com> (raw)
In-Reply-To: <20180803140605.43072-1-keith.wiles@intel.com>

On 8/3/2018 3:05 PM, keith.wiles at intel.com (Keith Wiles) wrote:
> Signed-off-by: Keith Wiles <keith.wiles at intel.com>
> ---
>  lib/librte_eal/common/include/rte_common.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h
> index 069c13ec7..2c4535b1a 100644
> --- a/lib/librte_eal/common/include/rte_common.h
> +++ b/lib/librte_eal/common/include/rte_common.h
> @@ -68,6 +68,11 @@ typedef uint16_t unaligned_uint16_t;
>  /******* Macro to mark functions and fields scheduled for removal *****/
>  #define __rte_deprecated	__attribute__((__deprecated__))
>  
> +/**
> + * short definition to mark a function or variable to a weak reference.
> + */
> +#define __rte_weak		__attribute__((__weak__))

Looks good to me.
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Since the change is all mechanical same change in further patches, what do you
think merging this patchset into single patch?

  parent reply	other threads:[~2018-10-03 16:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03 14:05 [PATCH 01/10] eal: add shorthand __rte_weak macro Keith Wiles
2018-08-03 14:05 ` [PATCH 02/10] qat: update code to use " Keith Wiles
2018-08-29  9:27   ` Jozwiak, TomaszX
2018-08-03 14:05 ` [PATCH 03/10] avf: " Keith Wiles
2018-08-03 14:05 ` [PATCH 04/10] fm10k: " Keith Wiles
2018-08-03 14:06 ` [PATCH 05/10] i40e: " Keith Wiles
2018-08-03 14:06 ` [PATCH 06/10] ixgbe: " Keith Wiles
2018-08-03 14:06 ` [PATCH 07/10] mlx5: " Keith Wiles
2018-08-03 17:32   ` Yongseok Koh
2018-08-03 14:06 ` [PATCH 08/10] virtio: " Keith Wiles
2018-08-03 14:06 ` [PATCH 09/10] acl: " Keith Wiles
2018-08-03 14:06 ` [PATCH 10/10] bpf: " Keith Wiles
2018-10-03 16:09 ` Ferruh Yigit [this message]
2018-10-05 14:11   ` [PATCH 01/10] eal: add shorthand " Wiles, Keith
2018-10-05 14:48     ` [PATCH v2] add shorthand support for " Keith Wiles
2018-10-24 23:59       ` Thomas Monjalon
2018-10-05 14:49     ` [PATCH 01/10] eal: add shorthand " Wiles, Keith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3fbbaef-9596-e39a-084f-d1b4dc2f5749@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=keith.wiles@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.