Re: [PATCH] multipath-tools: use internal drd.h file

[Bart Van Assche <bart.vanassche@sandisk.com>]

On 10/08/2016 01:22 PM, Xose Vazquez Perez wrote:
> Cc: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/debug.c | 2 +-
>  multipathd/main.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libmultipath/debug.c b/libmultipath/debug.c
> index 295136c..fbe171a 100644
> --- a/libmultipath/debug.c
> +++ b/libmultipath/debug.c
> @@ -8,7 +8,7 @@
>  #include "log_pthread.h"
>  #include <sys/types.h>
>  #include <time.h>
> -#include <../third-party/valgrind/drd.h>
> +#include "../third-party/valgrind/drd.h"
>  #include "vector.h"
>  #include "config.h"
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index cdfafe8..0998085 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -23,7 +23,6 @@
>  #endif
>  #include <semaphore.h>
>  #include <time.h>
> -#include <valgrind/drd.h>
>
>  /*
>   * libmultipath
> @@ -85,6 +84,7 @@ int uxsock_timeout;
>  #include "lock.h"
>  #include "waiter.h"
>  #include "wwids.h"
> +#include "../third-party/valgrind/drd.h"
>
>  #define FILE_NAME_SIZE 256
>  #define CMDSIZE 160

Hello Xose,

The patch description is slightly misleading. I don't think anyone has a 
/usr/third-party directory on her or his system so #include 
<../third-party/valgrind/drd.h> will select the internal drd.h header 
file. However, that first change improves consistency:

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>