From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BA40C282DA for ; Fri, 19 Apr 2019 19:19:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E23B920821 for ; Fri, 19 Apr 2019 19:19:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="Tnyw5l2G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727294AbfDSTTN (ORCPT ); Fri, 19 Apr 2019 15:19:13 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:35813 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbfDSTTN (ORCPT ); Fri, 19 Apr 2019 15:19:13 -0400 Received: by mail-wr1-f67.google.com with SMTP id o12so4661707wrn.2 for ; Fri, 19 Apr 2019 12:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=fmzDKdggHVvoBYy3ZqTGnbD81DZ6jtK/+JPQJybP98Y=; b=Tnyw5l2GXVwxWG5JAeu68G8Yk1LaW/0WzeuSp6zlDsZ1BzvwSSLqTzrMJNV0K0JLRP Nbn2GcHkKgTxctQRnatL0BIdWq9wm7r/SCGXxmokznmEe0nCAEG8JQr+x1H3vi5ik3A8 IH+J1wTF/pb/kinCHOUx1g1VRVSPyhOWBH4Eg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fmzDKdggHVvoBYy3ZqTGnbD81DZ6jtK/+JPQJybP98Y=; b=iVfonJY52jEZmNKoO5HhyB2mYQq/kJKjRUSFZcXZia6uTB8DmGzYFJEhOCnN5dbJIf CNChGeipo8g7i6x350xfD5/YA5T+33DMVtsNhbqrGExEEz/RUh9xfR5JraNugHRAykBm xLC2AudpdpyhjyNjyl9a6gLfzrOHAy/zL1ZgrNvMlEZvl7/JiiqYxW7o0tUZ8j9aAu32 oWMan0blNO0ixLuQQYLBwXesbIzKy74xvZJF13+Wifq0Mx2Zrd9NaOOMH9OUAgxmVXik JM1A6ZGWAnuOy1CGPbgl7wjV9aa1WgXIktlcqBg5KEZWw5UJmf9KInFv4U1N2be0rdPc 41WA== X-Gm-Message-State: APjAAAW3pcBmiaRkHRE9SBVymMgk7kMuxcG2HBCybxxSJoV1E9OOekmA ybHHVjr+io9PVuXnFy1rQKvhe+vW8pg= X-Google-Smtp-Source: APXvYqz8RvLcSyQ7DgM8P58BmYEmGHMj5a1XgWLdzqLQU6uRo+lloYngFTRHDcC5noziYkVx2gj83w== X-Received: by 2002:adf:c7c8:: with SMTP id y8mr2862971wrg.149.1555674685870; Fri, 19 Apr 2019 04:51:25 -0700 (PDT) Received: from [192.168.51.243] ([93.152.141.58]) by smtp.gmail.com with ESMTPSA id e16sm5862837wrs.0.2019.04.19.04.51.24 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 04:51:24 -0700 (PDT) Subject: Re: [PATCH net-next v3 1/5] vlan: support binding link state to vlan member bridge ports To: Mike Manning , netdev@vger.kernel.org, roopa@cumulusnetworks.com References: <20190418173535.22925-1-mmanning@vyatta.att-mail.com> <20190418173535.22925-2-mmanning@vyatta.att-mail.com> From: Nikolay Aleksandrov Message-ID: Date: Fri, 19 Apr 2019 14:51:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418173535.22925-2-mmanning@vyatta.att-mail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/04/2019 20:35, Mike Manning wrote: > In the case of vlan filtering on bridges, the bridge may also have the > corresponding vlan devices as upper devices. Currently the link state > of vlan devices is transferred from the lower device. So this is up if > the bridge is in admin up state and there is at least one bridge port > that is up, regardless of the vlan that the port is a member of. > > The link state of the vlan device may need to track only the state of > the subset of ports that are also members of the corresponding vlan, > rather than that of all ports. > > Add a flag to specify a vlan bridge binding mode, by which the link > state is no longer automatically transferred from the lower device, > but is instead determined by the bridge ports that are members of the > vlan. > > Signed-off-by: Mike Manning > --- > include/uapi/linux/if_vlan.h | 9 +++++---- > net/8021q/vlan_dev.c | 3 ++- > net/8021q/vlan_netlink.c | 3 ++- > 3 files changed, 9 insertions(+), 6 deletions(-) > Acked-by: Nikolay Aleksandrov