From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 611FCC433EF for ; Tue, 22 Mar 2022 06:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236867AbiCVGL0 (ORCPT ); Tue, 22 Mar 2022 02:11:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbiCVGLX (ORCPT ); Tue, 22 Mar 2022 02:11:23 -0400 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F289DBAC; Mon, 21 Mar 2022 23:09:55 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R581e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0V7uMwUf_1647929391; Received: from 30.240.116.16(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0V7uMwUf_1647929391) by smtp.aliyun-inc.com(127.0.0.1); Tue, 22 Mar 2022 14:09:52 +0800 Message-ID: Date: Tue, 22 Mar 2022 14:09:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v7 0/3] EDAC/ghes: refactor memory error reporting to avoid code duplication Content-Language: en-US To: bp@alien8.de, rric@kernel.org Cc: mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, ardb@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, zhangliguang@linux.alibaba.com, zhuo.song@linux.alibaba.com References: <20211210134019.28536-1-xueshuai@linux.alibaba.com> <20220308144053.49090-1-xueshuai@linux.alibaba.com> From: Shuai Xue In-Reply-To: <20220308144053.49090-1-xueshuai@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gentle ping. 在 2022/3/8 PM10:40, Shuai Xue 写道: > ghes_edac_report_mem_error() in ghes_edac.c is a Long Method and have > Duplicated Code with cper_mem_err_location(), cper_dimm_err_location(), and > cper_mem_err_type_str() in drivers/firmware/efi/cper.c. In addition, the > cper_print_mem() in drivers/firmware/efi/cper.c only reports the error > status and misses its description. > > This patch set is to refactor ghes_edac_report_mem_error with: > > - Patch 01 is to wrap up error status decoding logics and reuse it in > cper_print_mem(). > - Patch 02 is to introduces cper_*(), into ghes_edac_report_mem_error(), > this can avoid bunch of duplicate code lines; > - Patch 03 is to improve report format > > Changes since v6: > - Rework patch 02 by Borislav Petkov > - add patch 03 to improve format > - Link: https://lore.kernel.org/r/20220303122626.99740-3-xueshuai@linux.alibaba.com > > Changes since v5: > - Delete change summary in commit log > - Link: https://lore.kernel.org/all/20220126081702.55167-1-xueshuai@linux.alibaba.com/ > - Thanks Borislav Petkov for review comments. > > Changes since v4: > - Fix alignment and format problem > - Link: https://lore.kernel.org/all/20220125024939.30635-1-xueshuai@linux.alibaba.com/ > > Changes since v3: > > - make cper_mem_err_status_str table a lot more compact > - Fix alignment and format problem > - Link: https://lore.kernel.org/all/20220124024759.19176-1-xueshuai@linux.alibaba.com/ > > Changes since v2: > > - delete the unified patch > - adjusted the order of patches > - Link: https://lore.kernel.org/all/20211210134019.28536-1-xueshuai@linux.alibaba.com/ > > Changes since v1: > > - add a new patch to unify ghes and cper before removing duplication. > - document the changes in patch description > - add EXPORT_SYMBOL_GPL()s for cper_*() > - document and the dependency and add UEFI_CPER dependency explicitly > - Link: https://lore.kernel.org/all/20211207031905.61906-2-xueshuai@linux.alibaba.com/ > > Shuai Xue (3): > efi/cper: add cper_mem_err_status_str to decode error description > EDAC/ghes: Unify CPER memory error location reporting > efi/cper: reformat CPER memory error location to more readable > > drivers/edac/Kconfig | 1 + > drivers/edac/ghes_edac.c | 200 +++++++----------------------------- > drivers/firmware/efi/cper.c | 64 ++++++++---- > include/linux/cper.h | 3 + > 4 files changed, 87 insertions(+), 181 deletions(-)