All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: "Yu, Mingli" <mingli.yu@windriver.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] systemd: use the absolute path in service file
Date: Thu, 07 Jan 2021 11:29:36 +0000	[thread overview]
Message-ID: <b4307af4a02b5d302e06ed776cab0cf84d5ced30.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210107095630.32609-1-mingli.yu@windriver.com>

On Thu, 2021-01-07 at 17:56 +0800, Yu, Mingli wrote:
> From: Mingli Yu <mingli.yu@windriver.com>
> 
> Fixes:
>  # systemd-analyze --man=false verify /lib/systemd/system/systemd-kexec.service
>  systemd-kexec.service: Command systemctl is not executable: No such file or directory
> 
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
>  .../0001-service-use-the-abosolute-path.patch | 253 ++++++++++++++++++
>  meta/recipes-core/systemd/systemd_247.2.bb    |   5 +
>  2 files changed, 258 insertions(+)
>  create mode 100644 meta/recipes-core/systemd/systemd/0001-service-use-the-abosolute-path.patch
> 
> diff --git a/meta/recipes-core/systemd/systemd/0001-service-use-the-abosolute-path.patch b/meta/recipes-core/systemd/systemd/0001-service-use-the-abosolute-path.patch
> new file mode 100644
> index 0000000000..dc8e8b3052
> --- /dev/null
> +++ b/meta/recipes-core/systemd/systemd/0001-service-use-the-abosolute-path.patch
> @@ -0,0 +1,253 @@
> +From 98a60faaca7f1a6b753f73556705cc68aa19e383 Mon Sep 17 00:00:00 2001
> +From: Mingli Yu <mingli.yu@windriver.com>
> +Date: Thu, 7 Jan 2021 06:40:29 +0000
> +Subject: [PATCH] service: use the abosolute path
> +
> +Fixes:
> + # systemd-analyze --man=false verify /lib/systemd/system/systemd-kexec.service
> + systemd-kexec.service: Command systemctl is not executable: No such file or directory
> +
> +Upstream-Status: Inappropriate [OE specific]

At the very least you need to explain why this is OE specific and
doesn't affect upstream. I strongly suspect there is a different issue
at work here and it should be fixed differently.

Cheers,

Richard


  reply	other threads:[~2021-01-07 11:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07  9:56 [PATCH] systemd: use the absolute path in service file Yu, Mingli
2021-01-07 11:29 ` Richard Purdie [this message]
2021-01-08  8:40   ` [OE-core] " Yu, Mingli
2021-01-08  8:52     ` Richard Purdie
2021-01-12  7:42       ` Yu, Mingli
2021-01-12  9:29         ` Richard Purdie
2021-01-21  7:44           ` [PATCH v3] systemd: resolve executable path if it is relative Yu, Mingli
2021-01-08  8:43   ` [PATCH v2] systemd: use the absolute path in service file Yu, Mingli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4307af4a02b5d302e06ed776cab0cf84d5ced30.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=mingli.yu@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.