From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 403A8C433F5 for ; Fri, 5 Nov 2021 04:12:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F76E611EF for ; Fri, 5 Nov 2021 04:12:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230367AbhKEEOr (ORCPT ); Fri, 5 Nov 2021 00:14:47 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:44848 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229884AbhKEEOp (ORCPT ); Fri, 5 Nov 2021 00:14:45 -0400 X-UUID: 9c2cbe9fa3dd4117bb2ca022e041268b-20211105 X-UUID: 9c2cbe9fa3dd4117bb2ca022e041268b-20211105 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 105411032; Fri, 05 Nov 2021 12:11:56 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Nov 2021 12:11:56 +0800 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Nov 2021 12:11:55 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs10n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 5 Nov 2021 12:11:55 +0800 Message-ID: Subject: Re: [PATCH 3/4] ASoC: mediatek: mt8195: separate the common code from machine driver From: Trevor Wu To: Mark Brown CC: , , , , , , , , , Date: Fri, 5 Nov 2021 12:11:55 +0800 In-Reply-To: References: <20211103100040.11933-1-trevor.wu@mediatek.com> <20211103100040.11933-4-trevor.wu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-11-04 at 15:39 +0000, Mark Brown wrote: > On Wed, Nov 03, 2021 at 06:00:39PM +0800, Trevor Wu wrote: > > Because we will add DSP support, an new machine driver for the same > > board is required. BE and codec configuration will use the same > > code > > when machine driver is designed for the same board. > > I don't follow why the DSP support requires a new driver? Shouldn't > all > systems with the DSP present be using it? We need to keep the solution without DSP, so we can replace DSP solution with non-DSP when it's required. But when we introduce SOF for DSP control, there will be more routes in machine driver and device tree usage is different from the original. So it's hard to share the same driver for these two solutions. Thanks, Trevor > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C3EFC433EF for ; Fri, 5 Nov 2021 04:12:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E99126120D for ; Fri, 5 Nov 2021 04:12:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E99126120D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x8mgfGCqccdac6YO+aErwWaj0h7li8aoPQM/21gZrjg=; b=mP2bnL82hNUr3P pMwBpVtQcIA8i3hgKFhdLBZKN1/uXtGtWMNt0F/xT5lE/gRLcl7XEY7DCiDxniHkfl+TQIdwfQdBq GAHghSryJc89J9eM6SnKFLemNbqJgdQO2QdRO/yfG9Y9HJglYuDRuUHZHafyhDbt9QgtalGKFt2mj maMU6I6RwIxXvP/o6BJcPWrlBuvQsmzUZQNdliyG5HhyP+mykraPWXt1T5gedZyi1F3AOxJ2Xvwe7 lbNlCtgSHIsFJreZaRQu6BC89JS6RjMS3XbobIkwFN1kzfikcqClY1IZxZxeL0pC0XoQSIQ5Q/WWo 2LjfHEvX7TmpA4dBNY2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miqaX-00AYzo-TD; Fri, 05 Nov 2021 04:12:25 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1miqaI-00AYvO-OC; Fri, 05 Nov 2021 04:12:13 +0000 X-UUID: bc17709e0bd14bc9bcb20d785e60e043-20211104 X-UUID: bc17709e0bd14bc9bcb20d785e60e043-20211104 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 868305624; Thu, 04 Nov 2021 21:12:05 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Nov 2021 21:12:03 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Nov 2021 12:11:55 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs10n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 5 Nov 2021 12:11:55 +0800 Message-ID: Subject: Re: [PATCH 3/4] ASoC: mediatek: mt8195: separate the common code from machine driver From: Trevor Wu To: Mark Brown CC: , , , , , , , , , Date: Fri, 5 Nov 2021 12:11:55 +0800 In-Reply-To: References: <20211103100040.11933-1-trevor.wu@mediatek.com> <20211103100040.11933-4-trevor.wu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211104_211210_831342_F00D86EC X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2021-11-04 at 15:39 +0000, Mark Brown wrote: > On Wed, Nov 03, 2021 at 06:00:39PM +0800, Trevor Wu wrote: > > Because we will add DSP support, an new machine driver for the same > > board is required. BE and codec configuration will use the same > > code > > when machine driver is designed for the same board. > > I don't follow why the DSP support requires a new driver? Shouldn't > all > systems with the DSP present be using it? We need to keep the solution without DSP, so we can replace DSP solution with non-DSP when it's required. But when we introduce SOF for DSP control, there will be more routes in machine driver and device tree usage is different from the original. So it's hard to share the same driver for these two solutions. Thanks, Trevor > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EBEBC433EF for ; Fri, 5 Nov 2021 04:13:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C28E6120D for ; Fri, 5 Nov 2021 04:13:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6C28E6120D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5BD62166F; Fri, 5 Nov 2021 05:12:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5BD62166F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1636085587; bh=Mw1yQ3MWr9K6/+QZmJR5lRUP6el9+0+bCKmu9oaowyc=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PneaGdCBfMTIzJShL9C+j0/DvbT8MgHFjBXVXUDtIVJWjgZJxKHdUbYS0dpP5v6h6 9yHMqWbRjNC/N1W4DZnojZrOetv3YK04JGlynnijR3GUOYWB6ESpWAIIHIowBZYoya DzPDZfYeu/BFSDzf+PAfAFuOlR91c5/6P3xAq9mE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C5273F80269; Fri, 5 Nov 2021 05:12:16 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4AECEF8026A; Fri, 5 Nov 2021 05:12:14 +0100 (CET) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5F459F80148 for ; Fri, 5 Nov 2021 05:12:03 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5F459F80148 X-UUID: 9c2cbe9fa3dd4117bb2ca022e041268b-20211105 X-UUID: 9c2cbe9fa3dd4117bb2ca022e041268b-20211105 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 105411032; Fri, 05 Nov 2021 12:11:56 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Nov 2021 12:11:56 +0800 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Nov 2021 12:11:55 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs10n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 5 Nov 2021 12:11:55 +0800 Message-ID: Subject: Re: [PATCH 3/4] ASoC: mediatek: mt8195: separate the common code from machine driver From: Trevor Wu To: Mark Brown Date: Fri, 5 Nov 2021 12:11:55 +0800 In-Reply-To: References: <20211103100040.11933-1-trevor.wu@mediatek.com> <20211103100040.11933-4-trevor.wu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, yc.hung@mediatek.com, matthias.bgg@gmail.com, daniel.baluta@nxp.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 2021-11-04 at 15:39 +0000, Mark Brown wrote: > On Wed, Nov 03, 2021 at 06:00:39PM +0800, Trevor Wu wrote: > > Because we will add DSP support, an new machine driver for the same > > board is required. BE and codec configuration will use the same > > code > > when machine driver is designed for the same board. > > I don't follow why the DSP support requires a new driver? Shouldn't > all > systems with the DSP present be using it? We need to keep the solution without DSP, so we can replace DSP solution with non-DSP when it's required. But when we introduce SOF for DSP control, there will be more routes in machine driver and device tree usage is different from the original. So it's hard to share the same driver for these two solutions. Thanks, Trevor > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B50EC433F5 for ; Fri, 5 Nov 2021 04:13:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D65B661207 for ; Fri, 5 Nov 2021 04:13:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D65B661207 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kfOpFUlfXbIktnksHxY8eBq3+YjV3Q1AttwbYCUNIXY=; b=1TbWmhQJCzHgEx Xs6TpTussrpgcSH3qnl3tXT+22K8hXdja7haGU3I0eio8jUST2624Im7Bn8sZaxi3hUylrSdZMneR fqsW7fwuP7iEGeUAQtnWWkhG+YXgrOB8XJ4RLNNDMmUT9ixUO1Ckc7v1iS03YjG+EwBybMXUbGYZd 1gzY/0ICj+j5ZF2lnalFZQdKBPtyBrV++FwVK3kssBriQzbjQR4WPV0HEKTV+jx2/17x+yD6yvvXO I025SDsO91CltMGPVMnqsnXjcUdTh8J9lm3+bamv0cmg4+qK43GRzus9tTXmE97bhxPx5Ok/IkX+l /nmgvP+zQDydlyqX/Law==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miqaO-00AYxq-C8; Fri, 05 Nov 2021 04:12:16 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1miqaI-00AYvO-OC; Fri, 05 Nov 2021 04:12:13 +0000 X-UUID: bc17709e0bd14bc9bcb20d785e60e043-20211104 X-UUID: bc17709e0bd14bc9bcb20d785e60e043-20211104 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 868305624; Thu, 04 Nov 2021 21:12:05 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Nov 2021 21:12:03 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Nov 2021 12:11:55 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs10n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 5 Nov 2021 12:11:55 +0800 Message-ID: Subject: Re: [PATCH 3/4] ASoC: mediatek: mt8195: separate the common code from machine driver From: Trevor Wu To: Mark Brown CC: , , , , , , , , , Date: Fri, 5 Nov 2021 12:11:55 +0800 In-Reply-To: References: <20211103100040.11933-1-trevor.wu@mediatek.com> <20211103100040.11933-4-trevor.wu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211104_211210_831342_F00D86EC X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2021-11-04 at 15:39 +0000, Mark Brown wrote: > On Wed, Nov 03, 2021 at 06:00:39PM +0800, Trevor Wu wrote: > > Because we will add DSP support, an new machine driver for the same > > board is required. BE and codec configuration will use the same > > code > > when machine driver is designed for the same board. > > I don't follow why the DSP support requires a new driver? Shouldn't > all > systems with the DSP present be using it? We need to keep the solution without DSP, so we can replace DSP solution with non-DSP when it's required. But when we introduce SOF for DSP control, there will be more routes in machine driver and device tree usage is different from the original. So it's hard to share the same driver for these two solutions. Thanks, Trevor > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel