From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69033C433FE for ; Tue, 21 Sep 2021 07:30:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5336D611BD for ; Tue, 21 Sep 2021 07:30:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbhIUHcB (ORCPT ); Tue, 21 Sep 2021 03:32:01 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:29807 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230160AbhIUHcA (ORCPT ); Tue, 21 Sep 2021 03:32:00 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632209432; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=aqjmP31SDqTSrOPTYMKFyi6cjdtEi8k8K9EsQv1g7o0=; b=FIFVg8ZSJF4wmavn9HgTHYbf97R6c0uz95qOqjzrh+3vAqgxWWPRaEeX1koUrjH1QJkVBTfq 0Dp5Z8HKWPl2vzBHPw6gdPzmnJHWLm9Gl5hbWYFykG1m5VkrBd3HPoai18WQyR5kkGzQvBbs 0prMq7KPOFfk17Wp5jbIjMNgUTA= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 61498a08b585cc7d24befdc8 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 21 Sep 2021 07:30:16 GMT Sender: srivasam=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C10EEC4361B; Tue, 21 Sep 2021 07:30:16 +0000 (UTC) Received: from [192.168.204.90] (unknown [157.48.173.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: srivasam) by smtp.codeaurora.org (Postfix) with ESMTPSA id E164CC43460; Tue, 21 Sep 2021 07:30:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org E164CC43460 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Subject: Re: [PATCH 3/7] ASoC: codecs: tx-macro: Change mic control registers to volatile To: Srinivas Kandagatla , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org Cc: Venkata Prasad Potturu References: <1632123331-2425-1-git-send-email-srivasam@codeaurora.org> <1632123331-2425-4-git-send-email-srivasam@codeaurora.org> From: Srinivasa Rao Mandadapu Organization: Qualcomm India Private Limited. Message-ID: Date: Tue, 21 Sep 2021 13:00:05 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 9/20/2021 6:54 PM, Srinivas Kandagatla wrote: Thanks for your time Srini!! > > On 20/09/2021 08:35, Srinivasa Rao Mandadapu wrote: >> Update amic and dmic related tx macro control registers to volatile >> >> Fixes: c39667ddcfc5 (ASoC: codecs: lpass-tx-macro: add support for >> lpass tx macro) >> >> Signed-off-by: Venkata Prasad Potturu >> Signed-off-by: Srinivasa Rao Mandadapu >> --- >>   sound/soc/codecs/lpass-tx-macro.c | 13 +++++++++++++ >>   1 file changed, 13 insertions(+) >> >> diff --git a/sound/soc/codecs/lpass-tx-macro.c >> b/sound/soc/codecs/lpass-tx-macro.c >> index 9273724..e65b592 100644 >> --- a/sound/soc/codecs/lpass-tx-macro.c >> +++ b/sound/soc/codecs/lpass-tx-macro.c >> @@ -423,6 +423,13 @@ static bool tx_is_volatile_register(struct >> device *dev, unsigned int reg) >>       case CDC_TX_TOP_CSR_SWR_DMIC1_CTL: >>       case CDC_TX_TOP_CSR_SWR_DMIC2_CTL: >>       case CDC_TX_TOP_CSR_SWR_DMIC3_CTL: >> +    case CDC_TX_TOP_CSR_SWR_AMIC0_CTL: >> +    case CDC_TX_TOP_CSR_SWR_AMIC1_CTL: >> +    case CDC_TX_CLK_RST_CTRL_MCLK_CONTROL: >> +    case CDC_TX_CLK_RST_CTRL_FS_CNT_CONTROL: >> +    case CDC_TX_CLK_RST_CTRL_SWR_CONTROL: >> +    case CDC_TX_TOP_CSR_SWR_CTRL: >> +    case CDC_TX0_TX_PATH_SEC7: > > Why are these marked as Volatile? > Can you provide some details on the issue that you are seeing? > > --srini Without volatile these registers are not reflecting in Hardware and playback and capture is not working. Will do recheck and keep only required registers as volatile. > > >>           return true; >>       } >>       return false; >> @@ -1674,6 +1681,12 @@ static int tx_macro_component_probe(struct >> snd_soc_component *comp) >>         snd_soc_component_update_bits(comp, CDC_TX0_TX_PATH_SEC7, 0x3F, >>                         0x0A); >> +    snd_soc_component_update_bits(comp, >> CDC_TX_TOP_CSR_SWR_AMIC0_CTL, 0xFF, 0x00); >> +    snd_soc_component_update_bits(comp, >> CDC_TX_TOP_CSR_SWR_AMIC1_CTL, 0xFF, 0x00); >> +    snd_soc_component_update_bits(comp, >> CDC_TX_TOP_CSR_SWR_DMIC0_CTL, 0xFF, 0x00); >> +    snd_soc_component_update_bits(comp, >> CDC_TX_TOP_CSR_SWR_DMIC1_CTL, 0xFF, 0x00); >> +    snd_soc_component_update_bits(comp, >> CDC_TX_TOP_CSR_SWR_DMIC2_CTL, 0xFF, 0x00); >> +    snd_soc_component_update_bits(comp, >> CDC_TX_TOP_CSR_SWR_DMIC3_CTL, 0xFF, 0x00); >>         return 0; >>   } >> -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.