From: Nikolay Borisov <nborisov@suse.com>
To: Anand Jain <anand.jain@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: fix zstd compression parameter
Date: Wed, 13 Mar 2019 09:19:03 +0200 [thread overview]
Message-ID: <b443c0b4-c8e3-a9cb-9656-2d00b5ce019b@suse.com> (raw)
In-Reply-To: <1552455379-2311-1-git-send-email-anand.jain@oracle.com>
On 13.03.19 г. 7:36 ч., Anand Jain wrote:
> We let to pass zstd compression parameter even if its not fully written.
> For example:
> btrfs prop set /btrfs compression zst
> btrfs prop get /btrfs compression
> compression=zst
>
> zlib and lzo are fine.
>
> Fix it by using the expected number of char in strncmp().
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/props.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/props.c b/fs/btrfs/props.c
> index 8577ea1d4e2b..ef6502a94712 100644
> --- a/fs/btrfs/props.c
> +++ b/fs/btrfs/props.c
> @@ -306,7 +306,7 @@ static int prop_compression_apply(struct inode *inode, const char *value,
> btrfs_set_fs_incompat(fs_info, COMPRESS_LZO);
> } else if (!strncmp("zlib", value, 4)) {
> type = BTRFS_COMPRESS_ZLIB;
> - } else if (!strncmp("zstd", value, len)) {
> + } else if (!strncmp("zstd", value, 4)) {
> type = BTRFS_COMPRESS_ZSTD;
> btrfs_set_fs_incompat(fs_info, COMPRESS_ZSTD);
> } else {
>
prev parent reply other threads:[~2019-03-13 7:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 5:36 [PATCH 1/2] btrfs: fix zstd compression parameter Anand Jain
2019-03-13 5:36 ` [PATCH 2/2] btrfs: fix vanished compression property after failed set Anand Jain
2019-03-13 7:20 ` Nikolay Borisov
2019-03-13 7:22 ` Nikolay Borisov
2019-03-13 8:49 ` Anand Jain
2019-03-13 17:39 ` David Sterba
2019-03-13 10:33 ` Anand Jain
2019-03-13 10:49 ` Anand Jain
2019-03-13 17:42 ` David Sterba
2019-03-13 17:45 ` David Sterba
2019-03-14 1:40 ` Anand Jain
2019-03-13 7:19 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b443c0b4-c8e3-a9cb-9656-2d00b5ce019b@suse.com \
--to=nborisov@suse.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.