From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38002C07E9B for ; Wed, 21 Jul 2021 08:33:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF31B60232 for ; Wed, 21 Jul 2021 08:33:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF31B60232 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=W1m+AFVwZHMqRDmCSd6HjAVVg7rN6CBVJqjugjVbUAE=; b=e8/8NJbl10YymEjd0Yu7rVnj6H Mjlt3UieNdZGjjNLMb2rcJ3XIqzBEjT7pnzUb+VeGKbLowlbI2TE49Bl8/mAZPi7HRyz6jGWkcsd9 S3PVtZTD2zY74Ww5JkDYBfiaHqUtjI/Zlr0MBUnKuKu385s/ceGX9kdvEKiDJ92WnrZOR77QlYpys F2EBUEXGDNk3TcwK9b2oMqUP8+wrkHlKxN4KfcoY9Kwz62yliB9XECm0E5PLl/OpC1jz20V64H/5s n3dSANnvetp/Aa0ZdxZezDtbcYRMT+bng6cLNA7oSlV8R2MAru4Tpxnqgi785xODbI/KWh62y7pzd j7Nph+7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m67dY-00Eufa-MC; Wed, 21 Jul 2021 08:31:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m67dU-00Euev-RP for linux-arm-kernel@lists.infradead.org; Wed, 21 Jul 2021 08:31:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1E1111FB; Wed, 21 Jul 2021 01:31:20 -0700 (PDT) Received: from [10.57.8.240] (unknown [10.57.8.240]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 290E13F694; Wed, 21 Jul 2021 01:31:19 -0700 (PDT) Subject: Re: [PATCH v2] arm64: SSBS/DIT: print SSBS and DIT bit when printing PSTATE To: Shaokun Zhang , linux-arm-kernel@lists.infradead.org Cc: Lingyan Huang , Catalin Marinas , Will Deacon References: <1626835386-30788-1-git-send-email-zhangshaokun@hisilicon.com> From: Vladimir Murzin Message-ID: Date: Wed, 21 Jul 2021 09:31:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1626835386-30788-1-git-send-email-zhangshaokun@hisilicon.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_013124_992518_1BDCCCFB X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/21/21 3:43 AM, Shaokun Zhang wrote: > From: Lingyan Huang > > The current code to print PSTATE when generating backtraces does not > include SSBS bit and DIT bit, so add this information. > > Cc: Vladimir Murzin > Cc: Catalin Marinas > Cc: Will Deacon > Signed-off-by: Lingyan Huang > Signed-off-by: Shaokun Zhang > --- > ChangeLog: > v1-->v2: > 1. Address Vladimir's comment on update compat_user_mode > > arch/arm64/kernel/process.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > index c8989b999250..3da2ad00fa0c 100644 > --- a/arch/arm64/kernel/process.c > +++ b/arch/arm64/kernel/process.c > @@ -163,7 +163,7 @@ static void print_pstate(struct pt_regs *regs) > u64 pstate = regs->pstate; > > if (compat_user_mode(regs)) { > - printk("pstate: %08llx (%c%c%c%c %c %s %s %c%c%c)\n", > + printk("pstate: %08llx (%c%c%c%c %c %s %s %c%c%c %cPAN %cDIT %cSSBS)\n", > pstate, > pstate & PSR_AA32_N_BIT ? 'N' : 'n', > pstate & PSR_AA32_Z_BIT ? 'Z' : 'z', > @@ -174,12 +174,15 @@ static void print_pstate(struct pt_regs *regs) > pstate & PSR_AA32_E_BIT ? "BE" : "LE", > pstate & PSR_AA32_A_BIT ? 'A' : 'a', > pstate & PSR_AA32_I_BIT ? 'I' : 'i', > - pstate & PSR_AA32_F_BIT ? 'F' : 'f'); > + pstate & PSR_AA32_F_BIT ? 'F' : 'f', > + pstate & PSR_AA32_PAN_BIT ? '+' : '-', Hmm, commit message doesn't mention PAN bit... but I leave it to maintainers. > + pstate & PSR_AA32_DIT_BIT ? '+' : '-', > + pstate & PSR_AA32_SSBS_BIT ? '+' : '-'); > } else { > const char *btype_str = btypes[(pstate & PSR_BTYPE_MASK) >> > PSR_BTYPE_SHIFT]; > > - printk("pstate: %08llx (%c%c%c%c %c%c%c%c %cPAN %cUAO %cTCO BTYPE=%s)\n", > + printk("pstate: %08llx (%c%c%c%c %c%c%c%c %cPAN %cUAO %cTCO %cDIT %cSSBS BTYPE=%s)\n", > pstate, > pstate & PSR_N_BIT ? 'N' : 'n', > pstate & PSR_Z_BIT ? 'Z' : 'z', > @@ -192,6 +195,8 @@ static void print_pstate(struct pt_regs *regs) > pstate & PSR_PAN_BIT ? '+' : '-', > pstate & PSR_UAO_BIT ? '+' : '-', > pstate & PSR_TCO_BIT ? '+' : '-', > + pstate & PSR_DIT_BIT ? '+' : '-', > + pstate & PSR_SSBS_BIT ? '+' : '-', > btype_str); > } > } > FWIW, Reviewed-by: Vladimir Murzin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel