All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH] board: mediatek: disable watchdog on BananaPi R2
Date: Sat, 9 Jan 2021 15:57:45 +0100	[thread overview]
Message-ID: <b46a4f21-c3b4-52e2-f8ee-57f74820c535@denx.de> (raw)
In-Reply-To: <fe7bd303-9a69-cf58-4451-5503d4a476e8@suse.com>

On 09.01.21 03:32, Matthias Brugger wrote:
> On 08/01/2021 08:39, Stefan Roese wrote:
>> On 07.01.21 16:36, matthias.bgg at kernel.org wrote:
>>> From: Matthias Brugger <mbrugger@suse.com>
>>>
>>> Watchdog timeout comes in before we are able to load the
>>> kernel and reset the watchdog. Disable the watchdog late in the boot
>>> process to be able to boot the board.
>>
>> Can't you change the WDT reset timeout instead to a higher value?
>>
> 
> I tried that, but the HW has a max timeout of 15984 ms. Unfortunately that's not
> enough.

Nearly 16 seconds is not enough to boot into Linux so that the Linux
watchdog daemon can take control?

Thanks,
Stefan

> Regards,
> Matthias
> 
>> Thanks,
>> Stefan
>>
>>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>>>
>>> ---
>>>
>>>  ? board/mediatek/mt7623/mt7623_rfb.c | 8 ++++++++
>>>  ? configs/mt7623n_bpir2_defconfig??? | 1 +
>>>  ? 2 files changed, 9 insertions(+)
>>>
>>> diff --git a/board/mediatek/mt7623/mt7623_rfb.c
>>> b/board/mediatek/mt7623/mt7623_rfb.c
>>> index 984e75ccaf..22120be412 100644
>>> --- a/board/mediatek/mt7623/mt7623_rfb.c
>>> +++ b/board/mediatek/mt7623/mt7623_rfb.c
>>> @@ -5,6 +5,7 @@
>>>  ? ? #include <common.h>
>>>  ? #include <mmc.h>
>>> +#include <watchdog.h>
>>>  ? ? DECLARE_GLOBAL_DATA_PTR;
>>>  ? @@ -40,3 +41,10 @@ int mmc_get_env_dev(void)
>>>  ????? return mmc_get_boot_dev();
>>>  ? }
>>>  ? #endif
>>> +
>>> +#ifdef CONFIG_BOARD_LATE_INIT
>>> +int board_late_init(void)
>>> +{
>>> +??? wdt_stop(gd->watchdog_dev);
>>> +}
>>> +#endif
>>> diff --git a/configs/mt7623n_bpir2_defconfig b/configs/mt7623n_bpir2_defconfig
>>> index 9177c17dff..fe0b6259dd 100644
>>> --- a/configs/mt7623n_bpir2_defconfig
>>> +++ b/configs/mt7623n_bpir2_defconfig
>>> @@ -14,6 +14,7 @@ CONFIG_FIT_VERBOSE=y
>>>  ? CONFIG_BOOTDELAY=3
>>>  ? CONFIG_SYS_CONSOLE_IS_IN_ENV=y
>>>  ? CONFIG_DEFAULT_FDT_FILE="mt7623n-bananapi-bpi-r2.dtb"
>>> +CONFIG_BOARD_LATE_INIT=y
>>>  ? # CONFIG_DISPLAY_BOARDINFO is not set
>>>  ? CONFIG_SYS_PROMPT="U-Boot> "
>>>  ? CONFIG_CMD_BOOTMENU=y
>>>
>>
>>
>> Viele Gr??e,
>> Stefan
>>
> 


Viele Gr??e,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de

  reply	other threads:[~2021-01-09 14:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 15:36 [PATCH] board: mediatek: disable watchdog on BananaPi R2 matthias.bgg at kernel.org
2021-01-08  7:39 ` Stefan Roese
2021-01-09  2:32   ` Matthias Brugger
2021-01-09 14:57     ` Stefan Roese [this message]
2021-01-10 18:44       ` Matthias Brugger
2021-01-10 18:55         ` Matthias Brugger
2021-01-11  7:02         ` Stefan Roese
2021-01-11  7:17           ` Heinrich Schuchardt
2021-01-11  7:48             ` Stefan Roese
2021-01-11  8:57               ` Heinrich Schuchardt
2021-01-11 10:24                 ` Aw: " Frank Wunderlich
2021-01-11 10:50                   ` Heinrich Schuchardt
2021-01-11 15:44                 ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b46a4f21-c3b4-52e2-f8ee-57f74820c535@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.