From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE1A0C4332F for ; Wed, 23 Nov 2022 10:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TE6ZSLVjTT9Kbou9g1JTslwJo9i/ny69Jl+9M/gic7c=; b=CQw1wO0komgnod RvIMFlHgnxZS4zWqNlhObnag1byvIu9DAAnZLb9cO+tHm/BtuFHS15W1KdOfBl4MWSgB+s0RK8uki +gfWZq5wt9WDGDks15/U6qLLz/Fj0HnPJ+H4PvGir+cm4kFRgo4fz8cOEGXYL+aCS546FLLnvqLyu 1LUVqnf2+9CzrhEuHfRTpOJl01b4LqjkUUj1q4P3p2ZuyGDyiPuG8vi0LazNOEtA5Lo7uA51ZfdTy xRpK79L7ayzOHi8+Y2aznz3JSmtONb8AisJjT6tX/44Dp+CZTmbmaK3S1J6kWin8ofYEhvmyGYBiD G3znBxZLZWrSKCbphECA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxmur-00GKbs-0f; Wed, 23 Nov 2022 10:23:41 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxmun-00GKWx-FM for linux-arm-kernel@lists.infradead.org; Wed, 23 Nov 2022 10:23:39 +0000 Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AN7WZj9023248; Wed, 23 Nov 2022 11:23:24 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=aRGfu+c5NaAQpXxdGToTual+Y1cMXTMKRyYCCxqaSnA=; b=fBuW5mmsENRNR7Ols/4jy4lj5nI9caW2YRQRtJ7shebyi9f7yzjxJJ2VQqK6r9yFUAS3 EbzlvZJOm+wFfa+gG+TFwboWpP+dNKTYGJy2YjMdnY+otlo9l/e4WLyVeie/rqRzz238 MADGVohZdNQgM4Hd1XBQ0gvbZUHMBptGdOR7eB1JFOSXoa85+4JlM+hFBFGCIgSGvoen 8mBCmHefIIl1pBp3yecQpgoxVTvYDgsEKRImGTjLKq85Hc9YSqaHxOHJmHpgCqkBhnXU u8cNuEFNO98aN2DQi22uKyaNyTzg9BgUbHgf3VOPq9O/rmzPKaCcIEz8ICX5vyOMoVSc qw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3m10c4dr6f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Nov 2022 11:23:24 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8562B100034; Wed, 23 Nov 2022 11:23:18 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 7DF75218CFF; Wed, 23 Nov 2022 11:23:18 +0100 (CET) Received: from [10.48.1.102] (10.48.1.102) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.13; Wed, 23 Nov 2022 11:23:15 +0100 Message-ID: Date: Wed, 23 Nov 2022 11:23:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 4/5] pwm: stm32-lp: Use regmap_clear_bits and regmap_set_bits where applicable To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Thierry Reding , Maxime Coquelin , Alexandre Torgue CC: Mark Brown , , , , References: <20221115111347.3705732-1-u.kleine-koenig@pengutronix.de> <20221115111347.3705732-5-u.kleine-koenig@pengutronix.de> Content-Language: en-US From: Fabrice Gasnier In-Reply-To: <20221115111347.3705732-5-u.kleine-koenig@pengutronix.de> X-Originating-IP: [10.48.1.102] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-23_04,2022-11-23_01,2022-06-22_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221123_022337_996252_06E375CD X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTEvMTUvMjIgMTI6MTMsIFV3ZSBLbGVpbmUtS8O2bmlnIHdyb3RlOgo+IEZvdW5kIHVzaW5n IGNvY2NpbmVsbGUgYW5kIHRoZSBmb2xsb3dpbmcgc2VtYW50aWMgcGF0Y2g6Cj4gCj4gQEAKPiBl eHByZXNzaW9uIG1hcCwgcmVnLCBiaXRzOwo+IEBACj4gCj4gLSByZWdtYXBfdXBkYXRlX2JpdHMo bWFwLCByZWcsIGJpdHMsIGJpdHMpCj4gKyByZWdtYXBfc2V0X2JpdHMobWFwLCByZWcsIGJpdHMp Cj4gCj4gQEAKPiBleHByZXNzaW9uIG1hcCwgcmVnLCBiaXRzOwo+IEBACj4gCj4gLSByZWdtYXBf dXBkYXRlX2JpdHMobWFwLCByZWcsIGJpdHMsIDApCj4gKyByZWdtYXBfY2xlYXJfYml0cyhtYXAs IHJlZywgYml0cykKPiAKPiBTaWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVp bmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+IC0tLQo+ICBkcml2ZXJzL3B3bS9wd20tc3RtMzIt bHAuYyB8IDUgKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wd20vcHdtLXN0bTMyLWxwLmMgYi9k cml2ZXJzL3B3bS9wd20tc3RtMzItbHAuYwo+IGluZGV4IDMxMTVhYmIzZjUyYS4uMjEyYmRjN2Q1 MWVlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcHdtL3B3bS1zdG0zMi1scC5jCj4gKysrIGIvZHJp dmVycy9wd20vcHdtLXN0bTMyLWxwLmMKPiBAQCAtMTQwLDkgKzE0MCw4IEBAIHN0YXRpYyBpbnQg c3RtMzJfcHdtX2xwX2FwcGx5KHN0cnVjdCBwd21fY2hpcCAqY2hpcCwgc3RydWN0IHB3bV9kZXZp Y2UgKnB3bSwKPiAgCj4gIAlpZiAocmVlbmFibGUpIHsKPiAgCQkvKiBTdGFydCBMUCB0aW1lciBp biBjb250aW51b3VzIG1vZGUgKi8KPiAtCQlyZXQgPSByZWdtYXBfdXBkYXRlX2JpdHMocHJpdi0+ cmVnbWFwLCBTVE0zMl9MUFRJTV9DUiwKPiAtCQkJCQkgU1RNMzJfTFBUSU1fQ05UU1RSVCwKPiAt CQkJCQkgU1RNMzJfTFBUSU1fQ05UU1RSVCk7Cj4gKwkJcmV0ID0gcmVnbWFwX3NldF9iaXRzKHBy aXYtPnJlZ21hcCwgU1RNMzJfTFBUSU1fQ1IsCj4gKwkJCQkgICAgICBTVE0zMl9MUFRJTV9DTlRT VFJUKTsKCkhpIFV3ZSwKCk9uZSBtaW5vciBzdWdnZXN0aW9uIGhlcmU6IGNvdWxkIGZpdCBpbnRv IGEgc2luZ2xlIGxpbmUuCgpZb3UgY2FuIGFkZCBteToKVGVzdGVkLWJ5OiBGYWJyaWNlIEdhc25p ZXIgPGZhYnJpY2UuZ2FzbmllckBmb3NzLnN0LmNvbT4KCkJlc3QgUmVnYXJkcywKVGhhbmtzCkZh YnJpY2UKCj4gIAkJaWYgKHJldCkgewo+ICAJCQlyZWdtYXBfd3JpdGUocHJpdi0+cmVnbWFwLCBT VE0zMl9MUFRJTV9DUiwgMCk7Cj4gIAkJCWdvdG8gZXJyOwoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FAEAC4332F for ; Wed, 23 Nov 2022 10:39:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237529AbiKWKj5 (ORCPT ); Wed, 23 Nov 2022 05:39:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237534AbiKWKjZ (ORCPT ); Wed, 23 Nov 2022 05:39:25 -0500 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C9DB12D33 for ; Wed, 23 Nov 2022 02:23:43 -0800 (PST) Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AN7WZj9023248; Wed, 23 Nov 2022 11:23:24 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=aRGfu+c5NaAQpXxdGToTual+Y1cMXTMKRyYCCxqaSnA=; b=fBuW5mmsENRNR7Ols/4jy4lj5nI9caW2YRQRtJ7shebyi9f7yzjxJJ2VQqK6r9yFUAS3 EbzlvZJOm+wFfa+gG+TFwboWpP+dNKTYGJy2YjMdnY+otlo9l/e4WLyVeie/rqRzz238 MADGVohZdNQgM4Hd1XBQ0gvbZUHMBptGdOR7eB1JFOSXoa85+4JlM+hFBFGCIgSGvoen 8mBCmHefIIl1pBp3yecQpgoxVTvYDgsEKRImGTjLKq85Hc9YSqaHxOHJmHpgCqkBhnXU u8cNuEFNO98aN2DQi22uKyaNyTzg9BgUbHgf3VOPq9O/rmzPKaCcIEz8ICX5vyOMoVSc qw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3m10c4dr6f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Nov 2022 11:23:24 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8562B100034; Wed, 23 Nov 2022 11:23:18 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 7DF75218CFF; Wed, 23 Nov 2022 11:23:18 +0100 (CET) Received: from [10.48.1.102] (10.48.1.102) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.13; Wed, 23 Nov 2022 11:23:15 +0100 Message-ID: Date: Wed, 23 Nov 2022 11:23:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 4/5] pwm: stm32-lp: Use regmap_clear_bits and regmap_set_bits where applicable To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Thierry Reding , Maxime Coquelin , Alexandre Torgue CC: Mark Brown , , , , References: <20221115111347.3705732-1-u.kleine-koenig@pengutronix.de> <20221115111347.3705732-5-u.kleine-koenig@pengutronix.de> Content-Language: en-US From: Fabrice Gasnier In-Reply-To: <20221115111347.3705732-5-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.48.1.102] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-23_04,2022-11-23_01,2022-06-22_01 Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On 11/15/22 12:13, Uwe Kleine-König wrote: > Found using coccinelle and the following semantic patch: > > @@ > expression map, reg, bits; > @@ > > - regmap_update_bits(map, reg, bits, bits) > + regmap_set_bits(map, reg, bits) > > @@ > expression map, reg, bits; > @@ > > - regmap_update_bits(map, reg, bits, 0) > + regmap_clear_bits(map, reg, bits) > > Signed-off-by: Uwe Kleine-König > --- > drivers/pwm/pwm-stm32-lp.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-stm32-lp.c b/drivers/pwm/pwm-stm32-lp.c > index 3115abb3f52a..212bdc7d51ee 100644 > --- a/drivers/pwm/pwm-stm32-lp.c > +++ b/drivers/pwm/pwm-stm32-lp.c > @@ -140,9 +140,8 @@ static int stm32_pwm_lp_apply(struct pwm_chip *chip, struct pwm_device *pwm, > > if (reenable) { > /* Start LP timer in continuous mode */ > - ret = regmap_update_bits(priv->regmap, STM32_LPTIM_CR, > - STM32_LPTIM_CNTSTRT, > - STM32_LPTIM_CNTSTRT); > + ret = regmap_set_bits(priv->regmap, STM32_LPTIM_CR, > + STM32_LPTIM_CNTSTRT); Hi Uwe, One minor suggestion here: could fit into a single line. You can add my: Tested-by: Fabrice Gasnier Best Regards, Thanks Fabrice > if (ret) { > regmap_write(priv->regmap, STM32_LPTIM_CR, 0); > goto err;