From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750960AbdE2JDc (ORCPT ); Mon, 29 May 2017 05:03:32 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36068 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbdE2JDb (ORCPT ); Mon, 29 May 2017 05:03:31 -0400 Reply-To: monstr@monstr.eu Subject: Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks To: Nicolai Stange Cc: John Stultz , linux-kernel@vger.kernel.org, Daniel Lezcano References: <20170326134403.16226-1-nicstange@gmail.com> <20170330194528.7047-1-nicstange@gmail.com> From: Michal Simek Message-ID: Date: Mon, 29 May 2017 11:03:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170330194528.7047-1-nicstange@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p1jB10VNhESis3CF0RjvLrclHnUUVxiQx" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --p1jB10VNhESis3CF0RjvLrclHnUUVxiQx Content-Type: multipart/mixed; boundary="SDOwbHMIu2VfGTjdfHo40oaAbMblai2Ci"; protected-headers="v1" From: Michal Simek Reply-To: monstr@monstr.eu To: Nicolai Stange Cc: John Stultz , linux-kernel@vger.kernel.org, Daniel Lezcano Message-ID: Subject: Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks References: <20170326134403.16226-1-nicstange@gmail.com> <20170330194528.7047-1-nicstange@gmail.com> In-Reply-To: <20170330194528.7047-1-nicstange@gmail.com> --SDOwbHMIu2VfGTjdfHo40oaAbMblai2Ci Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 30.3.2017 21:45, Nicolai Stange wrote: > In preparation for making the clockevents core NTP correction aware, > all clockevent device drivers must set ->min_delta_ticks and > ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a > clockevent device's rate is going to change dynamically and thus, the > ratio of ns to ticks ceases to stay invariant. >=20 > Make the microblaze arch's clockevent driver initialize these fields > properly. >=20 > This patch alone doesn't introduce any change in functionality as the > clockevents core still looks exclusively at the (untouched) ->min_delta= _ns > and ->max_delta_ns. As soon as this has changed, a followup patch will > purge the initialization of ->min_delta_ns and ->max_delta_ns from this= > driver. >=20 > Signed-off-by: Nicolai Stange > --- >=20 > Notes: > This prerequisite patch is part of a larger effort to feed NTP > corrections into the clockevent devices' frequencies and thus > avoiding their notion of time to diverge from the system's > one. If you're interested, the current state of the whole series > can be found at [1]. > =20 > If you haven't got any objections and these prerequisites get > merged by 4.12 everywhere, I'll proceed with the remainder of > this series in 4.13. > =20 > Applicable to next-20170324 as well as to John' Stultz tree [2]. > =20 > [1] > git://nicst.de/linux.git cev-freq-adj.v10.fortglx-4.12-time > https://nicst.de/git/?p=3Dlinux.git;a=3Dshortlog;h=3Drefs/heads/c= ev-freq-adj.v10.fortglx-4.12-time > =20 > [2] > https://git.linaro.org/people/john.stultz/linux.git fortglx/4.12/= time >=20 > arch/microblaze/kernel/timer.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/ti= mer.c > index 999066192715..545ccd46edb3 100644 > --- a/arch/microblaze/kernel/timer.c > +++ b/arch/microblaze/kernel/timer.c > @@ -178,8 +178,10 @@ static __init int xilinx_clockevent_init(void) > clockevent_xilinx_timer.shift); > clockevent_xilinx_timer.max_delta_ns =3D > clockevent_delta2ns((u32)~0, &clockevent_xilinx_timer); > + clockevent_xilinx_timer.max_delta_ticks =3D (u32)~0; > clockevent_xilinx_timer.min_delta_ns =3D > clockevent_delta2ns(1, &clockevent_xilinx_timer); > + clockevent_xilinx_timer.min_delta_ticks =3D 1; > clockevent_xilinx_timer.cpumask =3D cpumask_of(0); > clockevents_register_device(&clockevent_xilinx_timer); > =20 >=20 Applied as microblaze: Set ->min_delta_ticks and ->max_delta_ticks for timer With Daniel's ACK. Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs --SDOwbHMIu2VfGTjdfHo40oaAbMblai2Ci-- --p1jB10VNhESis3CF0RjvLrclHnUUVxiQx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEUEARECAAYFAlkr4+AACgkQykllyylKDCHrUgCfbRw+TGZp0ymtxyrToV7s1RFe yJcAl3D2KOViPaxXjfflz662dD38wGQ= =mpEm -----END PGP SIGNATURE----- --p1jB10VNhESis3CF0RjvLrclHnUUVxiQx--