All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Safonov <dima@arista.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
	Dmitry Safonov <0x7f454c46@gmail.com>,
	Iurii Zaikin <yzaikin@google.com>, Jiri Slaby <jslaby@suse.com>,
	Joe Perches <joe@perches.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Vasiliy Khoruzhick <vasilykh@arista.com>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCHv3 2/2] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE
Date: Fri, 6 Mar 2020 14:50:51 +0000	[thread overview]
Message-ID: <b48021b8-f881-49c1-fee6-dfbe0c74bb37@arista.com> (raw)
In-Reply-To: <20200306125531.GA3754466@kroah.com>

On 3/6/20 12:55 PM, Greg Kroah-Hartman wrote:
> On Mon, Mar 02, 2020 at 05:51:35PM +0000, Dmitry Safonov wrote:
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index 69def4a9df00..38a8f3c99579 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -431,6 +431,14 @@ config MAGIC_SYSRQ_SERIAL
>>  	  This option allows you to decide whether you want to enable the
>>  	  magic SysRq key.
>>  
>> +config MAGIC_SYSRQ_SERIAL_SEQUENCE
>> +	string "Char sequence that enables magic SysRq over serial"
>> +	depends on MAGIC_SYSRQ_SERIAL
>> +	default ""
>> +	help
>> +	  Specifies a sequence of characters that can follow BREAK to enable
>> +	  SysRq on a serial console.
> 
> 
> Can you send a follow-on patch that adds some more text here.  Something
> like :
> 	If you do not know what to do, just select an empty string and
> 	the option will not be enabled.
> 
> or something like that to make it more obvious what almost everyone will
> want to do here.

Oh yes, makes sense, will send a patch.

Thanks,
          Dmitry

      reply	other threads:[~2020-03-06 14:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 17:51 [PATCHv3 0/2] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE Dmitry Safonov
2020-03-02 17:51 ` [PATCHv3 1/2] sysctl/sysrq: Remove __sysrq_enabled copy Dmitry Safonov
2020-04-01 12:22   ` Michael Ellerman
2020-04-01 14:41     ` Dmitry Safonov
2020-03-02 17:51 ` [PATCHv3 2/2] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE Dmitry Safonov
2020-03-03  4:31   ` kbuild test robot
2020-03-03  4:31     ` kbuild test robot
2020-03-03 18:06     ` Dmitry Safonov
2020-03-06 12:55   ` Greg Kroah-Hartman
2020-03-06 14:50     ` Dmitry Safonov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b48021b8-f881-49c1-fee6-dfbe0c74bb37@arista.com \
    --to=dima@arista.com \
    --cc=0x7f454c46@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=vasilykh@arista.com \
    --cc=yzaikin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.