From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1147C433F5 for ; Sat, 2 Oct 2021 23:43:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC717619F6 for ; Sat, 2 Oct 2021 23:43:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234242AbhJBXpS (ORCPT ); Sat, 2 Oct 2021 19:45:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234050AbhJBXpR (ORCPT ); Sat, 2 Oct 2021 19:45:17 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E15AC061714 for ; Sat, 2 Oct 2021 16:43:31 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id i24so6105395lfj.13 for ; Sat, 02 Oct 2021 16:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=yFmuyFIbVn7VdGil6arszv4U78PVs7ha5E+FdkUpQro=; b=ryarz8ImKFeJcmktlcnTO+7fpdIL92jAAHDUmxDk4FyVI2Q2KlHrThK1dWbsUJyuRu Dr63+4rouwOERPQkF0wSmPwWAFfC4nMzm9vN+SYd2/N01YuRoajo7vk5qPhKh+16HYzD yM/MN0IIZra43vgnf2N0hELlyLxrC8/1HVZEaFwQCuBSRvniUjX0qVkxdsrZTuH5AuWN 9R3yD3pAcFfBYY7GYYQFmWgl2voLqiQOcryis4htxyr38FJzIdFyh5eHOdECAgQ+ArSa R4zyjDOYQN2g0NYMKgbYFdSlvc2h2V/s6kTrcW9OIabmr2HO/gprdxr5NjpnfiYCQqPL eCMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yFmuyFIbVn7VdGil6arszv4U78PVs7ha5E+FdkUpQro=; b=XrlcVO9ai8L74OPhseyP+71nTDaqkylLNxiTrZ2e7Cr57TdGlP/5qWZKUwFd5lEy0T wsRvkdxoiqaOdl/2+YdOEZ20RbxtGJymukPs/OXGcUL1LLh4PuCBpmcT+eiV2/sLiSxB 8NAptWN9gGBdoQ/fJ2hijn+o8HUSu2ERNb5MBkevM2+rXMQwrAi8pl73K9aXYZbjEJqP 6Ry9e/8CpwiyKVtqN6NnVNjWhVnfES7zpZBNrj6aWd/8TWPDl7pasD4BGrAMyIo7+i9p hJYzcTUNzIXorxyCAu9tB/v3dVf4FNVGTEtM+8Sl3bTFbz7SQGdtexN6uCGZy8SAuAge a4zw== X-Gm-Message-State: AOAM530V8nezUTC76OwiL5H+auMg+5AvFU1OtIGb4dG2exn7z6F7XuDj ClM3gu2pJSjjsQgcl+QkJ8XT2g== X-Google-Smtp-Source: ABdhPJxfVHKTvP/nCvaBBstidOInydHI2Dz7CPdAz5Aetr5aasdgikUG9t+klAJGbROOmvlktYbEtw== X-Received: by 2002:a2e:4a19:: with SMTP id x25mr6292646lja.114.1633218209460; Sat, 02 Oct 2021 16:43:29 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id a16sm1165315lfr.186.2021.10.02.16.43.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Oct 2021 16:43:28 -0700 (PDT) Subject: Re: [V2] drm: msm: adreno: use IS_ERR() instead of null pointer check To: Wang Qing , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Jordan Crouse , Jonathan Marek , Sharat Masetty , Akhil P Oommen , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1604719151-28491-1-git-send-email-wangqing@vivo.com> From: Dmitry Baryshkov Message-ID: Date: Sun, 3 Oct 2021 02:43:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <1604719151-28491-1-git-send-email-wangqing@vivo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 07/11/2020 06:19, Wang Qing wrote: > a6xx_gmu_get_mmio() never return null in case of error, but ERR_PTR(), so > we should use IS_ERR() instead of null pointer check and IS_ERR_OR_NULL(). Not quite. a6xx_gmu_get_mmio() can return NULL, as it uses ioremap() internally. And ioremap returns NULL in case of error. So the proper check should be IS_ERR_OR_NULL(). > > Signed-off-by: Wang Qing > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > index 491fee4..82420f7 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > @@ -492,7 +492,7 @@ static void a6xx_gmu_rpmh_init(struct a6xx_gmu *gmu) > void __iomem *seqptr = a6xx_gmu_get_mmio(pdev, "gmu_pdc_seq"); > uint32_t pdc_address_offset; > > - if (!pdcptr || !seqptr) > + if (IS_ERR(pdcptr) || IS_ERR(seqptr)) > goto err; > > if (adreno_is_a618(adreno_gpu) || adreno_is_a640(adreno_gpu)) > @@ -580,9 +580,9 @@ static void a6xx_gmu_rpmh_init(struct a6xx_gmu *gmu) > wmb(); > > err: > - if (!IS_ERR_OR_NULL(pdcptr)) > + if (!IS_ERR(pdcptr)) > iounmap(pdcptr); > - if (!IS_ERR_OR_NULL(seqptr)) > + if (!IS_ERR(seqptr)) > iounmap(seqptr); > } > > -- With best wishes Dmitry