All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Shravan Kumar Ramani <shravankr@nvidia.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	James Morse <james.morse@arm.com>,
	Robert Richter <rric@kernel.org>,
	linux-edac <linux-edac@vger.kernel.org>
Subject: Re: [PATCH 1/1] EDAC, mellanox: Remove redundant error printing in bluefield_edac_mc_probe()
Date: Tue, 1 Jun 2021 09:15:41 +0800	[thread overview]
Message-ID: <b48a923a-2ae2-c826-fdcb-0f118bdccfc8@huawei.com> (raw)
In-Reply-To: <YLT7JOR3fND5Y3K2@zn.tnic>



On 2021/5/31 23:05, Borislav Petkov wrote:
> On Tue, May 11, 2021 at 08:18:56PM +0800, Zhen Lei wrote:
>> When devm_ioremap_resource() fails, a clear enough error message will be
>> printed by its subfunction __devm_ioremap_resource().
> 
> In every possible failure case or is there a case where an error won't
> be printed and keeping the dev_err() in the driver doesn't hurt at all?

I had sent a patch for the missing case in __devm_ioremap_resource(), but
it seems I was wrong. Please refer to:
https://lkml.org/lkml/2021/5/17/95

> 


      reply	other threads:[~2021-06-01  1:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 12:18 [PATCH 1/1] EDAC, mellanox: Remove redundant error printing in bluefield_edac_mc_probe() Zhen Lei
2021-05-31 15:05 ` Borislav Petkov
2021-06-01  1:15   ` Leizhen (ThunderTown) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b48a923a-2ae2-c826-fdcb-0f118bdccfc8@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rric@kernel.org \
    --cc=shravankr@nvidia.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.