From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89928C2D0E2 for ; Tue, 22 Sep 2020 06:51:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00B03239E5 for ; Tue, 22 Sep 2020 06:51:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00B03239E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cn.fujitsu.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKc8x-0007GC-08 for qemu-devel@archiver.kernel.org; Tue, 22 Sep 2020 02:51:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKc7e-0005w2-7C for qemu-devel@nongnu.org; Tue, 22 Sep 2020 02:49:55 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:37273 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKc7b-00039Y-El for qemu-devel@nongnu.org; Tue, 22 Sep 2020 02:49:53 -0400 X-IronPort-AV: E=Sophos;i="5.77,289,1596470400"; d="scan'208";a="99495201" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 22 Sep 2020 14:49:49 +0800 Received: from G08CNEXMBPEKD04.g08.fujitsu.local (unknown [10.167.33.201]) by cn.fujitsu.com (Postfix) with ESMTP id DE34B48990D3; Tue, 22 Sep 2020 14:49:43 +0800 (CST) Received: from [10.167.226.45] (10.167.226.45) by G08CNEXMBPEKD04.g08.fujitsu.local (10.167.33.201) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Sep 2020 14:49:42 +0800 Subject: Re: [PATCH 1/3] Optimize seq_sorter function for colo-compare To: leirao , , , , , References: <1600485023-263643-1-git-send-email-lei.rao@intel.com> <1600485023-263643-2-git-send-email-lei.rao@intel.com> From: Li Zhijian Message-ID: Date: Tue, 22 Sep 2020 14:49:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1600485023-263643-2-git-send-email-lei.rao@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.167.226.45] X-ClientProxiedBy: G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.203) To G08CNEXMBPEKD04.g08.fujitsu.local (10.167.33.201) X-yoursite-MailScanner-ID: DE34B48990D3.ABCFF X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: lizhijian@cn.fujitsu.com Received-SPF: none client-ip=183.91.158.132; envelope-from=lizhijian@cn.fujitsu.com; helo=heian.cn.fujitsu.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 02:14:59 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/19/20 11:10 AM, leirao wrote: > The seq of tcp has been filled in fill_pkt_tcp_info, it > can be used directly here. > > Signed-off-by: leirao Reviewed-by: Li Zhijian > --- > net/colo-compare.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/net/colo-compare.c b/net/colo-compare.c > index 3a45d64..86980ce 100644 > --- a/net/colo-compare.c > +++ b/net/colo-compare.c > @@ -196,11 +196,7 @@ static void colo_compare_inconsistency_notify(CompareState *s) > > static gint seq_sorter(Packet *a, Packet *b, gpointer data) > { > - struct tcp_hdr *atcp, *btcp; > - > - atcp = (struct tcp_hdr *)(a->transport_header); > - btcp = (struct tcp_hdr *)(b->transport_header); > - return ntohl(atcp->th_seq) - ntohl(btcp->th_seq); > + return a->tcp_seq - b->tcp_seq; > } > > static void fill_pkt_tcp_info(void *data, uint32_t *max_ack)