From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v6] doc: document NIC features Date: Fri, 4 Aug 2017 12:40:43 +0100 Message-ID: References: <20170720092303.97525-1-ferruh.yigit@intel.com> <46961328.cqyKbn3m1e@xps> <628b3af4-6c4e-f262-110d-f899f0422501@intel.com> <1557856.DY0fuUa5Sa@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Olivier Matz To: "Mcnamara, John" , Thomas Monjalon Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 527D42E41 for ; Fri, 4 Aug 2017 13:40:45 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/4/2017 12:11 PM, Mcnamara, John wrote: >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas@monjalon.net] >> Sent: Friday, August 4, 2017 10:32 AM >> To: Yigit, Ferruh >> Cc: dev@dpdk.org; Mcnamara, John ; Olivier Matz >> >> Subject: Re: [dpdk-dev] [PATCH v6] doc: document NIC features >> >> 04/08/2017 10:56, Ferruh Yigit: >>> On 8/3/2017 11:57 PM, Thomas Monjalon wrote: >>>> 01/08/2017 17:23, Ferruh Yigit: >>>>> +:orphan: >>>>> + >>>>> +.. _nic_overview_features: >>>> >>>> Why have you done an orphan page? >>>> I think it should be in doc/guides/nics/overview.rst >>> >>> There is a link from nics/overview.rst to this file. But this file is >>> not in the index and not making it orphan is causing a build warning. >> >> But why creating a new page? >> It could be below the table in overview.rst. > > For me it makes more sense on a separate page. It isn't really overview material. > > However, thinking about it again I think that it should be included in the index > instead of using the :orphan: directive. Maybe after the compilation chapter/page. I will send a new version that has been included into index. Thanks, ferruh > > John >