Re: [OE-core][PATCH v8] expat: Added ptest

From: "Randy MacLeod" <randy.macleod@windriver.com>
To: <oleksandr.s.popovych@globallogic.com>,
	Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: <openembedded-core@lists.openembedded.org>,
	Joshua Watt <JPEW.hacker@gmail.com>
Subject: Re: [OE-core][PATCH v8] expat: Added ptest
Date: Wed, 15 Jul 2020 12:54:06 -0400	[thread overview]
Message-ID: <b4996474-6945-9542-0b73-1eeb1499250c@windriver.com> (raw)
In-Reply-To: <CAKqUGW-3RDNU1SFmy9egAbPv8AEOfGBHWb9o34O0P2TxF3boMA@mail.gmail.com>

On 2020-06-03 8:48 a.m., Oleksandr via lists.openembedded.org wrote:
> Hello Richard, Joshua,
> 
> On Mon, May 11, 2020 at 3:45 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>>
>> ...
>>
>> Thanks, this is definitely getting there. There was only one test
>> failure this time, with meta-mingw:
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/89/builds/1884
>>
>> I've cc'd Joshua in case he has any insights on this.
> 
> I`ve tested my patch with meta-mingw layer on my host and it seems I
> have fixed the current compilation error, with making some changes to
> meta-mingw (by changing "CMAKE_SYSTEM_NAME" variable to "Windows"
> value during toolchain file generation in
> "recipes-core/expat/expat_%.bbappend" file using a
> "recipes-devtools/cmake/cmake_%.bbappend" file as template). However
> this is only part of a solution, because another error appears next to
> it: gdb-cross-canadian that depends on expat now fails to build,
> because it can not find a proper expat library. It seems that expat
> recipe, which was switched to build with CMake in my patch, does not
> generate output library in proper format (it compiles only
> "libexpat.dll.a", when the current version of expat recipe from
> upstream, that uses Autotools, generates both "libexpat.a" and
> "libexpat.dll.a"). This is such an error that I can not figure out how
> to solve it by myself, so I ask for help.

When I was cleaning up my inbox, I noticed this thread had gone idle.

Ugh, I have no idea about Windows, Joshua any ideas?

> 
> Additionally I would like to ask you: How should I send patches now
> when at least two separate patches with similar purposes should be
> sent to different layers (one for [OE-core] and other for
> [meta-mingw])? Should they be connected with some kind of cover-letter
> or is there another option?

I think that if you just CC the maintainers and mention the dependency
in the commit log or wrapper email, then things will work out.

Thanks for continuing to work on this Oleksandr.
Hopefully v9 will work well and be merged.

../Randy

> 
> Thanks for your attention.
> 
> 
> 
> 

-- 
# Randy MacLeod
# Wind River Linux