From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA756C56202 for ; Thu, 12 Nov 2020 19:16:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84B7221D7F for ; Thu, 12 Nov 2020 19:16:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JFNyFw3L" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726732AbgKLTQT (ORCPT ); Thu, 12 Nov 2020 14:16:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726295AbgKLTQS (ORCPT ); Thu, 12 Nov 2020 14:16:18 -0500 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18AE6C0613D1; Thu, 12 Nov 2020 11:16:18 -0800 (PST) Received: by mail-lj1-x241.google.com with SMTP id p12so7512741ljc.9; Thu, 12 Nov 2020 11:16:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jhfgYY14US6m4wxn2OreBeb6CQeVO8DRDGhHQIgAX+o=; b=JFNyFw3LyyoB90fZPGzibsAizgKSOjs+HqVe40YhbRGey2zTAPm90qOBN8X1CJVzoO M3SYYsbwVohly2d/++o0SchoujkkkZR3dQt9ALW0Nr5as8bdsOwP9tSGe6IWLUkjDbLQ 195IBsC4Go1c1FjWE4ifCXQMePRx9EASGLxk3zkSi25VwJ40hSyML0Ad1Owq7P06AL8m dFmcJl1TYbfZeVB79l6ZTjRGThpjEH8gcPMSD2d7MgbQCdIrxVuQr31nNcK/3J9UPz8n C+0AtkGaTIthUSxYky3m4HNI/HHnDyM1MWHC5gE8hZrjpfxfX3nJfxmyVs2Ix2MChWKO Ve6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jhfgYY14US6m4wxn2OreBeb6CQeVO8DRDGhHQIgAX+o=; b=Che0jVDu7B8pE34x8sdEtldRwr4yRFc9htl3oWuEdv5HFYW07SyEBbaUappE26lyq1 +KKTYbSqQT5UWBEyYgw+xV3etiqb8a9RTqbgNHnngJZz7wLvg+UXu4iRgP8Vv71EuYeP DeKQk2cwl2TGcYpdtA5zzwIgYq6hhWk77uWf5lO54sJ5OB1PZhPoj0IohATBBJId8t0J tYHKyB6OofjpvmopZE6RyLVL2YtxCIIQLyCwxRxxCwK67AEd/Lq15OWtt4vy2VV/eKMl vzCMYfU0bAqAxu7m3qO7fxlqxkr8+IDNJQ4uH/v1tzUkGG+HQdT99NJxHx7yUgba4pEZ pHHg== X-Gm-Message-State: AOAM532IXPzQwSn9E/XMsdGNfvsio7CJk8PepONetZi+QtmbgLx/uvx5 DbVq2lY3ms0UnvEvcxYM9U9c9RipKLk= X-Google-Smtp-Source: ABdhPJzE5qPV9KbGM96b/lBJNsGC5IOm8d97RUP9808EMVCjf5Dc6sywu66SXsgtyXC8GPiqUvektg== X-Received: by 2002:a05:651c:95:: with SMTP id 21mr428933ljq.307.1605208576330; Thu, 12 Nov 2020 11:16:16 -0800 (PST) Received: from [192.168.2.145] (109-252-193-159.dynamic.spd-mgts.ru. [109.252.193.159]) by smtp.googlemail.com with ESMTPSA id z19sm721401lfd.128.2020.11.12.11.16.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2020 11:16:15 -0800 (PST) Subject: Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling To: Mark Brown Cc: Thierry Reding , Jonathan Hunter , Alan Stern , Peter Chen , Liam Girdwood , Adrian Hunter , Krzysztof Kozlowski , Greg Kroah-Hartman , Lee Jones , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Ulf Hansson , Mauro Carvalho Chehab , Rob Herring , Marek Szyprowski , Peter Geis , Nicolas Chauvet , linux-samsung-soc@vger.kernel.org, devel@driverdev.osuosl.org, linux-usb@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org References: <20201104234427.26477-1-digetx@gmail.com> <20201104234427.26477-12-digetx@gmail.com> <20201110202945.GF2375022@ulmo> <20201110203257.GC5957@sirena.org.uk> <72ae6462-13df-9fcb-510e-8e57eee0f035@gmail.com> <20201111115534.GA4847@sirena.org.uk> <20201112171600.GD4742@sirena.org.uk> From: Dmitry Osipenko Message-ID: Date: Thu, 12 Nov 2020 22:16:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201112171600.GD4742@sirena.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 12.11.2020 20:16, Mark Brown пишет: > On Thu, Nov 12, 2020 at 07:59:36PM +0300, Dmitry Osipenko wrote: >> 11.11.2020 14:55, Mark Brown пишет: >>> On Wed, Nov 11, 2020 at 12:23:41AM +0300, Dmitry Osipenko wrote: > >>>> I already changed that code to use regulator_get_optional() for v2. > >>> That doesn't look entirely appropriate given that the core does most >>> likely require some kind of power to operate. > >> We will need to do this because older DTBs won't have that regulator and >> we want to keep them working. > >> Also, some device-trees won't have that regulator anyways because board >> schematics isn't available, and thus, we can't fix them. > > This is what dummy supplies are for? But it's not allowed to change voltage of a dummy regulator, is it intentional? >>>> Regarding the enumerating supported voltage.. I think this should be >>>> done by the OPP core, but regulator core doesn't work well if >>>> regulator_get() is invoked more than one time for the same device, at >>>> least there is a loud debugfs warning about an already existing > >>> I don't understand why this would be an issue - if nothing else the core >>> could just offer an interface to trigger the check. > >> It's not an issue, I just described what happens when device driver >> tries to get a regulator twice. > >> There was an issue once that check is added to the regulator core code. >> But perhaps not worth to discuss it for now because I don't remember >> details. > > So there's no known obstacle to putting enumeration of supported > voltages into the OPP core then? I'm a bit confused here. It's an obstacle if both OPP and device driver need to get the same regulator. Like in the case of this DRM driver, which need to control the voltage instead of allowing OPP core to do it. Please notice that devm_tegra_dc_opp_table_init() of this patch doesn't use dev_pm_opp_set_regulators(), which would allow OPP core to filter out unsupported OPPs. But then OPP core will need need to get an already requested regulator and this doesn't work well. >>>> directory for a regulator. It's easy to check whether the debug >>>> directory exists before creating it, like thermal framework does it for >>>> example, but then there were some other more difficult issues.. I don't >>>> recall what they were right now. Perhaps will be easier to simply get a >>>> error from regulator_set_voltage() for now because it shouldn't ever >>>> happen in practice, unless device-tree has wrong constraints. > >>> The constraints might not be wrong, there might be some board which has >>> a constraint somewhere for > >> In this case board's DT shouldn't specify unsupportable OPPs. > > Ah, so each board duplicates the OPP tables then, or there's an > expectation that if there's some limit then they'll copy and modify the > table? If that's the case then it's a bit redundant to do filtering > indeed. I think this is not strictly defined. Either way will work, although perhaps it should be more preferred that unsupported OPPs aren't present in a device-tree. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC2FC55ABD for ; Thu, 12 Nov 2020 19:16:23 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38D4621D7F for ; Thu, 12 Nov 2020 19:16:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JFNyFw3L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38D4621D7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id BC9AB871C3; Thu, 12 Nov 2020 19:16:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QfDP7lpiM4Mr; Thu, 12 Nov 2020 19:16:21 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 54C7D87070; Thu, 12 Nov 2020 19:16:21 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id F1E391BF334 for ; Thu, 12 Nov 2020 19:16:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D1BD420370 for ; Thu, 12 Nov 2020 19:16:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KWyXt-23-TkA for ; Thu, 12 Nov 2020 19:16:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by silver.osuosl.org (Postfix) with ESMTPS id 20D9D2033D for ; Thu, 12 Nov 2020 19:16:18 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id s9so7487686ljo.11 for ; Thu, 12 Nov 2020 11:16:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jhfgYY14US6m4wxn2OreBeb6CQeVO8DRDGhHQIgAX+o=; b=JFNyFw3LyyoB90fZPGzibsAizgKSOjs+HqVe40YhbRGey2zTAPm90qOBN8X1CJVzoO M3SYYsbwVohly2d/++o0SchoujkkkZR3dQt9ALW0Nr5as8bdsOwP9tSGe6IWLUkjDbLQ 195IBsC4Go1c1FjWE4ifCXQMePRx9EASGLxk3zkSi25VwJ40hSyML0Ad1Owq7P06AL8m dFmcJl1TYbfZeVB79l6ZTjRGThpjEH8gcPMSD2d7MgbQCdIrxVuQr31nNcK/3J9UPz8n C+0AtkGaTIthUSxYky3m4HNI/HHnDyM1MWHC5gE8hZrjpfxfX3nJfxmyVs2Ix2MChWKO Ve6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jhfgYY14US6m4wxn2OreBeb6CQeVO8DRDGhHQIgAX+o=; b=JzHhnEHyW/4vTAndSwy3+tdTvSnx54s1HKcbieFqoZ8G42n9o0f8ECrOBDFdqOORKd Zfv1Ax3dvhGqD02eexC3ZclRNoVkzGsyR5uNUKr8IRzM65fPw25CEw3CUtgkxdgpIG8u opuIZudRIsl5XJtFLFk+ezXaat6ykT3pzDg4L1QOTHC2ywtJ+wFEGMICee15PP5u4/uS rK+KLOBvYHY0+rKw+G9sc+srUd5ppLn0IDoS7qhPnUwS5BqlZivmy86K3P3vv1HjqlBf r5PJtCRN7EMAGF0DMIk2xlRlQvtXqjUA9Lvg/RIxBZVIDAzzdUh0f+64ctad0JIXUtql 5RYQ== X-Gm-Message-State: AOAM531bLSTM7tFaT1L+yQOLFQbeSdfXXMDUXYWCGutJayyryyij+UdL rTCvanjYEvkjuLwl34YjjCk= X-Google-Smtp-Source: ABdhPJzE5qPV9KbGM96b/lBJNsGC5IOm8d97RUP9808EMVCjf5Dc6sywu66SXsgtyXC8GPiqUvektg== X-Received: by 2002:a05:651c:95:: with SMTP id 21mr428933ljq.307.1605208576330; Thu, 12 Nov 2020 11:16:16 -0800 (PST) Received: from [192.168.2.145] (109-252-193-159.dynamic.spd-mgts.ru. [109.252.193.159]) by smtp.googlemail.com with ESMTPSA id z19sm721401lfd.128.2020.11.12.11.16.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2020 11:16:15 -0800 (PST) Subject: Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling To: Mark Brown References: <20201104234427.26477-1-digetx@gmail.com> <20201104234427.26477-12-digetx@gmail.com> <20201110202945.GF2375022@ulmo> <20201110203257.GC5957@sirena.org.uk> <72ae6462-13df-9fcb-510e-8e57eee0f035@gmail.com> <20201111115534.GA4847@sirena.org.uk> <20201112171600.GD4742@sirena.org.uk> From: Dmitry Osipenko Message-ID: Date: Thu, 12 Nov 2020 22:16:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201112171600.GD4742@sirena.org.uk> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , Ulf Hansson , Liam Girdwood , dri-devel@lists.freedesktop.org, Adrian Hunter , devicetree@vger.kernel.org, Thierry Reding , Lee Jones , Marek Szyprowski , devel@driverdev.osuosl.org, linux-samsung-soc@vger.kernel.org, Nicolas Chauvet , Krzysztof Kozlowski , Jonathan Hunter , Alan Stern , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" MTIuMTEuMjAyMCAyMDoxNiwgTWFyayBCcm93biDQv9C40YjQtdGCOgo+IE9uIFRodSwgTm92IDEy LCAyMDIwIGF0IDA3OjU5OjM2UE0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPj4gMTEu MTEuMjAyMCAxNDo1NSwgTWFyayBCcm93biDQv9C40YjQtdGCOgo+Pj4gT24gV2VkLCBOb3YgMTEs IDIwMjAgYXQgMTI6MjM6NDFBTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+IAo+Pj4+ IEkgYWxyZWFkeSBjaGFuZ2VkIHRoYXQgY29kZSB0byB1c2UgcmVndWxhdG9yX2dldF9vcHRpb25h bCgpIGZvciB2Mi4KPiAKPj4+IFRoYXQgZG9lc24ndCBsb29rIGVudGlyZWx5IGFwcHJvcHJpYXRl IGdpdmVuIHRoYXQgdGhlIGNvcmUgZG9lcyBtb3N0Cj4+PiBsaWtlbHkgcmVxdWlyZSBzb21lIGtp bmQgb2YgcG93ZXIgdG8gb3BlcmF0ZS4KPiAKPj4gV2Ugd2lsbCBuZWVkIHRvIGRvIHRoaXMgYmVj YXVzZSBvbGRlciBEVEJzIHdvbid0IGhhdmUgdGhhdCByZWd1bGF0b3IgYW5kCj4+IHdlIHdhbnQg dG8ga2VlcCB0aGVtIHdvcmtpbmcuCj4gCj4+IEFsc28sIHNvbWUgZGV2aWNlLXRyZWVzIHdvbid0 IGhhdmUgdGhhdCByZWd1bGF0b3IgYW55d2F5cyBiZWNhdXNlIGJvYXJkCj4+IHNjaGVtYXRpY3Mg aXNuJ3QgYXZhaWxhYmxlLCBhbmQgdGh1cywgd2UgY2FuJ3QgZml4IHRoZW0uCj4gCj4gVGhpcyBp cyB3aGF0IGR1bW15IHN1cHBsaWVzIGFyZSBmb3I/CgpCdXQgaXQncyBub3QgYWxsb3dlZCB0byBj aGFuZ2Ugdm9sdGFnZSBvZiBhIGR1bW15IHJlZ3VsYXRvciwgaXMgaXQKaW50ZW50aW9uYWw/Cgo+ Pj4+IFJlZ2FyZGluZyB0aGUgZW51bWVyYXRpbmcgc3VwcG9ydGVkIHZvbHRhZ2UuLiBJIHRoaW5r IHRoaXMgc2hvdWxkIGJlCj4+Pj4gZG9uZSBieSB0aGUgT1BQIGNvcmUsIGJ1dCByZWd1bGF0b3Ig Y29yZSBkb2Vzbid0IHdvcmsgd2VsbCBpZgo+Pj4+IHJlZ3VsYXRvcl9nZXQoKSBpcyBpbnZva2Vk IG1vcmUgdGhhbiBvbmUgdGltZSBmb3IgdGhlIHNhbWUgZGV2aWNlLCBhdAo+Pj4+IGxlYXN0IHRo ZXJlIGlzIGEgbG91ZCBkZWJ1Z2ZzIHdhcm5pbmcgYWJvdXQgYW4gYWxyZWFkeSBleGlzdGluZwo+ IAo+Pj4gSSBkb24ndCB1bmRlcnN0YW5kIHdoeSB0aGlzIHdvdWxkIGJlIGFuIGlzc3VlIC0gaWYg bm90aGluZyBlbHNlIHRoZSBjb3JlCj4+PiBjb3VsZCBqdXN0IG9mZmVyIGFuIGludGVyZmFjZSB0 byB0cmlnZ2VyIHRoZSBjaGVjay4KPiAKPj4gSXQncyBub3QgYW4gaXNzdWUsIEkganVzdCBkZXNj cmliZWQgd2hhdCBoYXBwZW5zIHdoZW4gZGV2aWNlIGRyaXZlcgo+PiB0cmllcyB0byBnZXQgYSBy ZWd1bGF0b3IgdHdpY2UuCj4gCj4+IFRoZXJlIHdhcyBhbiBpc3N1ZSBvbmNlIHRoYXQgY2hlY2sg aXMgYWRkZWQgdG8gdGhlIHJlZ3VsYXRvciBjb3JlIGNvZGUuCj4+IEJ1dCBwZXJoYXBzIG5vdCB3 b3J0aCB0byBkaXNjdXNzIGl0IGZvciBub3cgYmVjYXVzZSBJIGRvbid0IHJlbWVtYmVyCj4+IGRl dGFpbHMuCj4gCj4gU28gdGhlcmUncyBubyBrbm93biBvYnN0YWNsZSB0byBwdXR0aW5nIGVudW1l cmF0aW9uIG9mIHN1cHBvcnRlZAo+IHZvbHRhZ2VzIGludG8gdGhlIE9QUCBjb3JlIHRoZW4/ICBJ J20gYSBiaXQgY29uZnVzZWQgaGVyZS4KCkl0J3MgYW4gb2JzdGFjbGUgaWYgYm90aCBPUFAgYW5k IGRldmljZSBkcml2ZXIgbmVlZCB0byBnZXQgdGhlIHNhbWUKcmVndWxhdG9yLiBMaWtlIGluIHRo ZSBjYXNlIG9mIHRoaXMgRFJNIGRyaXZlciwgd2hpY2ggbmVlZCB0byBjb250cm9sCnRoZSB2b2x0 YWdlIGluc3RlYWQgb2YgYWxsb3dpbmcgT1BQIGNvcmUgdG8gZG8gaXQuCgpQbGVhc2Ugbm90aWNl IHRoYXQgZGV2bV90ZWdyYV9kY19vcHBfdGFibGVfaW5pdCgpIG9mIHRoaXMgcGF0Y2ggZG9lc24n dAp1c2UgZGV2X3BtX29wcF9zZXRfcmVndWxhdG9ycygpLCB3aGljaCB3b3VsZCBhbGxvdyBPUFAg Y29yZSB0byBmaWx0ZXIKb3V0IHVuc3VwcG9ydGVkIE9QUHMuIEJ1dCB0aGVuIE9QUCBjb3JlIHdp bGwgbmVlZCBuZWVkIHRvIGdldCBhbiBhbHJlYWR5CnJlcXVlc3RlZCByZWd1bGF0b3IgYW5kIHRo aXMgZG9lc24ndCB3b3JrIHdlbGwuCgo+Pj4+IGRpcmVjdG9yeSBmb3IgYSByZWd1bGF0b3IuIEl0 J3MgZWFzeSB0byBjaGVjayB3aGV0aGVyIHRoZSBkZWJ1Zwo+Pj4+IGRpcmVjdG9yeSBleGlzdHMg YmVmb3JlIGNyZWF0aW5nIGl0LCBsaWtlIHRoZXJtYWwgZnJhbWV3b3JrIGRvZXMgaXQgZm9yCj4+ Pj4gZXhhbXBsZSwgYnV0IHRoZW4gdGhlcmUgd2VyZSBzb21lIG90aGVyIG1vcmUgZGlmZmljdWx0 IGlzc3Vlcy4uIEkgZG9uJ3QKPj4+PiByZWNhbGwgd2hhdCB0aGV5IHdlcmUgcmlnaHQgbm93LiBQ ZXJoYXBzIHdpbGwgYmUgZWFzaWVyIHRvIHNpbXBseSBnZXQgYQo+Pj4+IGVycm9yIGZyb20gcmVn dWxhdG9yX3NldF92b2x0YWdlKCkgZm9yIG5vdyBiZWNhdXNlIGl0IHNob3VsZG4ndCBldmVyCj4+ Pj4gaGFwcGVuIGluIHByYWN0aWNlLCB1bmxlc3MgZGV2aWNlLXRyZWUgaGFzIHdyb25nIGNvbnN0 cmFpbnRzLgo+IAo+Pj4gVGhlIGNvbnN0cmFpbnRzIG1pZ2h0IG5vdCBiZSB3cm9uZywgdGhlcmUg bWlnaHQgYmUgc29tZSBib2FyZCB3aGljaCBoYXMKPj4+IGEgY29uc3RyYWludCBzb21ld2hlcmUg Zm9yIAo+IAo+PiBJbiB0aGlzIGNhc2UgYm9hcmQncyBEVCBzaG91bGRuJ3Qgc3BlY2lmeSB1bnN1 cHBvcnRhYmxlIE9QUHMuCj4gCj4gQWgsIHNvIGVhY2ggYm9hcmQgZHVwbGljYXRlcyB0aGUgT1BQ IHRhYmxlcyB0aGVuLCBvciB0aGVyZSdzIGFuCj4gZXhwZWN0YXRpb24gdGhhdCBpZiB0aGVyZSdz IHNvbWUgbGltaXQgdGhlbiB0aGV5J2xsIGNvcHkgYW5kIG1vZGlmeSB0aGUKPiB0YWJsZT8gIElm IHRoYXQncyB0aGUgY2FzZSB0aGVuIGl0J3MgYSBiaXQgcmVkdW5kYW50IHRvIGRvIGZpbHRlcmlu Zwo+IGluZGVlZC4KCkkgdGhpbmsgdGhpcyBpcyBub3Qgc3RyaWN0bHkgZGVmaW5lZC4gRWl0aGVy IHdheSB3aWxsIHdvcmssIGFsdGhvdWdoCnBlcmhhcHMgaXQgc2hvdWxkIGJlIG1vcmUgcHJlZmVy cmVkIHRoYXQgdW5zdXBwb3J0ZWQgT1BQcyBhcmVuJ3QgcHJlc2VudAppbiBhIGRldmljZS10cmVl LgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBt YWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2 LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48AB1C388F7 for ; Fri, 13 Nov 2020 08:38:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEACE217A0 for ; Fri, 13 Nov 2020 08:38:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JFNyFw3L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEACE217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BF4F6E466; Fri, 13 Nov 2020 08:38:28 +0000 (UTC) Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id E34FE6E3BB for ; Thu, 12 Nov 2020 19:16:17 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id y16so7550893ljk.1 for ; Thu, 12 Nov 2020 11:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jhfgYY14US6m4wxn2OreBeb6CQeVO8DRDGhHQIgAX+o=; b=JFNyFw3LyyoB90fZPGzibsAizgKSOjs+HqVe40YhbRGey2zTAPm90qOBN8X1CJVzoO M3SYYsbwVohly2d/++o0SchoujkkkZR3dQt9ALW0Nr5as8bdsOwP9tSGe6IWLUkjDbLQ 195IBsC4Go1c1FjWE4ifCXQMePRx9EASGLxk3zkSi25VwJ40hSyML0Ad1Owq7P06AL8m dFmcJl1TYbfZeVB79l6ZTjRGThpjEH8gcPMSD2d7MgbQCdIrxVuQr31nNcK/3J9UPz8n C+0AtkGaTIthUSxYky3m4HNI/HHnDyM1MWHC5gE8hZrjpfxfX3nJfxmyVs2Ix2MChWKO Ve6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jhfgYY14US6m4wxn2OreBeb6CQeVO8DRDGhHQIgAX+o=; b=NmJepri+5eoXiHDsK6AW4ks07JEl+mXLMW1ykQG9t6gzRVZrmuiCnS8moJwXnTOLXy Kg3r4I3UIWjB9D7JQVu5Vg35KC9BUMJy8ZnbM+LVcIfOnYXFCl0gz6nAksx+wrZ08wSU GOYHchymz3Lez55pJLLiUAaRL6ze7GpLM3SAJB+az5fOlO7+udmT2sFyjBDxyLBOqfTE NU2QQXWokrCy+0ZW1kDFe15YMmgZIxLhjDL6Jv0WJ8mZWNb5I6iEGFImLABKjrJ2CDu2 9V2kHYBbmQrctgc3xZCKOXUBD+BfMWU9TE2YxHS4e6WoikJEFUbg1L+R+6B/iKFCZ0g8 4L2w== X-Gm-Message-State: AOAM532VZwkqg9sYhPY6ZCBlti9xaOph5zW1y2WJrAQhHquBcNuK963+ UiGCcg8XGzvhjbuaQZnub34= X-Google-Smtp-Source: ABdhPJzE5qPV9KbGM96b/lBJNsGC5IOm8d97RUP9808EMVCjf5Dc6sywu66SXsgtyXC8GPiqUvektg== X-Received: by 2002:a05:651c:95:: with SMTP id 21mr428933ljq.307.1605208576330; Thu, 12 Nov 2020 11:16:16 -0800 (PST) Received: from [192.168.2.145] (109-252-193-159.dynamic.spd-mgts.ru. [109.252.193.159]) by smtp.googlemail.com with ESMTPSA id z19sm721401lfd.128.2020.11.12.11.16.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2020 11:16:15 -0800 (PST) Subject: Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling To: Mark Brown References: <20201104234427.26477-1-digetx@gmail.com> <20201104234427.26477-12-digetx@gmail.com> <20201110202945.GF2375022@ulmo> <20201110203257.GC5957@sirena.org.uk> <72ae6462-13df-9fcb-510e-8e57eee0f035@gmail.com> <20201111115534.GA4847@sirena.org.uk> <20201112171600.GD4742@sirena.org.uk> From: Dmitry Osipenko Message-ID: Date: Thu, 12 Nov 2020 22:16:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201112171600.GD4742@sirena.org.uk> Content-Language: en-US X-Mailman-Approved-At: Fri, 13 Nov 2020 08:38:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , Ulf Hansson , Liam Girdwood , dri-devel@lists.freedesktop.org, Adrian Hunter , devicetree@vger.kernel.org, Thierry Reding , Lee Jones , Marek Szyprowski , devel@driverdev.osuosl.org, linux-samsung-soc@vger.kernel.org, Nicolas Chauvet , Krzysztof Kozlowski , Jonathan Hunter , Alan Stern , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MTIuMTEuMjAyMCAyMDoxNiwgTWFyayBCcm93biDQv9C40YjQtdGCOgo+IE9uIFRodSwgTm92IDEy LCAyMDIwIGF0IDA3OjU5OjM2UE0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPj4gMTEu MTEuMjAyMCAxNDo1NSwgTWFyayBCcm93biDQv9C40YjQtdGCOgo+Pj4gT24gV2VkLCBOb3YgMTEs IDIwMjAgYXQgMTI6MjM6NDFBTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+IAo+Pj4+ IEkgYWxyZWFkeSBjaGFuZ2VkIHRoYXQgY29kZSB0byB1c2UgcmVndWxhdG9yX2dldF9vcHRpb25h bCgpIGZvciB2Mi4KPiAKPj4+IFRoYXQgZG9lc24ndCBsb29rIGVudGlyZWx5IGFwcHJvcHJpYXRl IGdpdmVuIHRoYXQgdGhlIGNvcmUgZG9lcyBtb3N0Cj4+PiBsaWtlbHkgcmVxdWlyZSBzb21lIGtp bmQgb2YgcG93ZXIgdG8gb3BlcmF0ZS4KPiAKPj4gV2Ugd2lsbCBuZWVkIHRvIGRvIHRoaXMgYmVj YXVzZSBvbGRlciBEVEJzIHdvbid0IGhhdmUgdGhhdCByZWd1bGF0b3IgYW5kCj4+IHdlIHdhbnQg dG8ga2VlcCB0aGVtIHdvcmtpbmcuCj4gCj4+IEFsc28sIHNvbWUgZGV2aWNlLXRyZWVzIHdvbid0 IGhhdmUgdGhhdCByZWd1bGF0b3IgYW55d2F5cyBiZWNhdXNlIGJvYXJkCj4+IHNjaGVtYXRpY3Mg aXNuJ3QgYXZhaWxhYmxlLCBhbmQgdGh1cywgd2UgY2FuJ3QgZml4IHRoZW0uCj4gCj4gVGhpcyBp cyB3aGF0IGR1bW15IHN1cHBsaWVzIGFyZSBmb3I/CgpCdXQgaXQncyBub3QgYWxsb3dlZCB0byBj aGFuZ2Ugdm9sdGFnZSBvZiBhIGR1bW15IHJlZ3VsYXRvciwgaXMgaXQKaW50ZW50aW9uYWw/Cgo+ Pj4+IFJlZ2FyZGluZyB0aGUgZW51bWVyYXRpbmcgc3VwcG9ydGVkIHZvbHRhZ2UuLiBJIHRoaW5r IHRoaXMgc2hvdWxkIGJlCj4+Pj4gZG9uZSBieSB0aGUgT1BQIGNvcmUsIGJ1dCByZWd1bGF0b3Ig Y29yZSBkb2Vzbid0IHdvcmsgd2VsbCBpZgo+Pj4+IHJlZ3VsYXRvcl9nZXQoKSBpcyBpbnZva2Vk IG1vcmUgdGhhbiBvbmUgdGltZSBmb3IgdGhlIHNhbWUgZGV2aWNlLCBhdAo+Pj4+IGxlYXN0IHRo ZXJlIGlzIGEgbG91ZCBkZWJ1Z2ZzIHdhcm5pbmcgYWJvdXQgYW4gYWxyZWFkeSBleGlzdGluZwo+ IAo+Pj4gSSBkb24ndCB1bmRlcnN0YW5kIHdoeSB0aGlzIHdvdWxkIGJlIGFuIGlzc3VlIC0gaWYg bm90aGluZyBlbHNlIHRoZSBjb3JlCj4+PiBjb3VsZCBqdXN0IG9mZmVyIGFuIGludGVyZmFjZSB0 byB0cmlnZ2VyIHRoZSBjaGVjay4KPiAKPj4gSXQncyBub3QgYW4gaXNzdWUsIEkganVzdCBkZXNj cmliZWQgd2hhdCBoYXBwZW5zIHdoZW4gZGV2aWNlIGRyaXZlcgo+PiB0cmllcyB0byBnZXQgYSBy ZWd1bGF0b3IgdHdpY2UuCj4gCj4+IFRoZXJlIHdhcyBhbiBpc3N1ZSBvbmNlIHRoYXQgY2hlY2sg aXMgYWRkZWQgdG8gdGhlIHJlZ3VsYXRvciBjb3JlIGNvZGUuCj4+IEJ1dCBwZXJoYXBzIG5vdCB3 b3J0aCB0byBkaXNjdXNzIGl0IGZvciBub3cgYmVjYXVzZSBJIGRvbid0IHJlbWVtYmVyCj4+IGRl dGFpbHMuCj4gCj4gU28gdGhlcmUncyBubyBrbm93biBvYnN0YWNsZSB0byBwdXR0aW5nIGVudW1l cmF0aW9uIG9mIHN1cHBvcnRlZAo+IHZvbHRhZ2VzIGludG8gdGhlIE9QUCBjb3JlIHRoZW4/ICBJ J20gYSBiaXQgY29uZnVzZWQgaGVyZS4KCkl0J3MgYW4gb2JzdGFjbGUgaWYgYm90aCBPUFAgYW5k IGRldmljZSBkcml2ZXIgbmVlZCB0byBnZXQgdGhlIHNhbWUKcmVndWxhdG9yLiBMaWtlIGluIHRo ZSBjYXNlIG9mIHRoaXMgRFJNIGRyaXZlciwgd2hpY2ggbmVlZCB0byBjb250cm9sCnRoZSB2b2x0 YWdlIGluc3RlYWQgb2YgYWxsb3dpbmcgT1BQIGNvcmUgdG8gZG8gaXQuCgpQbGVhc2Ugbm90aWNl IHRoYXQgZGV2bV90ZWdyYV9kY19vcHBfdGFibGVfaW5pdCgpIG9mIHRoaXMgcGF0Y2ggZG9lc24n dAp1c2UgZGV2X3BtX29wcF9zZXRfcmVndWxhdG9ycygpLCB3aGljaCB3b3VsZCBhbGxvdyBPUFAg Y29yZSB0byBmaWx0ZXIKb3V0IHVuc3VwcG9ydGVkIE9QUHMuIEJ1dCB0aGVuIE9QUCBjb3JlIHdp bGwgbmVlZCBuZWVkIHRvIGdldCBhbiBhbHJlYWR5CnJlcXVlc3RlZCByZWd1bGF0b3IgYW5kIHRo aXMgZG9lc24ndCB3b3JrIHdlbGwuCgo+Pj4+IGRpcmVjdG9yeSBmb3IgYSByZWd1bGF0b3IuIEl0 J3MgZWFzeSB0byBjaGVjayB3aGV0aGVyIHRoZSBkZWJ1Zwo+Pj4+IGRpcmVjdG9yeSBleGlzdHMg YmVmb3JlIGNyZWF0aW5nIGl0LCBsaWtlIHRoZXJtYWwgZnJhbWV3b3JrIGRvZXMgaXQgZm9yCj4+ Pj4gZXhhbXBsZSwgYnV0IHRoZW4gdGhlcmUgd2VyZSBzb21lIG90aGVyIG1vcmUgZGlmZmljdWx0 IGlzc3Vlcy4uIEkgZG9uJ3QKPj4+PiByZWNhbGwgd2hhdCB0aGV5IHdlcmUgcmlnaHQgbm93LiBQ ZXJoYXBzIHdpbGwgYmUgZWFzaWVyIHRvIHNpbXBseSBnZXQgYQo+Pj4+IGVycm9yIGZyb20gcmVn dWxhdG9yX3NldF92b2x0YWdlKCkgZm9yIG5vdyBiZWNhdXNlIGl0IHNob3VsZG4ndCBldmVyCj4+ Pj4gaGFwcGVuIGluIHByYWN0aWNlLCB1bmxlc3MgZGV2aWNlLXRyZWUgaGFzIHdyb25nIGNvbnN0 cmFpbnRzLgo+IAo+Pj4gVGhlIGNvbnN0cmFpbnRzIG1pZ2h0IG5vdCBiZSB3cm9uZywgdGhlcmUg bWlnaHQgYmUgc29tZSBib2FyZCB3aGljaCBoYXMKPj4+IGEgY29uc3RyYWludCBzb21ld2hlcmUg Zm9yIAo+IAo+PiBJbiB0aGlzIGNhc2UgYm9hcmQncyBEVCBzaG91bGRuJ3Qgc3BlY2lmeSB1bnN1 cHBvcnRhYmxlIE9QUHMuCj4gCj4gQWgsIHNvIGVhY2ggYm9hcmQgZHVwbGljYXRlcyB0aGUgT1BQ IHRhYmxlcyB0aGVuLCBvciB0aGVyZSdzIGFuCj4gZXhwZWN0YXRpb24gdGhhdCBpZiB0aGVyZSdz IHNvbWUgbGltaXQgdGhlbiB0aGV5J2xsIGNvcHkgYW5kIG1vZGlmeSB0aGUKPiB0YWJsZT8gIElm IHRoYXQncyB0aGUgY2FzZSB0aGVuIGl0J3MgYSBiaXQgcmVkdW5kYW50IHRvIGRvIGZpbHRlcmlu Zwo+IGluZGVlZC4KCkkgdGhpbmsgdGhpcyBpcyBub3Qgc3RyaWN0bHkgZGVmaW5lZC4gRWl0aGVy IHdheSB3aWxsIHdvcmssIGFsdGhvdWdoCnBlcmhhcHMgaXQgc2hvdWxkIGJlIG1vcmUgcHJlZmVy cmVkIHRoYXQgdW5zdXBwb3J0ZWQgT1BQcyBhcmVuJ3QgcHJlc2VudAppbiBhIGRldmljZS10cmVl LgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK